Re: Review Request 17270: Bridge framework for client v2.
On Feb. 3, 2014, 2:15 p.m., Bill Farner wrote: Ship It! brian, ping? can't ship without shipits from everyone on the People line. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- On Jan. 30, 2014, 4:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/ --- (Updated Jan. 30, 2014, 4:03 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-76 https://issues.apache.org/jira/browse/aurora-76 Repository: aurora Description --- Bridge framework for client v2. Diffs - src/main/python/apache/aurora/client/bin/BUILD 46695b423663c8e970773714c3dcb7de1046a9fb src/main/python/apache/aurora/client/cli/BUILD 8828c1e68b3ae7793fb0bb081730e0ff8fff5ed1 src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/bridge.py PRE-CREATION src/main/python/apache/aurora/client/cli/client.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_bridge.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_create.py 64eb51be32f33de7d67962ff9300e64820a37baf src/test/python/apache/aurora/client/cli/test_diff.py 32433c17322e52c4ffb005bcc620fba56e728879 src/test/python/apache/aurora/client/cli/test_kill.py 714d5fbeebaaba6cede438c40b3b370d0ee99934 src/test/python/apache/aurora/client/cli/test_status.py efcf164682a56294863a2aec916b9382a50032b7 Diff: https://reviews.apache.org/r/17270/diff/ Testing --- [sun-wukong incubator-aurora (bridge)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.31 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.41 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.28 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . = 1 passed in 0.23 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.22 seconds == test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 0.60 seconds test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py = 20 passed in 0.25 seconds = test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 26 items src/test/python/apache/aurora/client/api/test_updater.py .. = 26 passed in 0.44 seconds
Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/#review33802 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java https://reviews.apache.org/r/17785/#comment63415 Revert? src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java https://reviews.apache.org/r/17785/#comment63416 Old habits die hard? :) - Maxim Khutornenko On Feb. 6, 2014, 6:29 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/ --- (Updated Feb. 6, 2014, 6:29 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-194 https://issues.apache.org/jira/browse/AURORA-194 Repository: aurora Description --- Since the introduction of the THROTTLED state, the Preemptor and TaskScheduler were considering tasks in this state as active tasks on hosts within the job. In the case of Preemptor, this results in NullPointerException when trying to get the host of tasks in this state. I haven't observed the same for TaskScheduler, but i believe the same would be true when AttributeFilter finally tries to extract the slave host. Diffs - src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 9d00315e4bdb4ef709ee43f250b470e38b372c7e src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 53574814583ce7a5577e7b36af660f2c660618ca src/main/java/org/apache/aurora/scheduler/base/Tasks.java 0375b9649eb1704975f32354164b13af62f7718d src/main/thrift/org/apache/aurora/gen/api.thrift 77cd09ec91afc98910a867c2632c790a8e0a72ce src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java bf097d7bd7f7282766163aa53e1646282b22591f src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 4c86d8abc5ae3c5eae9f01bb085358844a87bb60 src/test/resources/org/apache/aurora/gen/api.thrift.md5 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d Diff: https://reviews.apache.org/r/17785/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33811 --- src/main/python/apache/aurora/client/cli/role.py https://reviews.apache.org/r/17332/#comment63422 is this supposed to have been removed? src/test/python/apache/aurora/client/cli/test_quota.py https://reviews.apache.org/r/17332/#comment63423 duped with test_get_quota.py? - Jonathan Boulle On Feb. 5, 2014, 3:08 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 3:08 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- src/main/python/apache/aurora/client/cli/role.py https://reviews.apache.org/r/17332/#comment63426 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. - Mark Chu-Carroll On Feb. 5, 2014, 10:08 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
On Feb. 6, 2014, 6:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. Mark Chu-Carroll wrote: Check with rbt diff, and it does *not* include role.py. So this is just a UI glitch in RBT. Same story with test_get_quota.py? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- On Feb. 5, 2014, 3:08 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 3:08 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. Mark Chu-Carroll wrote: Check with rbt diff, and it does *not* include role.py. So this is just a UI glitch in RBT. Jonathan Boulle wrote: Same story with test_get_quota.py? Yup. Given that the UI is screwed up, maybe look at the diff using rbt diff on the command line? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- On Feb. 5, 2014, 10:08 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
On Feb. 6, 2014, 10:36 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in my branch. I'm not sure what to do to fix the review - rbt doesn't see any diff, because the file's already gone. Mark Chu-Carroll wrote: Check with rbt diff, and it does *not* include role.py. So this is just a UI glitch in RBT. Jonathan Boulle wrote: Same story with test_get_quota.py? Mark Chu-Carroll wrote: Yup. Given that the UI is screwed up, maybe look at the diff using rbt diff on the command line? Mark: ./rbt diff will only you what would be sent. It won't work for Jon since he doesn't have your branch. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- On Feb. 5, 2014, 7:08 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 7:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33825 --- Ship it! src/main/python/apache/aurora/client/cli/quota.py https://reviews.apache.org/r/17332/#comment63436 nit: s/print/render/ src/main/python/apache/aurora/client/cli/quota.py https://reviews.apache.org/r/17332/#comment63435 could this be bounded a little more narrowly? what about other bad response codes? - Jonathan Boulle On Feb. 5, 2014, 3:08 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 3:08 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 6, 2014, 2:19 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- re-uploading changes to try to unglitch rbt. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 6, 2014, 2:27 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- address jonboulle's review comments. Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17730: Now sorting roles before displaying them on home page.
On Feb. 5, 2014, 8:28 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 25 https://reviews.apache.org/r/17730/diff/2/?file=469965#file469965line25 JavaScript ignoramus here, but have you considered localeCompare() [1]? This StackOverflow answer [2] mentions it. [1] https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/String/localeCompare [2] http://stackoverflow.com/questions/51165/how-do-you-do-string-comparison-in-javascript localeCompare doesn't sort based on ascii values in the way we want them to for example: 1, 2, 10 will be sorted as 1, 10, 2. So, using a sort function for now. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/#review33719 --- On Feb. 5, 2014, 7:14 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/ --- (Updated Feb. 5, 2014, 7:14 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-190 https://issues.apache.org/jira/browse/AURORA-190 Repository: aurora Description --- Now sorting roles before displaying them on home page to match the old UI behavior. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 9a2fdf103c7c6e4387464a05a151e3d842f90e12 src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 2601da9ef64ef91cbf9db9b6f12a8d2cdbb0c297 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 0abd3e737e901f08d18c3ceb55ea2f94847cc2e1 Diff: https://reviews.apache.org/r/17730/diff/ Testing --- gradle clean build. gradle run with fake summary data. Thanks, Suman Karumuri
Re: Review Request 17730: Now sorting roles before displaying them on home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/ --- (Updated Feb. 6, 2014, 7:32 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Added TODO. Bugs: AURORA-190 https://issues.apache.org/jira/browse/AURORA-190 Repository: aurora Description --- Now sorting roles before displaying them on home page to match the old UI behavior. Diffs (updated) - src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 9a2fdf103c7c6e4387464a05a151e3d842f90e12 src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 2601da9ef64ef91cbf9db9b6f12a8d2cdbb0c297 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 0abd3e737e901f08d18c3ceb55ea2f94847cc2e1 Diff: https://reviews.apache.org/r/17730/diff/ Testing --- gradle clean build. gradle run with fake summary data. Thanks, Suman Karumuri
Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails
On Feb. 5, 2014, 2:18 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/command_runner.py, line 139 https://reviews.apache.org/r/17724/diff/1/?file=469319#file469319line139 It's API level, because this is the highest level shared by all of the distinct code points that could call it. I didn't want to repeat the same try/catch multiple times in multiple places - in particular, because at some point, I'd really like to clean up the Pystachio error handling throughout the client, and having multiple copies of the same thing would make that more painful. The reason that it doesn't generate anything more specific is because that's already happening. In the current code, you get an error message saying TypeError: CommandRunnerTrait[slave_run_directory] is required.. The problem that I'm trying to fix is that for users, that's not particularly clear. Now, they'll see Error executing command: slave doesn't define necessary parameters, CommandRunnerTrain[slave_run_directory] is required. Mark Chu-Carroll wrote: ping? I tend to agree with both of you that it's rather suboptimal - could you add a TODO for error handling cleanup? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/#review33674 --- On Feb. 4, 2014, 9:49 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ --- (Updated Feb. 4, 2014, 9:49 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-128 https://issues.apache.org/jira/browse/aurora-128 Repository: aurora Description --- Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. Diffs - src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727 src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing --- Manual testing on the command line. Thanks, Mark Chu-Carroll
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33840 --- Did this ever land? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 10:37 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution First part of Aurora-145 which makes easy mock and zookeeper testing part of the test compile only. Part two will be to look at 3rd party dependencies and see what we can do to make the dist smaller. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java d8c40222809f525ce485a002873f1fe9dedc2748 src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 041d1f9937672df64864be09bbc4fd2a38b9b1ab src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/17818/diff/ Testing --- ran all unit tests with no failures Thanks, Jake Farrell
Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33844 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/17729/#comment63461 Done. - Maxim Khutornenko On Feb. 5, 2014, 1:59 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/ --- (Updated Feb. 5, 2014, 1:59 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-192 https://issues.apache.org/jira/browse/AURORA-192 Repository: aurora Description --- Removing JobConfigValidation from populateJobConfig RPC to finalize migration to client quota checks. Diffs - src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 15ff590ecebe8d87ba66a55ed176fb22122b354a src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 8ad24f9762854fa8f1ed19dfd95ca4a50640cbf3 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 479c2d9b3ee522d7feb125f5dea0973abb5b18b6 src/main/python/apache/aurora/client/api/__init__.py fbdf2b3f98d1b96da72dee98bc0b74ec1b79e243 src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/thrift/org/apache/aurora/gen/api.thrift 77cd09ec91afc98910a867c2632c790a8e0a72ce src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 79f09cd856be28f227fc76fb5a8e3298fb785a3a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02b7a27e0a9ec5226d9d043de8bf4739fb151b09 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 62fc8045f6a5fda234df73452685bd04e3142aaf src/test/python/apache/aurora/client/api/test_updater.py eabb938ead5b3bab067339ae085dbe2fd262d6a7 src/test/resources/org/apache/aurora/gen/api.thrift.md5 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d Diff: https://reviews.apache.org/r/17729/diff/ Testing --- gradle clean build ./pants src/test/python/apache/aurora:all aurora_client diff/update in vagrant with/without JobConfigValidation in api.thrift Thanks, Maxim Khutornenko
Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ --- (Updated Feb. 6, 2014, 4:40 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Better? Bugs: aurora-128 https://issues.apache.org/jira/browse/aurora-128 Repository: aurora Description --- Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations. Diffs (updated) - src/main/python/apache/aurora/client/api/command_runner.py f7605f40b5c4ec864a1bae68649f282268260528 src/main/python/apache/aurora/client/commands/run.py 332bded632ee4cfc0a986540239cb4cc296807ea src/main/python/apache/aurora/client/commands/ssh.py d1499ec1e9e910bc32f5f9f4b050c53316348503 src/test/python/apache/aurora/client/commands/test_run.py abcc275d57373038227d3805c16b17b967f92048 Diff: https://reviews.apache.org/r/17724/diff/ Testing --- Manual testing on the command line. Thanks, Mark Chu-Carroll
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review33846 --- No ship. AbstractCronIT is used by QuartzCronIT in https://reviews.apache.org/r/17750/ Merging AbstractCronIT and QuartzCronIT is on the list of followup TODOs for that review, so this will be mitigated then. - Kevin Sweeney On Feb. 6, 2014, 12:57 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- (Updated Feb. 6, 2014, 12:57 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution First part of Aurora-145 which makes easy mock and zookeeper testing part of the test compile only. Part two will be to look at 3rd party dependencies and see what we can do to make the dist smaller. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java d8c40222809f525ce485a002873f1fe9dedc2748 src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 041d1f9937672df64864be09bbc4fd2a38b9b1ab src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/17818/diff/ Testing --- ran all unit tests with no failures Thanks, Jake Farrell
Re: Review Request 17723: Implementing support for DRAINING state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17723/#review33847 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 1:31 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17723/ --- (Updated Feb. 4, 2014, 1:31 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-82 https://issues.apache.org/jira/browse/AURORA-82 Repository: aurora Description --- Implementing support for DRAINING state. Diffs - src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java a9ee32b6021b21d71db71b44e2eca2b984143718 src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 64a1941a3b92e65c057d64edd9a823e4f89807d1 src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 4cfe6fe14083d018a9143e0279d8f9a392a54019 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java af10d44431b9bc0aec20a36a45ff74ccb1365736 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java ebccc7479b0f632e585010bf9943db8f75f5ca7c src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java aa54659f309eab41f4299fecb99dda719005c147 src/main/thrift/org/apache/aurora/gen/api.thrift 77cd09ec91afc98910a867c2632c790a8e0a72ce src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java d4685f65f8695b20b8c52e2e983e57099f578bef src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java f7f7632315496af085ef2f3783e7bb87fc4d23be src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java cc7d59dca749f67686c41064eeda6e62a380ffeb src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java f6ece9c35d5610e5522f000f87002a2fd5614484 src/test/resources/org/apache/aurora/gen/api.thrift.md5 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d Diff: https://reviews.apache.org/r/17723/diff/ Testing --- gradle clean test Thanks, Maxim Khutornenko
