Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:02 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs (updated) - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59771 --- Master (9ef905a) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 3:35 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-617 https://issues.apache.org/jira/browse/AURORA-617 Repository: aurora Description --- Convert python_requirements links in 3rdparty/python/BUILD to be in requirements.txt Diffs - 3rdparty/python/BUILD 76d0bc58a72cd84c43f053082ee58e9c582e5437 3rdparty/python/requirements.txt PRE-CREATION Diff: https://reviews.apache.org/r/27492/diff/ Testing --- ./pants src/test/python:all ...which failed on one test in test_gc_executor.py, but the same test is failing for me in master. Thanks, Dan Norris
Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59814 --- Ship it! Ship It! - Bill Farner On Nov. 3, 2014, 11:09 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/ --- (Updated Nov. 3, 2014, 11:09 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Replace twitter.commons.io.FileUtils dependency w/ guava's Files Diffs - build.gradle a68de0ddc29f7a8e7b0ab6b83a7542a2527c91cd src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 91a92c6da09dc621db0b549f463d3a5c360efe6c src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35 src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 3a3c95e0a2a7fe3ea1a95b8a9ee5e2702ce67037 Diff: https://reviews.apache.org/r/27545/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59816 --- Ship it! Ship It! - Kevin Sweeney On Nov. 4, 2014, 11:55 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 11:55 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59821 --- Master (9ef905a) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.api.updater_util . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.logging . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.commands.admin . SUCCESS src.test.python.apache.aurora.client.commands.core . FAILURE src.test.python.apache.aurora.client.config . SUCCESS - Aurora ReviewBot On Nov. 4, 2014, 7:55 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 7:55 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 1:22 p.m.) Review request for Aurora and Bill Farner. Changes --- Add tests to cover different PEX-INFO formats. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59840 --- src/test/python/apache/aurora/client/commands/test_version.py https://reviews.apache.org/r/27586/#comment101122 Asserting on call count here is a pretty weak test. We could call print 4 times for any number of reasons, can we not verify that output matches what we'd expect given the mocked data from build info? - Joshua Cohen On Nov. 4, 2014, 9:22 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 9:22 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59844 --- Ship it! Master (9ef905a) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 4, 2014, 9:22 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 9:22 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.
On Nov. 3, 2014, 11:40 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/KillRetry.java, lines 84-85 https://reviews.apache.org/r/27467/diff/3/?file=747840#file747840line84 Since you're not using atomic CAS operations here you don't gain anything by using an `AtomicLong` over a `volatile` here. I could, though i tend to generally favor AtomicLong as a general replacement for `volatile long`. Fewer tools. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59680 --- On Nov. 3, 2014, 10:46 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/ --- (Updated Nov. 3, 2014, 10:46 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-910 https://issues.apache.org/jira/browse/AURORA-910 Repository: aurora Description --- Retry Driver.killTask periodically until the task changes states. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java df7e56a955fef21d48e75797bb5761453ae1e57a src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 748aac83db7c470dc7aed7936e629400c3e6c2d8 src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 1688a339a1a9c4072d7f834963cb5ccad6fe0736 Diff: https://reviews.apache.org/r/27467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59851 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 9:39 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Review Request 27598: Fixing the log replay for the job update history pruner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59867 --- Ship it! Master (9847b7b) is green with this patch. ./build-support/jenkins/build.sh - Aurora ReviewBot On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 11:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59869 --- Can you re-post your diff to prove a green response from the build bot? Stinks that we still have to do this, but it's good to shoot for a green reply. - Bill Farner On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 9:39 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. - Bill Farner On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 11:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. For one, static analysis tools will no longer catch missing case coverage - it's actually the opposite. There was no previous enforcement but after this refactoring there must be a test case or the build fails with this: ``` Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$21 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$11 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$10 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$13 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$12 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$15 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$17 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$16 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$18 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$20 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$2 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$3 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$4 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$5 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$9 ``` - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 11:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. Maxim Khutornenko wrote: For one, static analysis tools will no longer catch missing case coverage - it's actually the opposite. There was no previous enforcement but after this refactoring there must be a test case or the build fails with this: ``` Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$21 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$11 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$10 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$13 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$12 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$15 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$17 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$16 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$18 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$20 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$2 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$3 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$4 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$5 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$9 ``` Touche! That's even better. However, i still would rather avoid leaking the internal Map if we can help it. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 11:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. Maxim Khutornenko wrote: For one, static analysis tools will no longer catch missing case coverage - it's actually the opposite. There was no previous enforcement but after this refactoring there must be a test case or the build fails with this: ``` Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$21 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$11 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$10 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$13 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$12 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$15 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$17 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$16 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$18 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$20 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$2 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$3 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$4 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$5 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$9 ``` Bill Farner wrote: Touche! That's even better. However, i still would rather avoid leaking the internal Map if we can help it. I am not sure how else we can fully validate the expected coverage without exposing the internal defs. Any suggestions? - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 11:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. Maxim Khutornenko wrote: For one, static analysis tools will no longer catch missing case coverage - it's actually the opposite. There was no previous enforcement but after this refactoring there must be a test case or the build fails with this: ``` Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$21 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$11 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$10 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$13 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$12 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$15 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$17 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$16 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$18 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$20 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$2 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$3 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$4 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$5 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$9 ``` Bill Farner wrote: Touche! That's even better. However, i still would rather avoid leaking the internal Map if we can help it. Maxim Khutornenko wrote: I am not sure how else we can fully validate the expected coverage without exposing the internal defs. Any suggestions? Bill Farner wrote: Move the map to the test, make sure you have test data for every enum value for `LogEntry._Fields` and `Op._Fields`. Would not that be less safe though? Test code could inadvertently fake coverage without verifying the production side. Given that map-exposing methods are package internal I don't see how that could mess anything up. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 11:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 3:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. Maxim Khutornenko wrote: For one, static analysis tools will no longer catch missing case coverage - it's actually the opposite. There was no previous enforcement but after this refactoring there must be a test case or the build fails with this: ``` Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$21 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$11 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$10 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$13 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$12 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$15 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$17 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$16 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$18 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$20 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$2 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$3 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$4 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$5 Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$9 ``` Bill Farner wrote: Touche! That's even better. However, i still would rather avoid leaking the internal Map if we can help it. Maxim Khutornenko wrote: I am not sure how else we can fully validate the expected coverage without exposing the internal defs. Any suggestions? Bill Farner wrote: Move the map to the test, make sure you have test data for every enum value for `LogEntry._Fields` and `Op._Fields`. Maxim Khutornenko wrote: Would not that be less safe though? Test code could inadvertently fake coverage without verifying the production side. Given that map-exposing methods are package internal I don't see how that could mess anything up. After going back and forth I really like this factoring of the production code - the ability to write ```java assertEquals(A handler exists for each log entry type., EnumSet.allOf(LogEntry._Fields.class), dispatchers.keySet()); ``` in a test is powerful. It also lets us factor out unweildly handlers into their own separately-tested classes with their own dependencies as the need arises. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- On Nov. 4, 2014, 3:10 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 3:10 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Review Request 27601: Adding resource consumption calculation for cron jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/ --- Review request for Aurora. Repository: aurora Description --- Fixing cron template filtering issue. This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and subsequently reverted. The actual fix will follow shortly as a second diff to ease up reviewing. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670 Diff: https://reviews.apache.org/r/27601/diff/ Testing --- ./gradlew -Pq build Also, created multiple role cron jobs in vagrant to validate filtering. Thanks, Maxim Khutornenko
Re: Review Request 27601: Adding resource consumption calculation for cron jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/ --- (Updated Nov. 5, 2014, 1:08 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Actual fix. Repository: aurora Description (updated) --- Fixing cron template filtering issue. This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670 Diff: https://reviews.apache.org/r/27601/diff/ Testing --- ./gradlew -Pq build Also, created multiple role cron jobs in vagrant to validate filtering. Thanks, Maxim Khutornenko
Re: Review Request 27601: Adding resource consumption calculation for cron jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/#review59905 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . FAILURE - Aurora ReviewBot On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/ --- (Updated Nov. 5, 2014, 1:23 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-825 https://issues.apache.org/jira/browse/AURORA-825 Repository: aurora Description --- Fixing cron template filtering issue. This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670 Diff: https://reviews.apache.org/r/27601/diff/ Testing --- ./gradlew -Pq build Also, created multiple role cron jobs in vagrant to validate filtering. Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 4:43 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 318 https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318 why not initialize this inline? Maxim Khutornenko wrote: Not sure I get it. Don't we need a handle to pull these mappings into test? I'm proposing making the field `@VisibleForTesting` directly and reading it in the test. Slightly less code but either approach works. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59893 --- On Nov. 4, 2014, 5:52 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 4, 2014, 5:52 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59917 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 1:52 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- (Updated Nov. 5, 2014, 1:52 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912 https://issues.apache.org/jira/browse/AURORA-912 Repository: aurora Description --- Fixing the log replay for the job update history pruner. Also, refactored LogStorage replay routine to fully test all LogEntry/LogEntry.TRANSACTION handlers. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8eb5c3f7c542206066b39a09911c7df01a43bee7 Diff: https://reviews.apache.org/r/27598/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 27542: Add test coverage for WriteAheadStorage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/#review59918 --- Ship it! src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java https://reviews.apache.org/r/27542/#comment101243 duplicate asserts - Maxim Khutornenko On Nov. 3, 2014, 10:11 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/ --- (Updated Nov. 3, 2014, 10:11 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Bring WriteAheadStorage up to 100% branch and instruction coverage. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java cbab75964052a950e1b868b3a53eb15fadb31cb7 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION Diff: https://reviews.apache.org/r/27542/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 27598: Fixing the log replay for the job update history pruner.
On Nov. 4, 2014, 4:43 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line
318
https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318
why not initialize this inline?
Maxim Khutornenko wrote:
Not sure I get it. Don't we need a handle to pull these mappings into
test?
Kevin Sweeney wrote:
I'm proposing making the field `@VisibleForTesting` directly and reading
it in the test. Slightly less code but either approach works.
Maxim Khutornenko wrote:
Ah, I see what you meant now. Inlining isn't going to work here as
closures use writeBehind- instance fields and I'd rather not move that much
code into the constructor.
writeBehind is an instance field so they can use it from there. I'm proposing
(simplified)
```java
class OurClass {
private final Storage storage;
@VisibleForTesting
final MapField, ClosureEntry HANDLERS = ImmutableMap.builder()
.add(
REMOVE_TASK,
(entry) - storage.write(
(storeProvider) - storeProvider.getTaskStore().removeTask(
entry.getRemoveTask().getTaskId(
...
.build();
}
```
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27598/#review59893
---
On Nov. 4, 2014, 5:52 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27598/
---
(Updated Nov. 4, 2014, 5:52 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-912
https://issues.apache.org/jira/browse/AURORA-912
Repository: aurora
Description
---
Fixing the log replay for the job update history pruner.
Also, refactored LogStorage replay routine to fully test all
LogEntry/LogEntry.TRANSACTION handlers.
Diffs
-
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
cbab75964052a950e1b868b3a53eb15fadb31cb7
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
8eb5c3f7c542206066b39a09911c7df01a43bee7
Diff: https://reviews.apache.org/r/27598/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 6:52 p.m.) Review request for Aurora and Bill Farner. Changes --- Reposting to appease the robot. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs (updated) - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59923 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 5, 2014, 2:52 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59924 --- Bill, what should I do now? - Zameer Manji On Nov. 4, 2014, 6:52 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 6:52 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 7:34 p.m.) Review request for Aurora and Bill Farner. Changes --- Improve tests. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs (updated) - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27586: Increase robustness when reading PEX-INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59927 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 3:34 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 5, 2014, 3:34 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-456 https://issues.apache.org/jira/browse/AURORA-456 Repository: aurora Description --- This patch prevents aurora version from crashing when it is built with a different version of pants. Diffs - src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/27586/diff/ Testing --- [tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD, aurora_client)): Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:07 Aurora API version: APIVersion(major=3) [tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version Aurora client build info: sha: d03187404dac583884a979dd302dd3cd36163c98 date: Tuesday Nov 04, 2014 11:39:18 Aurora API version: APIVersion(major=3) Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
On Nov. 5, 2014, 3:12 a.m., Zameer Manji wrote: Bill, what should I do now? I'll run it locally to confirm the patch. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59924 --- On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 5, 2014, 2:52 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
