-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27598/#review59868
-----------------------------------------------------------


I'm not a fan of the refactor.  For one, static analysis tools will no longer 
catch missing case coverage, and we have to expose the internal detail of this 
map.  Instead, the unit test should self-check to make sure that it is 
exercising all transaction operation types.

- Bill Farner


On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27598/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:10 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-912
>     https://issues.apache.org/jira/browse/AURORA-912
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing the log replay for the job update history pruner.
> 
> Also, refactored LogStorage replay routine to fully test all 
> LogEntry/LogEntry.TRANSACTION handlers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> cbab75964052a950e1b868b3a53eb15fadb31cb7 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 8eb5c3f7c542206066b39a09911c7df01a43bee7 
> 
> Diff: https://reviews.apache.org/r/27598/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to