Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review46464 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment81853 redundant with the line below src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/22429/#comment81852 remove extra newline - Bill Farner On June 19, 2014, 7:57 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 19, 2014, 7:57 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434 src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259 src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151 Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 23, 2014, 10:36 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Changes --- Review feedback + rebase. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2 src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3807c1253469ca3250c1e0137fcf848afe79d06f src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5 Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
On June 23, 2014, 10:21 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 436 https://reviews.apache.org/r/22429/diff/4/?file=613082#file613082line436 redundant with the line below Removed. On June 23, 2014, 10:21 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 239 https://reviews.apache.org/r/22429/diff/4/?file=613083#file613083line239 remove extra newline Done. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review46464 --- On June 23, 2014, 10:36 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 23, 2014, 10:36 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2 src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3807c1253469ca3250c1e0137fcf848afe79d06f src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5 Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 23, 2014, 10:43 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2 src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3807c1253469ca3250c1e0137fcf848afe79d06f src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5 Diff: https://reviews.apache.org/r/22429/diff/ Testing (updated) --- ./gradlew build ./gradlew FlagSchemaChanges Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review46207 --- Can you verify that ./gradlew FlagSchemaChanges passes? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment81499 Drop @Nullable src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment81500 favor immutability: ImmutableSet.copyOf(input.getValue()) src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment81501 ImmutableSet.copyOf(groups) - Kevin Sweeney On June 12, 2014, 11:10 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 12, 2014, 11:10 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 19, 2014, 7:57 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Changes --- +Bill in case he has some comments. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434 src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259 src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151 Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 12, 2014, 5:38 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Review feedback. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review45514 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80372 s/taskByInstance/tasksByInstance - Maxim Khutornenko On June 12, 2014, 5:38 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 12, 2014, 5:38 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review45449 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80313 s/public/private? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80320 Better use: IJobKey jobKey = JobKeys.assertValid(IJobKey.build(mutableJobKey)); src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80314 This used only in one place. Consider inlining it. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80315 Any reason to do a deep copy of it here? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80316 This could be merged with activeTasks to eliminate naming confusion. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80318 s/byInstance/taskByInstance? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/22429/#comment80319 Merge it with okResponse(...)? src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java https://reviews.apache.org/r/22429/#comment80317 How about a test returning empty result in case job key has no match? - Maxim Khutornenko On June 10, 2014, 6:44 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 10, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/ --- (Updated June 10, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Fixing people line. Bugs: AURORA-519 https://issues.apache.org/jira/browse/AURORA-519 Repository: aurora Description --- Add getConfigGroupSummary API endpoint, which returns a TaskConfig - SetInstanceId struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22429/diff/ Testing --- ./gradlew build Thanks, David McLaughlin
