Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Jim Youll 


> On Feb. 28, 2014, 6:37 p.m., Jim Youll wrote:
> > would it be very hard to make that a command line / config file var rather 
> > than an env var? Then it would be set just like all other configurable 
> > params in a config file or with a command line override, and would be more 
> > sustainable.
> 
> Kevin Sweeney wrote:
> I don't think client-side health checking is long for this world and 
> executor-side health checking already supports this via 
> HealthCheckConfig.timeout_secs. The way the code is currently factored makes 
> adding a command-line flag somewhat messy.
> 
> That said you can add this to your .aurora config with
> 
> import os
> os.putenv('AURORA_HTTP_SIGNALER_TIMEOUT_SECS', '2.0')
> 
> And it will be respected. I'd recommend this over forcing the invoker to 
> remember to set an environment variable before invoking 'aurora'.

As the only configuration case handled that way, this is also messy. If the 
code is going away with 30 to 60 days, then I support this patch as an 
immediate remedy to an immediate problem. If the horizon is farther out, then 
we would be better off with something that matches existing conventions. 
Seriously it's that hard to add a confvar? yikes.


- Jim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35810
---


On Feb. 28, 2014, 2:37 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 2:37 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Kevin Sweeney 


> On Feb. 28, 2014, 10:37 a.m., Jim Youll wrote:
> > would it be very hard to make that a command line / config file var rather 
> > than an env var? Then it would be set just like all other configurable 
> > params in a config file or with a command line override, and would be more 
> > sustainable.

I don't think client-side health checking is long for this world and 
executor-side health checking already supports this via 
HealthCheckConfig.timeout_secs. The way the code is currently factored makes 
adding a command-line flag somewhat messy.

That said you can add this to your .aurora config with

import os
os.putenv('AURORA_HTTP_SIGNALER_TIMEOUT_SECS', '2.0')

And it will be respected. I'd recommend this over forcing the invoker to 
remember to set an environment variable before invoking 'aurora'.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35810
---


On Feb. 27, 2014, 6:37 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 27, 2014, 6:37 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35816
---

Ship it!


Ship It!

- Brian Wickman


On Feb. 28, 2014, 2:37 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 2:37 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Jim Youll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35810
---


would it be very hard to make that a command line / config file var rather than 
an env var? Then it would be set just like all other configurable params in a 
config file or with a command line override, and would be more sustainable.

- Jim Youll


On Feb. 28, 2014, 2:37 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 2:37 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35809
---

Ship it!


Ship It!

- Mark Chu-Carroll


On Feb. 27, 2014, 9:37 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 27, 2014, 9:37 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35755
---

Ship it!


Ship It!

- Maxim Khutornenko


On Feb. 28, 2014, 2:37 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 2:37 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---

(Updated Feb. 27, 2014, 6:37 p.m.)


Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

More of Maxim's feedback.


Bugs: AURORA-224
https://issues.apache.org/jira/browse/AURORA-224


Repository: aurora


Description
---

Make http signaler timeout secs configurable via an environment variable. This 
is a band-aid for the issue described in AURORA-224. Further improvements would 
be made possible by refactoring the updater to completely remove client-side 
health checking (delegating to thermos, which already supports a much richer 
system of delegated health checks).

I'm open to suggestions on how to make this feature more Aurora-y - I know 
environment variables have typically been discouraged since they can lead to 
flaky deploys, but I don't think this setting adds unnecessary risk and I see 
it as a short-term fix for some counter-intuitive behavior on our part.


Diffs (updated)
-

  src/main/python/apache/aurora/common/http_signaler.py 
b19b72d6400cef1a2e469b1853a7d49c063d5a25 

Diff: https://reviews.apache.org/r/18602/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Kevin Sweeney

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---

(Updated Feb. 27, 2014, 6:35 p.m.)


Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

Maxim's feedback.


Bugs: AURORA-224
https://issues.apache.org/jira/browse/AURORA-224


Repository: aurora


Description
---

Make http signaler timeout secs configurable via an environment variable. This 
is a band-aid for the issue described in AURORA-224. Further improvements would 
be made possible by refactoring the updater to completely remove client-side 
health checking (delegating to thermos, which already supports a much richer 
system of delegated health checks).

I'm open to suggestions on how to make this feature more Aurora-y - I know 
environment variables have typically been discouraged since they can lead to 
flaky deploys, but I don't think this setting adds unnecessary risk and I see 
it as a short-term fix for some counter-intuitive behavior on our part.


Diffs (updated)
-

  src/main/python/apache/aurora/common/http_signaler.py 
b19b72d6400cef1a2e469b1853a7d49c063d5a25 

Diff: https://reviews.apache.org/r/18602/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Kevin Sweeney

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney 


> On Feb. 27, 2014, 6:09 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/common/http_signaler.py, line 52
> > 
> >
> > Isn't it still the same problem here? Attempt to use %f for a string?

I'll go ahead and change this to %s so there'll be a useful log message right 
before the stack trace.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35748
---


On Feb. 27, 2014, 5:59 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 27, 2014, 5:59 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35748
---



src/main/python/apache/aurora/common/http_signaler.py


Up to you but I'd use inverted IF:

if self.timeout_secs:
 ...
else:
 ...



src/main/python/apache/aurora/common/http_signaler.py


Isn't it still the same problem here? Attempt to use %f for a string?


- Maxim Khutornenko


On Feb. 28, 2014, 1:59 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 1:59 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---

(Updated Feb. 27, 2014, 5:59 p.m.)


Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

Initialize later, add more logging (so for example someone could set the 
environment variable in their .aurora file).


Bugs: AURORA-224
https://issues.apache.org/jira/browse/AURORA-224


Repository: aurora


Description
---

Make http signaler timeout secs configurable via an environment variable. This 
is a band-aid for the issue described in AURORA-224. Further improvements would 
be made possible by refactoring the updater to completely remove client-side 
health checking (delegating to thermos, which already supports a much richer 
system of delegated health checks).

I'm open to suggestions on how to make this feature more Aurora-y - I know 
environment variables have typically been discouraged since they can lead to 
flaky deploys, but I don't think this setting adds unnecessary risk and I see 
it as a short-term fix for some counter-intuitive behavior on our part.


Diffs (updated)
-

  src/main/python/apache/aurora/common/http_signaler.py 
b19b72d6400cef1a2e469b1853a7d49c063d5a25 

Diff: https://reviews.apache.org/r/18602/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Kevin Sweeney

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35747
---



src/main/python/apache/aurora/common/http_signaler.py


Change line ordering here to avoid parsing error in %f


- Maxim Khutornenko


On Feb. 28, 2014, 1:45 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 1:45 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---

(Updated Feb. 27, 2014, 5:45 p.m.)


Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

Maxim's feedback.


Bugs: AURORA-224
https://issues.apache.org/jira/browse/AURORA-224


Repository: aurora


Description
---

Make http signaler timeout secs configurable via an environment variable. This 
is a band-aid for the issue described in AURORA-224. Further improvements would 
be made possible by refactoring the updater to completely remove client-side 
health checking (delegating to thermos, which already supports a much richer 
system of delegated health checks).

I'm open to suggestions on how to make this feature more Aurora-y - I know 
environment variables have typically been discouraged since they can lead to 
flaky deploys, but I don't think this setting adds unnecessary risk and I see 
it as a short-term fix for some counter-intuitive behavior on our part.


Diffs (updated)
-

  src/main/python/apache/aurora/common/http_signaler.py 
b19b72d6400cef1a2e469b1853a7d49c063d5a25 

Diff: https://reviews.apache.org/r/18602/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Kevin Sweeney

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35745
---



src/main/python/apache/aurora/common/http_signaler.py


If we are going this route, how about adding a log message to make it more 
visible?

Also, you might want to consider a more specific env var with AURORA in it 
to avoid an unlikely but possible collision.


- Maxim Khutornenko


On Feb. 28, 2014, 1:11 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18602/
> ---
> 
> (Updated Feb. 28, 2014, 1:11 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-224
> https://issues.apache.org/jira/browse/AURORA-224
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make http signaler timeout secs configurable via an environment variable. 
> This is a band-aid for the issue described in AURORA-224. Further 
> improvements would be made possible by refactoring the updater to completely 
> remove client-side health checking (delegating to thermos, which already 
> supports a much richer system of delegated health checks).
> 
> I'm open to suggestions on how to make this feature more Aurora-y - I know 
> environment variables have typically been discouraged since they can lead to 
> flaky deploys, but I don't think this setting adds unnecessary risk and I see 
> it as a short-term fix for some counter-intuitive behavior on our part.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/http_signaler.py 
> b19b72d6400cef1a2e469b1853a7d49c063d5a25 
> 
> Diff: https://reviews.apache.org/r/18602/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/
---

Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian 
Wickman.


Bugs: AURORA-224
https://issues.apache.org/jira/browse/AURORA-224


Repository: aurora


Description
---

Make http signaler timeout secs configurable via an environment variable. This 
is a band-aid for the issue described in AURORA-224. Further improvements would 
be made possible by refactoring the updater to completely remove client-side 
health checking (delegating to thermos, which already supports a much richer 
system of delegated health checks).

I'm open to suggestions on how to make this feature more Aurora-y - I know 
environment variables have typically been discouraged since they can lead to 
flaky deploys, but I don't think this setting adds unnecessary risk and I see 
it as a short-term fix for some counter-intuitive behavior on our part.


Diffs
-

  src/main/python/apache/aurora/common/http_signaler.py 
b19b72d6400cef1a2e469b1853a7d49c063d5a25 

Diff: https://reviews.apache.org/r/18602/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Kevin Sweeney