Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-15 Thread Joe Smith 


> On April 15, 2014, 10:42 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/common/shellify.py, line 7
> > 
> >
> > Any chance you can also put in sphinx-y/reStructuredText[1] docstrings 
> > for the params?
> > 
> > [1] http://sphinx-doc.org/domains.html#info-field-lists
> 
> Kevin Sweeney wrote:
> As far as I know we're not currently using this in the rest of the Python 
> codebase but it does look worthwhile to adopt. For the moment I've submitted 
> without; however feel free to open a followup ticket.

No worries, sounds good to me. Going forward I'd like us to take the time when 
adding new python code however


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/#review40413
---


On April 14, 2014, 6:25 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20046/
> ---
> 
> (Updated April 14, 2014, 6:25 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new subcommand to aurora_admin to dump cluster state as a shell script.
> 
> Useful to allow you to write shell scripts with the current cluster settings 
> without needing to duplicate information.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 2b37101ac4983300318db2d1e913782637019dec 
>   src/main/python/apache/aurora/common/BUILD 
> 5d1cfe0735a5d973234115e7f99556312f004427 
>   src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
>   src/test/python/apache/aurora/common/BUILD 
> 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
>   src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20046/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh devcluster
> AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> AURORA_CLUSTER_NAME=devcluster
> AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> AURORA_CLUSTER_ZK=192.168.33.7
> AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh --export devcluster
> export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> export AURORA_CLUSTER_NAME=devcluster
> export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> export AURORA_CLUSTER_ZK=192.168.33.7
> export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context devcluster 
> {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", 
> "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
> "scheduler_zk_path": "/aurora/scheduler"}
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-15 Thread Kevin Sweeney 


> On April 15, 2014, 10:42 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/common/shellify.py, line 7
> > 
> >
> > Any chance you can also put in sphinx-y/reStructuredText[1] docstrings 
> > for the params?
> > 
> > [1] http://sphinx-doc.org/domains.html#info-field-lists

As far as I know we're not currently using this in the rest of the Python 
codebase but it does look worthwhile to adopt. For the moment I've submitted 
without; however feel free to open a followup ticket.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/#review40413
---


On April 14, 2014, 6:25 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20046/
> ---
> 
> (Updated April 14, 2014, 6:25 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new subcommand to aurora_admin to dump cluster state as a shell script.
> 
> Useful to allow you to write shell scripts with the current cluster settings 
> without needing to duplicate information.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 2b37101ac4983300318db2d1e913782637019dec 
>   src/main/python/apache/aurora/common/BUILD 
> 5d1cfe0735a5d973234115e7f99556312f004427 
>   src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
>   src/test/python/apache/aurora/common/BUILD 
> 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
>   src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20046/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh devcluster
> AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> AURORA_CLUSTER_NAME=devcluster
> AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> AURORA_CLUSTER_ZK=192.168.33.7
> AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh --export devcluster
> export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> export AURORA_CLUSTER_NAME=devcluster
> export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> export AURORA_CLUSTER_ZK=192.168.33.7
> export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context devcluster 
> {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", 
> "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
> "scheduler_zk_path": "/aurora/scheduler"}
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-15 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/#review40413
---

Ship it!


This is rad, thanks!


src/main/python/apache/aurora/common/shellify.py


Any chance you can also put in sphinx-y/reStructuredText[1] docstrings for 
the params?

[1] http://sphinx-doc.org/domains.html#info-field-lists


- Joe Smith


On April 14, 2014, 6:25 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20046/
> ---
> 
> (Updated April 14, 2014, 6:25 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new subcommand to aurora_admin to dump cluster state as a shell script.
> 
> Useful to allow you to write shell scripts with the current cluster settings 
> without needing to duplicate information.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 2b37101ac4983300318db2d1e913782637019dec 
>   src/main/python/apache/aurora/common/BUILD 
> 5d1cfe0735a5d973234115e7f99556312f004427 
>   src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
>   src/test/python/apache/aurora/common/BUILD 
> 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
>   src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20046/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh devcluster
> AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> AURORA_CLUSTER_NAME=devcluster
> AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> AURORA_CLUSTER_ZK=192.168.33.7
> AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh --export devcluster
> export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> export AURORA_CLUSTER_NAME=devcluster
> export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> export AURORA_CLUSTER_ZK=192.168.33.7
> export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context devcluster 
> {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", 
> "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
> "scheduler_zk_path": "/aurora/scheduler"}
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-14 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/
---

(Updated April 14, 2014, 6:25 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
---

Update documentation.


Repository: aurora


Description
---

Add a new subcommand to aurora_admin to dump cluster state as a shell script.

Useful to allow you to write shell scripts with the current cluster settings 
without needing to duplicate information.


Diffs (updated)
-

  src/main/python/apache/aurora/client/commands/admin.py 
2b37101ac4983300318db2d1e913782637019dec 
  src/main/python/apache/aurora/common/BUILD 
5d1cfe0735a5d973234115e7f99556312f004427 
  src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
  src/test/python/apache/aurora/common/BUILD 
2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
  src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20046/diff/


Testing
---

./pants src/test/python:all

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context --sh devcluster
AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
AURORA_CLUSTER_NAME=devcluster
AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
AURORA_CLUSTER_ZK=192.168.33.7
AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context --sh --export devcluster
export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
export AURORA_CLUSTER_NAME=devcluster
export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
export AURORA_CLUSTER_ZK=192.168.33.7
export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context devcluster 
{"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", "name": 
"devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
"scheduler_zk_path": "/aurora/scheduler"}


Thanks,

Kevin Sweeney

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-05 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/#review39638
---

Ship it!



src/main/python/apache/aurora/client/commands/admin.py


A quick read of this doc doesn't help me figure out which information it's 
going to give me.  More details?



src/main/python/apache/aurora/client/commands/admin.py


s/ = /=/


- Bill Farner


On April 4, 2014, 7:35 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20046/
> ---
> 
> (Updated April 4, 2014, 7:35 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new subcommand to aurora_admin to dump cluster state as a shell script.
> 
> Useful to allow you to write shell scripts with the current cluster settings 
> without needing to duplicate information.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 2b37101ac4983300318db2d1e913782637019dec 
>   src/main/python/apache/aurora/common/BUILD 
> 5d1cfe0735a5d973234115e7f99556312f004427 
>   src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
>   src/test/python/apache/aurora/common/BUILD 
> 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
>   src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20046/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh devcluster
> AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> AURORA_CLUSTER_NAME=devcluster
> AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> AURORA_CLUSTER_ZK=192.168.33.7
> AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh --export devcluster
> export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> export AURORA_CLUSTER_NAME=devcluster
> export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> export AURORA_CLUSTER_ZK=192.168.33.7
> export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context devcluster 
> {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", 
> "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
> "scheduler_zk_path": "/aurora/scheduler"}
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-04 Thread Kevin Sweeney 


> On April 4, 2014, 12:27 p.m., Tobias Weingartner wrote:
> > src/test/python/apache/aurora/common/test_shellify.py, line 12
> > 
> >
> > How about adding test values/strings with:
> > 
> > ", ', \ (backslash), !, $, (, ), `, and ~ in as well.

This is all handled by the python pipes.quote standard library module. Since 
this isn't a test of that library pushing back (though I ran through these 
locally in the REPL and they all behaved as expected).


> On April 4, 2014, 12:27 p.m., Tobias Weingartner wrote:
> > src/test/python/apache/aurora/common/test_shellify.py, line 29
> > 
> >
> > Trailing space.

Done.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/#review39581
---


On April 4, 2014, 12:35 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20046/
> ---
> 
> (Updated April 4, 2014, 12:35 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new subcommand to aurora_admin to dump cluster state as a shell script.
> 
> Useful to allow you to write shell scripts with the current cluster settings 
> without needing to duplicate information.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 2b37101ac4983300318db2d1e913782637019dec 
>   src/main/python/apache/aurora/common/BUILD 
> 5d1cfe0735a5d973234115e7f99556312f004427 
>   src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
>   src/test/python/apache/aurora/common/BUILD 
> 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
>   src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20046/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh devcluster
> AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> AURORA_CLUSTER_NAME=devcluster
> AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> AURORA_CLUSTER_ZK=192.168.33.7
> AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh --export devcluster
> export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> export AURORA_CLUSTER_NAME=devcluster
> export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> export AURORA_CLUSTER_ZK=192.168.33.7
> export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context devcluster 
> {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", 
> "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
> "scheduler_zk_path": "/aurora/scheduler"}
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-04 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/
---

(Updated April 4, 2014, 12:35 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
---

Kill trailing whitespace.


Repository: aurora


Description
---

Add a new subcommand to aurora_admin to dump cluster state as a shell script.

Useful to allow you to write shell scripts with the current cluster settings 
without needing to duplicate information.


Diffs (updated)
-

  src/main/python/apache/aurora/client/commands/admin.py 
2b37101ac4983300318db2d1e913782637019dec 
  src/main/python/apache/aurora/common/BUILD 
5d1cfe0735a5d973234115e7f99556312f004427 
  src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
  src/test/python/apache/aurora/common/BUILD 
2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
  src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20046/diff/


Testing
---

./pants src/test/python:all

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context --sh devcluster
AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
AURORA_CLUSTER_NAME=devcluster
AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
AURORA_CLUSTER_ZK=192.168.33.7
AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context --sh --export devcluster
export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
export AURORA_CLUSTER_NAME=devcluster
export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
export AURORA_CLUSTER_ZK=192.168.33.7
export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context devcluster 
{"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", "name": 
"devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
"scheduler_zk_path": "/aurora/scheduler"}


Thanks,

Kevin Sweeney

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-04 Thread Tobias Weingartner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/#review39581
---



src/test/python/apache/aurora/common/test_shellify.py


How about adding test values/strings with:

", ', \ (backslash), !, $, (, ), `, and ~ in as well.



src/test/python/apache/aurora/common/test_shellify.py


Trailing space.


- Tobias Weingartner


On April 4, 2014, 7:21 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20046/
> ---
> 
> (Updated April 4, 2014, 7:21 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new subcommand to aurora_admin to dump cluster state as a shell script.
> 
> Useful to allow you to write shell scripts with the current cluster settings 
> without needing to duplicate information.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 2b37101ac4983300318db2d1e913782637019dec 
>   src/main/python/apache/aurora/common/BUILD 
> 5d1cfe0735a5d973234115e7f99556312f004427 
>   src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
>   src/test/python/apache/aurora/common/BUILD 
> 2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
>   src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20046/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh devcluster
> AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> AURORA_CLUSTER_NAME=devcluster
> AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> AURORA_CLUSTER_ZK=192.168.33.7
> AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context --sh --export devcluster
> export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
> export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
> export AURORA_CLUSTER_NAME=devcluster
> export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
> export AURORA_CLUSTER_ZK=192.168.33.7
> export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler
> 
> % ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
> dump_cluster_context devcluster 
> {"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", 
> "name": "devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
> "scheduler_zk_path": "/aurora/scheduler"}
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-04 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20046/
---

Review request for Aurora, Bill Farner and Brian Wickman.


Repository: aurora


Description
---

Add a new subcommand to aurora_admin to dump cluster state as a shell script.

Useful to allow you to write shell scripts with the current cluster settings 
without needing to duplicate information.


Diffs
-

  src/main/python/apache/aurora/client/commands/admin.py 
2b37101ac4983300318db2d1e913782637019dec 
  src/main/python/apache/aurora/common/BUILD 
5d1cfe0735a5d973234115e7f99556312f004427 
  src/main/python/apache/aurora/common/shellify.py PRE-CREATION 
  src/test/python/apache/aurora/common/BUILD 
2d9ba67e1ec94d61297dab16f2a78ba2ef6e8d2d 
  src/test/python/apache/aurora/common/test_shellify.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20046/diff/


Testing
---

./pants src/test/python:all

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context --sh devcluster
AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
AURORA_CLUSTER_NAME=devcluster
AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
AURORA_CLUSTER_ZK=192.168.33.7
AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context --sh --export devcluster
export AURORA_CLUSTER_SLAVE_RUN_DIRECTORY=latest
export AURORA_CLUSTER_AUTH_MECHANISM=UNAUTHENTICATED
export AURORA_CLUSTER_NAME=devcluster
export AURORA_CLUSTER_SLAVE_ROOT=/var/lib/mesos
export AURORA_CLUSTER_ZK=192.168.33.7
export AURORA_CLUSTER_SCHEDULER_ZK_PATH=/aurora/scheduler

% ./pants py src/main/python/apache/aurora/client/bin:aurora_admin 
dump_cluster_context devcluster 
{"slave_run_directory": "latest", "auth_mechanism": "UNAUTHENTICATED", "name": 
"devcluster", "slave_root": "/var/lib/mesos", "zk": "192.168.33.7", 
"scheduler_zk_path": "/aurora/scheduler"}


Thanks,

Kevin Sweeney