Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-23 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/
---

(Updated July 23, 2014, 5:10 p.m.)


Review request for Aurora and Kevin Sweeney.


Changes
---

Rebased on master.


Bugs: AURORA-555
https://issues.apache.org/jira/browse/AURORA-555


Repository: aurora


Description
---

Database-backed implementation of SchedulerStore.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
b4139eb5a6a9a281f7d2beaf04f7209b7c221980 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
94f03f0d66291bbf919aea9f5149e49f8b4c38da 
  src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
f5ed139610382a0a9aa057ed0ae33576201d6767 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
18925fd8a535e0cbcc41b9d322f49982378429ac 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
d3764c360c9ba4a7c4bb6734d54125c0757948c5 
  src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
ace97e3c414c7dc047d863fef896e074405eff9f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
1757ee3ba3b7f6fe18130294ed4f849bb0552e15 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
1e082ac659cb310ae6b8e81d6b324493dd450a2d 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
4c9d69c9674c74a9c11ad24276ec041d5ac209cb 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
0bb6cd25136ab2cadd6560bdd3843b28229fb3eb 
  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
57095cea18936fb2ddf92bce587aea58e81996c8 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 22a40481b5b246989c2e17a72a0325649382dde1 

Diff: https://reviews.apache.org/r/23107/diff/


Testing
---

./gradlew build -Pq


Thanks,

Bill Farner



Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-22 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review48448
---

Ship it!


Ship It!

- Kevin Sweeney


On July 1, 2014, 6:33 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23107/
 ---
 
 (Updated July 1, 2014, 6:33 p.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Bugs: AURORA-555
 https://issues.apache.org/jira/browse/AURORA-555
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Database-backed implementation of SchedulerStore.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 b4139eb5a6a9a281f7d2beaf04f7209b7c221980 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 94f03f0d66291bbf919aea9f5149e49f8b4c38da 
   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 f5ed139610382a0a9aa057ed0ae33576201d6767 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 348527997ea89fd71952a9f1ec0c67c3087f5a61 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 0d8ad6108b061f7b3c39e3ab5ff08841d0dd2733 
   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 77cd8abffca6bf20d753abe35ee212a7cf53668b 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 1757ee3ba3b7f6fe18130294ed4f849bb0552e15 
   
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
 a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 cc206314d93ea7b160df7f809d072f90e23cc4b3 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 65565f1bb14dd4c6425f67f27ea06566d57b65cf 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
  PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
 57095cea18936fb2ddf92bce587aea58e81996c8 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
  22a40481b5b246989c2e17a72a0325649382dde1 
 
 Diff: https://reviews.apache.org/r/23107/diff/
 
 
 Testing
 ---
 
 ./gradlew build -Pq
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-17 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review48074
---


Kevin - ping?

- Bill Farner


On July 2, 2014, 1:33 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23107/
 ---
 
 (Updated July 2, 2014, 1:33 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Bugs: AURORA-555
 https://issues.apache.org/jira/browse/AURORA-555
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Database-backed implementation of SchedulerStore.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 b4139eb5a6a9a281f7d2beaf04f7209b7c221980 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 94f03f0d66291bbf919aea9f5149e49f8b4c38da 
   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 f5ed139610382a0a9aa057ed0ae33576201d6767 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 348527997ea89fd71952a9f1ec0c67c3087f5a61 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 0d8ad6108b061f7b3c39e3ab5ff08841d0dd2733 
   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 77cd8abffca6bf20d753abe35ee212a7cf53668b 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 1757ee3ba3b7f6fe18130294ed4f849bb0552e15 
   
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
 a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 cc206314d93ea7b160df7f809d072f90e23cc4b3 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 65565f1bb14dd4c6425f67f27ea06566d57b65cf 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
  PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
 57095cea18936fb2ddf92bce587aea58e81996c8 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
  22a40481b5b246989c2e17a72a0325649382dde1 
 
 Diff: https://reviews.apache.org/r/23107/diff/
 
 
 Testing
 ---
 
 ./gradlew build -Pq
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-02 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review47192
---

Ship it!


Ship It!

- Maxim Khutornenko


On July 2, 2014, 1:33 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23107/
 ---
 
 (Updated July 2, 2014, 1:33 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Bugs: AURORA-555
 https://issues.apache.org/jira/browse/AURORA-555
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Database-backed implementation of SchedulerStore.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 b4139eb5a6a9a281f7d2beaf04f7209b7c221980 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 94f03f0d66291bbf919aea9f5149e49f8b4c38da 
   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 f5ed139610382a0a9aa057ed0ae33576201d6767 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 348527997ea89fd71952a9f1ec0c67c3087f5a61 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 0d8ad6108b061f7b3c39e3ab5ff08841d0dd2733 
   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 77cd8abffca6bf20d753abe35ee212a7cf53668b 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 1757ee3ba3b7f6fe18130294ed4f849bb0552e15 
   
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
 a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 cc206314d93ea7b160df7f809d072f90e23cc4b3 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 65565f1bb14dd4c6425f67f27ea06566d57b65cf 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
  PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
 57095cea18936fb2ddf92bce587aea58e81996c8 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
  22a40481b5b246989c2e17a72a0325649382dde1 
 
 Diff: https://reviews.apache.org/r/23107/diff/
 
 
 Testing
 ---
 
 ./gradlew build -Pq
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-01 Thread Bill Farner


 On June 27, 2014, 11:56 p.m., Kevin Sweeney wrote:
  How would you feel about taking this opportunity to move the framework ID 
  to a command-line flag instead. This has always been a scary thing - you 
  almost always want a set, immutable framework ID generated when you 
  initially provision a cluster. keeping it in a mutable place like the db 
  seems like a potentially bad gotcha. This is a good sanity check for backup 
  recovery too - if the framework id doesn't match the one in the backup, we 
  can give a sane error message rather than blindly attempting to port 
  another cluster's tasks.

I'm happy to file a ticket, but i'm weary of a tangent.  As we discussed, that 
would also involve some kind of tool to initialize the cluster, which i'd like 
to keep out of scope of the storage work.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review46929
---


On June 27, 2014, 5:42 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23107/
 ---
 
 (Updated June 27, 2014, 5:42 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Bugs: AURORA-555
 https://issues.apache.org/jira/browse/AURORA-555
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Database-backed implementation of SchedulerStore.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 48b4404590d393cda393b8cc7bc0619934a75223 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 e23506b7a3546c896f3095c80e3a20a97bee77d3 
   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 0e7f52c83fb450f631751a635fd4d85fc61e3bab 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 1738b95cd67cf990bd8aad8c744a1febe2d87f15 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 c683e398640c7ebf2047ef308a701cb4897c58dc 
   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 505c94d6800c1453b1b1f696ef774f5943973f19 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 083e3ffa9add639666c2a3bcad478678886c643f 
   
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
 a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 65750b61b864f0e830513039a7c9d727ac9d493d 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 23555c2483d7fe716243847f8478898e98fb5ac4 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
  PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
 57095cea18936fb2ddf92bce587aea58e81996c8 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
  22a40481b5b246989c2e17a72a0325649382dde1 
 
 Diff: https://reviews.apache.org/r/23107/diff/
 
 
 Testing
 ---
 
 ./gradlew build -Pq
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-01 Thread Bill Farner


 On June 27, 2014, 3:10 p.m., Maxim Khutornenko wrote:
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines 
  17-20
  https://reviews.apache.org/r/23107/diff/1/?file=619305#file619305line17
 
  Add UNIQUE constraint just to be defensive from the schema standpoint?

Good call, done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review46863
---


On June 27, 2014, 5:42 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23107/
 ---
 
 (Updated June 27, 2014, 5:42 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Bugs: AURORA-555
 https://issues.apache.org/jira/browse/AURORA-555
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Database-backed implementation of SchedulerStore.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 48b4404590d393cda393b8cc7bc0619934a75223 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 e23506b7a3546c896f3095c80e3a20a97bee77d3 
   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 0e7f52c83fb450f631751a635fd4d85fc61e3bab 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 1738b95cd67cf990bd8aad8c744a1febe2d87f15 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 c683e398640c7ebf2047ef308a701cb4897c58dc 
   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 505c94d6800c1453b1b1f696ef774f5943973f19 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 083e3ffa9add639666c2a3bcad478678886c643f 
   
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
 a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 65750b61b864f0e830513039a7c9d727ac9d493d 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 23555c2483d7fe716243847f8478898e98fb5ac4 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
  PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
 57095cea18936fb2ddf92bce587aea58e81996c8 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
  22a40481b5b246989c2e17a72a0325649382dde1 
 
 Diff: https://reviews.apache.org/r/23107/diff/
 
 
 Testing
 ---
 
 ./gradlew build -Pq
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-01 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/
---

(Updated July 2, 2014, 1:33 a.m.)


Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-555
https://issues.apache.org/jira/browse/AURORA-555


Repository: aurora


Description
---

Database-backed implementation of SchedulerStore.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
b4139eb5a6a9a281f7d2beaf04f7209b7c221980 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
94f03f0d66291bbf919aea9f5149e49f8b4c38da 
  src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
f5ed139610382a0a9aa057ed0ae33576201d6767 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
348527997ea89fd71952a9f1ec0c67c3087f5a61 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
0d8ad6108b061f7b3c39e3ab5ff08841d0dd2733 
  src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
77cd8abffca6bf20d753abe35ee212a7cf53668b 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
1757ee3ba3b7f6fe18130294ed4f849bb0552e15 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
cc206314d93ea7b160df7f809d072f90e23cc4b3 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
65565f1bb14dd4c6425f67f27ea06566d57b65cf 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
3298eb38644b6fa7096801a69f8b88d0331ce4a7 
  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
57095cea18936fb2ddf92bce587aea58e81996c8 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 22a40481b5b246989c2e17a72a0325649382dde1 

Diff: https://reviews.apache.org/r/23107/diff/


Testing
---

./gradlew build -Pq


Thanks,

Bill Farner



Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-06-27 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review46929
---


How would you feel about taking this opportunity to move the framework ID to a 
command-line flag instead. This has always been a scary thing - you almost 
always want a set, immutable framework ID generated when you initially 
provision a cluster. keeping it in a mutable place like the db seems like a 
potentially bad gotcha. This is a good sanity check for backup recovery too - 
if the framework id doesn't match the one in the backup, we can give a sane 
error message rather than blindly attempting to port another cluster's tasks. 

- Kevin Sweeney


On June 26, 2014, 10:42 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23107/
 ---
 
 (Updated June 26, 2014, 10:42 p.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Bugs: AURORA-555
 https://issues.apache.org/jira/browse/AURORA-555
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Database-backed implementation of SchedulerStore.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 48b4404590d393cda393b8cc7bc0619934a75223 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 e23506b7a3546c896f3095c80e3a20a97bee77d3 
   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 0e7f52c83fb450f631751a635fd4d85fc61e3bab 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 1738b95cd67cf990bd8aad8c744a1febe2d87f15 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 c683e398640c7ebf2047ef308a701cb4897c58dc 
   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 505c94d6800c1453b1b1f696ef774f5943973f19 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 083e3ffa9add639666c2a3bcad478678886c643f 
   
 src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
 a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 65750b61b864f0e830513039a7c9d727ac9d493d 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 23555c2483d7fe716243847f8478898e98fb5ac4 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
  PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
 57095cea18936fb2ddf92bce587aea58e81996c8 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
  PRE-CREATION 
   
 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
  22a40481b5b246989c2e17a72a0325649382dde1 
 
 Diff: https://reviews.apache.org/r/23107/diff/
 
 
 Testing
 ---
 
 ./gradlew build -Pq
 
 
 Thanks,
 
 Bill Farner
 




Review Request 23107: Database-backed implementation of SchedulerStore.

2014-06-26 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/
---

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-555
https://issues.apache.org/jira/browse/AURORA-555


Repository: aurora


Description
---

Database-backed implementation of SchedulerStore.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
48b4404590d393cda393b8cc7bc0619934a75223 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
e23506b7a3546c896f3095c80e3a20a97bee77d3 
  src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
0e7f52c83fb450f631751a635fd4d85fc61e3bab 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
1738b95cd67cf990bd8aad8c744a1febe2d87f15 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
c683e398640c7ebf2047ef308a701cb4897c58dc 
  src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
505c94d6800c1453b1b1f696ef774f5943973f19 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
083e3ffa9add639666c2a3bcad478678886c643f 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
65750b61b864f0e830513039a7c9d727ac9d493d 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
23555c2483d7fe716243847f8478898e98fb5ac4 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
3298eb38644b6fa7096801a69f8b88d0331ce4a7 
  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
57095cea18936fb2ddf92bce587aea58e81996c8 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 22a40481b5b246989c2e17a72a0325649382dde1 

Diff: https://reviews.apache.org/r/23107/diff/


Testing
---

./gradlew build -Pq


Thanks,

Bill Farner