Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49286
---

Ship it!


thanks!

- Joe Smith


On July 31, 2014, 1:24 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 31, 2014, 1:24 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/
---

(Updated July 31, 2014, 8:24 p.m.)


Review request for Aurora, Joe Smith and Mark Chu-Carroll.


Changes
---

CR comments.


Bugs: AURORA-609
https://issues.apache.org/jira/browse/AURORA-609


Repository: aurora


Description
---

Blocking on post drain script call.


Diffs (updated)
-

  src/main/python/apache/aurora/admin/admin_util.py 
04eecb7246f02191cd9308c747151e58b203b885 
  src/test/python/apache/aurora/admin/BUILD 
20f744b4133ec665e476c00ff46d6b3f8e3add71 
  src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 

Diff: https://reviews.apache.org/r/24019/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49285
---

Ship it!


One last thing (setting the spec) then LGTM.


src/test/python/apache/aurora/admin/test_admin_util.py


import subprocess



src/test/python/apache/aurora/admin/test_admin_util.py


...subprocess", spec=subprocess)


- Joe Smith


On July 31, 2014, 1:16 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 31, 2014, 1:16 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Maxim Khutornenko 


> On July 31, 2014, 8:06 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/admin/test_admin_util.py, line 17
> > 
> >
> > did we change our import order?
> > 
> > wasn't it
> > 
> > stdlib
> > current-projects-namespace
> > 3rdparty
> > ?

That's what isort-run does. So, I guess yes :)


> On July 31, 2014, 8:06 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/admin/test_admin_util.py, line 36
> > 
> >
> > self.assertRaises[1]
> > 
> > [1] 
> > https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises

Good to know. Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49283
---


On July 29, 2014, 1:04 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 29, 2014, 1:04 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/
---

(Updated July 31, 2014, 8:16 p.m.)


Review request for Aurora, Joe Smith and Mark Chu-Carroll.


Changes
---

CR comments.


Bugs: AURORA-609
https://issues.apache.org/jira/browse/AURORA-609


Repository: aurora


Description
---

Blocking on post drain script call.


Diffs (updated)
-

  src/main/python/apache/aurora/admin/admin_util.py 
04eecb7246f02191cd9308c747151e58b203b885 
  src/test/python/apache/aurora/admin/BUILD 
20f744b4133ec665e476c00ff46d6b3f8e3add71 
  src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 

Diff: https://reviews.apache.org/r/24019/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49283
---



src/test/python/apache/aurora/admin/test_admin_util.py


did we change our import order?

wasn't it

stdlib
current-projects-namespace
3rdparty
?



src/test/python/apache/aurora/admin/test_admin_util.py


def test_parse_script



src/test/python/apache/aurora/admin/test_admin_util.py


def test_parse_script_invalid_filename



src/test/python/apache/aurora/admin/test_admin_util.py


self.assertRaises[1]

[1] 
https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises


- Joe Smith


On July 28, 2014, 6:04 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 28, 2014, 6:04 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49260
---

Ship it!


Ship It!

- Mark Chu-Carroll


On July 28, 2014, 9:04 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 28, 2014, 9:04 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49246
---


Ping Mark, Joe.

- Maxim Khutornenko


On July 29, 2014, 1:04 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 29, 2014, 1:04 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/
---

(Updated July 29, 2014, 1:04 a.m.)


Review request for Aurora, Joe Smith and Mark Chu-Carroll.


Changes
---

CR comments.


Bugs: AURORA-609
https://issues.apache.org/jira/browse/AURORA-609


Repository: aurora


Description
---

Blocking on post drain script call.


Diffs (updated)
-

  src/main/python/apache/aurora/admin/admin_util.py 
04eecb7246f02191cd9308c747151e58b203b885 
  src/test/python/apache/aurora/admin/BUILD 
20f744b4133ec665e476c00ff46d6b3f8e3add71 
  src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 

Diff: https://reviews.apache.org/r/24019/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Maxim Khutornenko 


> On July 28, 2014, 11:49 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 144
> > 
> >
> > giving this function a name turns this into a 3-liner but makes a much 
> > more readable stack trace

Fine with me.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review48939
---


On July 29, 2014, 1:04 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 29, 2014, 1:04 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review48939
---



src/main/python/apache/aurora/admin/admin_util.py


giving this function a name turns this into a 3-liner but makes a much more 
readable stack trace


- Kevin Sweeney


On July 28, 2014, 4:46 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> ---
> 
> (Updated July 28, 2014, 4:46 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
> https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/
---

Review request for Aurora, Joe Smith and Mark Chu-Carroll.


Bugs: AURORA-609
https://issues.apache.org/jira/browse/AURORA-609


Repository: aurora


Description
---

Blocking on post drain script call.


Diffs
-

  src/main/python/apache/aurora/admin/admin_util.py 
04eecb7246f02191cd9308c747151e58b203b885 
  src/test/python/apache/aurora/admin/BUILD 
20f744b4133ec665e476c00ff46d6b3f8e3add71 
  src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 

Diff: https://reviews.apache.org/r/24019/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko