Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-09-29 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review54896
---


Discarding this since Gradle 2.1 uses HTTPS

- Kevin Sweeney


On July 29, 2014, 12:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 12:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Kevin Sweeney 


> On July 29, 2014, 6:55 p.m., Jake Farrell wrote:
> > +0, I dont really think that this is necessary and will add overhead 
> > (especially with AURORA-616), thoughts on opening this up on the dev@ list 
> > to a wider discussion?
> 
> Bill Farner wrote:
> +1 to hashing this out in a dev@ discussion.  I've had a nervous twitch 
> about traditional maven-style dependencies for a long time, and i'd love to 
> know if i'm just wearing a tinfoil hat :-)
> 
> Tobias Weingartner wrote:
> +1 to moving in this direction.  -1 on the "will add overhead" part.  
> SSL/HTTPS does adds any negligible overhead at best:
> 
> https://www.imperialviolet.org/2010/06/25/overclocking-ssl.html
> 
>
> 
> Jake Farrell wrote:
> the overhead i was refering to was not for ssl/https interaction but the 
> project overhead of managing/verifying all packages used are available at 
> jcenter

That's been verified in the Testing Done section (deleted all cached 
dependencies and verified that the build still works).


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49076
---


On July 29, 2014, 12:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 12:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Jake Farrell 


> On July 30, 2014, 1:55 a.m., Jake Farrell wrote:
> > +0, I dont really think that this is necessary and will add overhead 
> > (especially with AURORA-616), thoughts on opening this up on the dev@ list 
> > to a wider discussion?
> 
> Bill Farner wrote:
> +1 to hashing this out in a dev@ discussion.  I've had a nervous twitch 
> about traditional maven-style dependencies for a long time, and i'd love to 
> know if i'm just wearing a tinfoil hat :-)
> 
> Tobias Weingartner wrote:
> +1 to moving in this direction.  -1 on the "will add overhead" part.  
> SSL/HTTPS does adds any negligible overhead at best:
> 
> https://www.imperialviolet.org/2010/06/25/overclocking-ssl.html
> 
>

the overhead i was refering to was not for ssl/https interaction but the 
project overhead of managing/verifying all packages used are available at 
jcenter


- Jake


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49076
---


On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 7:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49114
---

Ship it!


Ship It!

- Mark Chu-Carroll


On July 29, 2014, 3:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 3:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Tobias Weingartner 


> On July 30, 2014, 1:55 a.m., Jake Farrell wrote:
> > +0, I dont really think that this is necessary and will add overhead 
> > (especially with AURORA-616), thoughts on opening this up on the dev@ list 
> > to a wider discussion?
> 
> Bill Farner wrote:
> +1 to hashing this out in a dev@ discussion.  I've had a nervous twitch 
> about traditional maven-style dependencies for a long time, and i'd love to 
> know if i'm just wearing a tinfoil hat :-)

+1 to moving in this direction.  -1 on the "will add overhead" part.  SSL/HTTPS 
does adds any negligible overhead at best:

https://www.imperialviolet.org/2010/06/25/overclocking-ssl.html


- Tobias


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49076
---


On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 7:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Bill Farner 


> On July 30, 2014, 1:55 a.m., Jake Farrell wrote:
> > +0, I dont really think that this is necessary and will add overhead 
> > (especially with AURORA-616), thoughts on opening this up on the dev@ list 
> > to a wider discussion?

+1 to hashing this out in a dev@ discussion.  I've had a nervous twitch about 
traditional maven-style dependencies for a long time, and i'd love to know if 
i'm just wearing a tinfoil hat :-)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49076
---


On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 7:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Jake Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49076
---


+0, I dont really think that this is necessary and will add overhead 
(especially with AURORA-616), thoughts on opening this up on the dev@ list to a 
wider discussion? 

- Jake Farrell


On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 7:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49015
---

Ship it!


Ship It!

- Bill Farner


On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 7:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/#review49014
---



build.gradle


This is per https://twitter.com/bintray/status/494185158493224961


- Kevin Sweeney


On July 29, 2014, 12:14 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24063/
> ---
> 
> (Updated July 29, 2014, 12:14 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-620
> https://issues.apache.org/jira/browse/AURORA-620
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use JCenter over HTTPS instead of Maven Central
> 
> 
> Diffs
> -
> 
>   build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
> 
> Diff: https://reviews.apache.org/r/24063/diff/
> 
> 
> Testing
> ---
> 
> rm -fr ~/.gradle/caches
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24063/
---

Review request for Aurora, Jake Farrell and Bill Farner.


Bugs: AURORA-620
https://issues.apache.org/jira/browse/AURORA-620


Repository: aurora


Description
---

Use JCenter over HTTPS instead of Maven Central


Diffs
-

  build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 

Diff: https://reviews.apache.org/r/24063/diff/


Testing
---

rm -fr ~/.gradle/caches
./gradlew build


Thanks,

Kevin Sweeney