[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 4: Code-Review+2 Carrying +2. -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 04 Sep 2018 20:17:26 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path Currently, the diagnostics script expects a full path to the actual directory to which process minidumps are written. This is however incosistent with Impala's configuration --minidump_path. Impala creates a subdirectory under FLAGS_minidump_path (for ex: /impalad) to which it writes the minidumps. This commit fixes the diagnostic script input --minidump_dir to be consistent with the above behavior from Impala. It now looks for minidumps under the directory <--minidump_path>/ The users of this script are expected to fix their input args accordingly. Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Reviewed-on: http://gerrit.cloudera.org:8080/11353 Tested-by: Impala Public Jenkins Reviewed-by: Bharath Vissapragada --- M bin/diagnostics/collect_diagnostics.py 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Bharath Vissapragada: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 04 Sep 2018 03:03:01 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3108/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 03 Sep 2018 23:41:41 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/11353 )
Change subject: [diagnostics] Make --minidump_dir consistent with Impala's
--minidump_path
..
Patch Set 3:
After digging through the 300MB clang tidy log file, the error appears to be
this.
[WARNING] Could not transfer metadata
com.cloudera.cdh:cdh-root:6.x-SNAPSHOT/maven-metadata.xml from/to
${distMgmtSnapshotsId} (${distMgmtSnapshotsUrl}): Cannot access
${distMgmtSnapshotsUrl} with type default using the available connector
factories: BasicRepositoryConnectorFactory
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed
with message:
[INFO] BUILD FAILURE
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
(enforce-banned-dependencies) on project impala-frontend: Some Enforcer rules
have failed. Look above for specific messages explaining why the rule failed.
-> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
mvn -B install -DskipTests exited with code 0
Clearly it is not related to the patch, however I ran into it twice [1,2]. Also
looks like I'm not alone. I could see other builds running into this [3].
Fredy, I see you added this dependency, does this ring a bell?
[1] https://jenkins.impala.io/job/clang-tidy-ub1604/2939/
[2] https://jenkins.impala.io/job/clang-tidy-ub1604/2976/
[3] https://jenkins.impala.io/job/clang-tidy-ub1604/2959/
--
To view, visit http://gerrit.cloudera.org:8080/11353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381
Gerrit-Change-Number: 11353
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Sat, 01 Sep 2018 06:14:17 +
Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3103/ -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 31 Aug 2018 22:27:01 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 3: Weird. clang-tidy build failed with this patch that does not change any backend code. I'm attempting another run while I'm debugging its output. Still no clue what went wrong. -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 31 Aug 2018 18:55:18 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 31 Aug 2018 18:54:16 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3103/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 31 Aug 2018 18:54:17 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3094/ -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 30 Aug 2018 02:17:15 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/528/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 29 Aug 2018 23:06:38 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3094/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 29 Aug 2018 22:42:35 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 29 Aug 2018 22:42:34 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11353 ) Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 29 Aug 2018 22:36:46 + Gerrit-HasComments: No
[Impala-ASF-CR] [diagnostics] Make --minidump dir consistent with Impala's --minidump path
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11353 Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path .. [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path Currently, the diagnostics script expects a full path to the actual directory to which process minidumps are written. This is however incosistent with Impala's configuration --minidump_path. Impala creates a subdirectory under FLAGS_minidump_path (for ex: /impalad) to which it writes the minidumps. This commit fixes the diagnostic script input --minidump_dir to be consistent with the above behavior from Impala. It now looks for minidumps under the directory <--minidump_path>/ The users of this script are expected to fix their input args accordingly. Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 --- M bin/diagnostics/collect_diagnostics.py 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/11353/1 -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada
