[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-15 Thread Joe McDonnell (Code Review) 
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13330 )

Change subject: Enable data cache by default for all S3 builds
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh@64
PS2, Line 64: /tmp
Do we know if the choice of filesystem matters for the cache? For example, /tmp 
might be on tmpfs. Does it matter?


http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh@78
PS2, Line 78: ${TARGET_FILESYSTEM}" == "s3"
I think the data caching is orthogonal to the filesystem, and we might want to 
test with the filesystem as HDFS (e.g. on containers). So, maybe have an 
DATA_CACHE_ENABLED flag that when true enables the cache. Then, the 
customizable things would the directory and size. For automated tests, this can 
be passed in as part of the test configuration.



--
To view, visit http://gerrit.cloudera.org:8080/13330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
Gerrit-Change-Number: 13330
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Wed, 15 May 2019 23:34:56 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13330 )

Change subject: Enable data cache by default for all S3 builds
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3220/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
Gerrit-Change-Number: 13330
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Tue, 14 May 2019 18:34:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-14 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13330 )

Change subject: Enable data cache by default for all S3 builds
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3218/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
Gerrit-Change-Number: 13330
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Tue, 14 May 2019 18:17:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-14 Thread Michael Ho (Code Review) 
Hello Joe McDonnell, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13330

to look at the new patch set (#2).

Change subject: Enable data cache by default for all S3 builds
..

Enable data cache by default for all S3 builds

Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
---
M bin/run-all-tests.sh
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/13330/2
--
To view, visit http://gerrit.cloudera.org:8080/13330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
Gerrit-Change-Number: 13330
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-14 Thread Michael Ho (Code Review) 
Michael Ho has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13330


Change subject: Enable data cache by default for all S3 builds
..

Enable data cache by default for all S3 builds

Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
---
M bin/run-all-tests.sh
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/13330/1
--
To view, visit http://gerrit.cloudera.org:8080/13330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b
Gerrit-Change-Number: 13330
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho