[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 6 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 24 Sep 2020 00:45:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ This data race can be reproduced by TestCompactCatalogUpdates.test_restart_catalogd, although it does not seem to always occur. The data race was originally reported in a Jenkins job, but I could not reproduce it locally. The fix is to acquire a read lock while reading some UrlHandler objects. I cleaned up some of the other involved variables and made them const. These variables are set during construction time, and never modified afterwards. Testing: * Ran be and custom cluster TSAN tests Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Reviewed-on: http://gerrit.cloudera.org:8080/16459 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/util/webserver.cc M be/src/util/webserver.h 2 files changed, 15 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 7 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6468/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 6 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 23 Sep 2020 19:03:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 6 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 23 Sep 2020 19:03:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 6: I'm not really sure what happened in the last run. Seeing some weird errors in the impalad logs, but not clear indication of why the processes crashed. Re-running to see if it reproduces. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 6 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 23 Sep 2020 19:04:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6462/ -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 22 Sep 2020 21:46:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 22 Sep 2020 16:30:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6462/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 22 Sep 2020 16:30:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 22 Sep 2020 03:42:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 4: Code-Review+1 Looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 21 Sep 2020 19:45:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7224/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 21 Sep 2020 19:05:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16459 to look at the new patch set (#4). Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ This data race can be reproduced by TestCompactCatalogUpdates.test_restart_catalogd, although it does not seem to always occur. The data race was originally reported in a Jenkins job, but I could not reproduce it locally. The fix is to acquire a read lock while reading some UrlHandler objects. I cleaned up some of the other involved variables and made them const. These variables are set during construction time, and never modified afterwards. Testing: * Ran be and custom cluster TSAN tests Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a --- M be/src/util/webserver.cc M be/src/util/webserver.h 2 files changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16459/4 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16459/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16459/2/be/src/util/webserver.cc@526 PS2, Line 526: shared_lock lock(url_handlers_lock_); > It's better to add brackets around line 526 to 538 so that the lock will be Done -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 21 Sep 2020 18:44:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16459/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16459/2/be/src/util/webserver.cc@526 PS2, Line 526: shared_lock lock(url_handlers_lock_); It's better to add brackets around line 526 to 538 so that the lock will be released before calling obj.AddMember(). -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 21 Sep 2020 16:47:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7220/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 21 Sep 2020 16:39:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16459 to look at the new patch set (#2). Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ This data race can be reproduced by TestCompactCatalogUpdates.test_restart_catalogd, although it does not seem to always occur. The data race was originally reported in a Jenkins job, but I could not reproduce it locally. The fix is to acquire a read lock while reading some UrlHandler objects. I cleaned up some of the other involved variables and made them const. These variables are set during construction time, and never modified afterwards. Testing: * Ran be and custom cluster TSAN tests Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a --- M be/src/util/webserver.cc M be/src/util/webserver.h 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16459/2 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16459/1/be/src/util/webserver.h File be/src/util/webserver.h: http://gerrit.cloudera.org:8080/#/c/16459/1/be/src/util/webserver.h@160 PS1, Line 160: const bool is_on_nav_bar_; > It seems that we need to acquire url_handlers_lock_ in Webserver::GetCommon yeah good catch, it looks like GetCommonJson doesn't acquire the lock. will fix. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 17 Sep 2020 16:24:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16459/1/be/src/util/webserver.h File be/src/util/webserver.h: http://gerrit.cloudera.org:8080/#/c/16459/1/be/src/util/webserver.h@160 PS1, Line 160: const bool is_on_nav_bar_; It seems that we need to acquire url_handlers_lock_ in Webserver::GetCommonJson() when accessing url_handlers_. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 16 Sep 2020 16:59:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7188/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 16 Sep 2020 15:24:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16459 Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ This data race can be reproduced by TestCompactCatalogUpdates.test_restart_catalogd, although it does not seem to always occur. The data race was originally reported in a Jenkins job, but I could not reproduce it locally. The fix is to mark a few variables in Webserver::UrlHandler as const. These variables are set during construction time, and never modified afterwards. Testing: * Ran be and custom cluster TSAN tests Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a --- M be/src/util/webserver.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16459/1 -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar
