[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 Impala run over ARM machine shows 'arch_sys_counter' clock source being used rather than more precise 'tsc'. This cause MonotonicStopwatch::Now() to use 'CLOCK_MONOTONIC_COARSE' rather than 'CLOCK_MONOTONIC'. This is what printed near the beginning of impalad log: I0506 13:49:15.429359 355337 init.cc:600] OS distribution: Red Hat Enterprise Linux 8.8 (Ootpa) OS version: Linux version 4.18.0-477.15.1.el8_8.aarch64 ... Clock: clocksource: 'arch_sys_counter', clockid_t: CLOCK_MONOTONIC_COARSE This difference in clock source causes test failure in test_runtime_filters.py::TestRuntimeFilters::test_basic_filters. This patch fixes the issue by initializing first_arrival_time_ and completion_time_ fields of Coordinator::FilterState with -1 and accept 0 as valid value for those fields. query_events_ initialization and start are also moved to the beginning of ClientRequestState's contructor. Testing: - Tweak row_regex pattern in runtime_filters.test. - Loop and pass test_runtime_filters.py in exhaustive mode 3 times in ARM machine. Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Reviewed-on: http://gerrit.cloudera.org:8080/21405 Reviewed-by: Wenzhe Zhou Tested-by: Impala Public Jenkins --- M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test 4 files changed, 21 insertions(+), 18 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 09:46:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 04:39:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10617/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 04:43:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16127/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 04:30:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21405/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21405/4/be/src/service/client-request-state.cc@123 PS4, Line 123: profile_->AddChild(summary_profile_); > I'd like to revert this back to query_events_->Start(), since it already mo Done. This change still pass test_basic_filters in ARM. -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 04:07:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21405 to look at the new patch set (#5). Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 Impala run over ARM machine shows 'arch_sys_counter' clock source being used rather than more precise 'tsc'. This cause MonotonicStopwatch::Now() to use 'CLOCK_MONOTONIC_COARSE' rather than 'CLOCK_MONOTONIC'. This is what printed near the beginning of impalad log: I0506 13:49:15.429359 355337 init.cc:600] OS distribution: Red Hat Enterprise Linux 8.8 (Ootpa) OS version: Linux version 4.18.0-477.15.1.el8_8.aarch64 ... Clock: clocksource: 'arch_sys_counter', clockid_t: CLOCK_MONOTONIC_COARSE This difference in clock source causes test failure in test_runtime_filters.py::TestRuntimeFilters::test_basic_filters. This patch fixes the issue by initializing first_arrival_time_ and completion_time_ fields of Coordinator::FilterState with -1 and accept 0 as valid value for those fields. query_events_ initialization and start are also moved to the beginning of ClientRequestState's contructor. Testing: - Tweak row_regex pattern in runtime_filters.test. - Loop and pass test_runtime_filters.py in exhaustive mode 3 times in ARM machine. Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 --- M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test 4 files changed, 21 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/21405/5 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 4: (1 comment) > Patch Set 4: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10615/ ubuntu-20.04-from-scratch job fail doing apt-get install 15:54:13 + sudo apt-get --yes install git 15:54:13 E: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 2804 (apt-get) 15:54:13 E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it? http://gerrit.cloudera.org:8080/#/c/21405/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21405/4/be/src/service/client-request-state.cc@123 PS4, Line 123: query_events_->Start(query_events_start_time); I'd like to revert this back to query_events_->Start(), since it already moved to beginning of constructor and calling MonotonicStopWatch::Now() twice feels overkill. -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 04:04:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10615/ -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Wed, 08 May 2024 03:58:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 22:49:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10615/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 22:53:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 22:53:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@19 PS2, Line 19: cause > nit: causes Done http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@21 PS2, Line 21: fix > nit: fixes Done http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@22 PS2, Line 22: wi > nit: are Removed. http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@25 PS2, Line 25: ar > nit: are Done -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 22:42:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21405 to look at the new patch set (#3). Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 Impala run over ARM machine shows 'arch_sys_counter' clock source being used rather than more precise 'tsc'. This cause MonotonicStopwatch::Now() to use 'CLOCK_MONOTONIC_COARSE' rather than 'CLOCK_MONOTONIC'. This is what printed near the beginning of impalad log: I0506 13:49:15.429359 355337 init.cc:600] OS distribution: Red Hat Enterprise Linux 8.8 (Ootpa) OS version: Linux version 4.18.0-477.15.1.el8_8.aarch64 ... Clock: clocksource: 'arch_sys_counter', clockid_t: CLOCK_MONOTONIC_COARSE This difference in clock source causes test failure in test_runtime_filters.py::TestRuntimeFilters::test_basic_filters. This patch fixes the issue by initializing first_arrival_time_ and completion_time_ fields of Coordinator::FilterState with -1 and accept 0 as valid value for those fields. query_events_ initialization and start are also moved to the beginning of ClientRequestState's contructor. Testing: - Tweak row_regex pattern in runtime_filters.test. - Loop and pass test_runtime_filters.py in exhaustive mode 3 times in ARM machine. Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 --- M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test 4 files changed, 22 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/21405/3 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16125/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 22:38:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 2: Code-Review+1 (4 comments) Thanks to fix this issue. http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@19 PS2, Line 19: cause nit: causes http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@21 PS2, Line 21: fix nit: fixes http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@22 PS2, Line 22: is nit: are http://gerrit.cloudera.org:8080/#/c/21405/2//COMMIT_MSG@25 PS2, Line 25: is nit: are -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 22:34:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21405 to look at the new patch set (#2). Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 Impala run over ARM machine shows 'arch_sys_counter' clock source being used rather than more precise 'tsc'. This cause MonotonicStopwatch::Now() to use 'CLOCK_MONOTONIC_COARSE' rather than 'CLOCK_MONOTONIC'. This is what printed near the beginning of impalad log: I0506 13:49:15.429359 355337 init.cc:600] OS distribution: Red Hat Enterprise Linux 8.8 (Ootpa) OS version: Linux version 4.18.0-477.15.1.el8_8.aarch64 ... Clock: clocksource: 'arch_sys_counter', clockid_t: CLOCK_MONOTONIC_COARSE This difference in clock source cause test failure in test_runtime_filters.py::TestRuntimeFilters::test_basic_filters. This patch fix the issue by initializing first_arrival_time_ and completion_time_ fields of Coordinator::FilterState is with -1 and accept 0 as valid value for those fields. query_events_ initialization and start is also moved to the beginning of ClientRequestState's contructor. Testing: - Tweak row_regex pattern in runtime_filters.test. - Loop and pass test_runtime_filters.py in exhaustive mode 3 times in ARM machine. Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 --- M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc M be/src/service/client-request-state.cc M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test 4 files changed, 22 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/21405/2 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 1: | Maybe a better solution is to Start query_events_ at start_time_us() It's better to keep consistent. Could we run exhaustive test on ARM to verify the fixing? -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 20:02:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 1: > Patch Set 1: > > This patch only help bypassing the flaky test, but does not address the > underlying issue with RuntimeProfile::EventSequence::Start() from: > > be/src/service/client-request-state.cc:140: query_events_->Start(); > Maybe a better solution is to Start query_events_ at start_time_us() query_events_->Start(start_time_us() * 1000); -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 17:25:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16114/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 16:26:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21405 ) Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. Patch Set 1: This patch only help bypassing the flaky test, but does not address the underlying issue with RuntimeProfile::EventSequence::Start() from: be/src/service/client-request-state.cc:140: query_events_->Start(); https://issues.apache.org/jira/browse/IMPALA-13058?focusedCommentId=17844060=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17844060 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 07 May 2024 16:05:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13058: Init first arrival time and completion time with -1
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21405 Change subject: IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 .. IMPALA-13058: Init first_arrival_time_ and completion_time_ with -1 Before this patch, first_arrival_time_ and completion_time_ of Coordinator::FilterState is initialized with 0. This patch change the initialization value to -1 and accept 0 as valid value for those fields. Testing: - Tweak row_regex pattern in runtime_filters.test. - Pass test_runtime_filters.py in exhaustive mode. Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 --- M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.cc M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test 3 files changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/21405/1 -- To view, visit http://gerrit.cloudera.org:8080/21405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1176e2118bb03414ab35049f50009ff0e8c63f58 Gerrit-Change-Number: 21405 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto
