[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-07-24 Thread anujphadke (Code Review) 
anujphadke has abandoned this change. ( http://gerrit.cloudera.org:8080/9619 )

Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..


Abandoned

This is not the right fix. Will send a new patch.
The problem is that we don't wait for the restarted process anywhere
When a process is killed, it will become zombile until its parent waits for it
When you restart using start-impala-cluster.py, it doesn't have this problem, 
because the parent process is start-impala-cluster.py, which immediately exits 
after the cluster starts.
--
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: anujphadke

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread anujphadke (Code Review) 
anujphadke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9619 )

Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py@80
PS1, Line 80: IMPALA_HOME = os.environ['IMPALA_HOME']
: IMPALAD_PATH = os.path.join(IMPALA_HOME,
:'bin/start-impalad.sh --server_name=server1')
> The issue is that impalad.restart() remains broken.  I think the proper fix
Thanks Adam and Freddy!
I agree. I looked into it and the issue does not happen if you just set 
shell=True in the popen in exec_process_async.
I am still digging up the code to root cause why this works. I will post my 
updates soon.



--
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Fri, 16 Mar 2018 02:24:18 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread Adam Holley (Code Review) 
Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9619 )

Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py@80
PS1, Line 80: IMPALA_HOME = os.environ['IMPALA_HOME']
: IMPALAD_PATH = os.path.join(IMPALA_HOME,
:'bin/start-impalad.sh --server_name=server1')
> The restart method in impala_cluster.py seems to be extracting this path fr
The issue is that impalad.restart() remains broken.  I think the proper fix is 
to modify the Process class in tests/common/impala_cluster.py to get and store 
the environment variables used for the process, and then update 
exec_process_async so that is can accept environment variables used in Popen.  
That way, any process we restart should have the same environment as opposed to 
just going off of the command line.



--
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Fri, 16 Mar 2018 02:10:03 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9619 )

Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py@82
PS1, Line 82:'bin/start-impalad.sh --server_name=server1')
I think using os.path.join(IMPALA_PATH, 'bin', 'script-impalad.sh 
--server_name=server1') is better.



--
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Thu, 15 Mar 2018 18:56:15 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-14 Thread anujphadke (Code Review) 
anujphadke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9619 )

Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:

http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py@80
PS1, Line 80: IMPALA_HOME = os.environ['IMPALA_HOME']
: IMPALAD_PATH = os.path.join(IMPALA_HOME,
:'bin/start-impalad.sh --server_name=server1')
> Could we get this data from /proc//environ as part of refresh?
The restart method in impala_cluster.py seems to be extracting this path from 
psutil.Process. The issue in doing this is it wont set the classpath correctly 
and impalad will exit out failing to find JNI.

The restart method defined in Process seems to be more generic. It uses cmdline 
to start the process. So I didn't want to hardcode this script path there.



--
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: anujphadke 
Gerrit-Comment-Date: Wed, 14 Mar 2018 22:41:46 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-13 Thread Adam Holley (Code Review) 
Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9619 )

Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..


Patch Set 1:

If the .restart() method is broken, shouldn't the fix go in that method so 
other tests that use that method will be fixed as well?


--
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Adam Holley 
Gerrit-Comment-Date: Wed, 14 Mar 2018 05:36:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-13 Thread anujphadke (Code Review) 
anujphadke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9619


Change subject: IMPALA-5695: restart_first_impalad() does not start impalad
..

IMPALA-5695: restart_first_impalad() does not start impalad

restart_first_impalad() does not set the correct classpath before
starting impalad. This results in impalad exiting as it fails to
find the JniUtil class. This change invokes the start_impalad.sh
to start impalad.

Testing:
test_role_update consistently fails without this change.

Change-Id: I30a5c25e132deebb9731891364196af31e57d875
---
M tests/authorization/test_grant_revoke.py
1 file changed, 12 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/9619/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875
Gerrit-Change-Number: 9619
Gerrit-PatchSet: 1
Gerrit-Owner: anujphadke