Re: [Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-05 Thread Manaswini Maharana 
Thank you, everyone, for all the support and help. It was an amazing
learning experience. Looking forward to making much more contributions in
future.

Regards!
Mansi

On Fri, Jan 5, 2018 at 3:09 PM, Tim Armstrong (Code Review) <
ger...@cloudera.org> wrote:

> Tim Armstrong *posted comments* on this change.
>
> View Change 
>
> Patch set 6:
>
> Thank you for the contribution
>
>
> To view, visit change 8923 . To
> unsubscribe, visit settings .
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
> Gerrit-Change-Number: 8923
> Gerrit-PatchSet: 6
> Gerrit-Owner: Manaswini Maharana 
> Gerrit-Reviewer: Impala Public Jenkins
> Gerrit-Reviewer: Manaswini Maharana 
> Gerrit-Reviewer: Thomas Tauber-Marshall 
> Gerrit-Reviewer: Tim Armstrong 
> Gerrit-Comment-Date: Fri, 05 Jan 2018 20:09:33 +
> Gerrit-HasComments: No
>

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-05 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..


Patch Set 6:

Thank you for the contribution


--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 6
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 05 Jan 2018 20:09:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 5
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 05 Jan 2018 02:18:04 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..

IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

Currently, when debug mode is enabled, any query using codegen can result
in an Impala daemon crash as it hits a DCHECK.

This patch ensures the DCHECK is hit only when specific condition is met to
avoid the crash. That condition here is to DCHECK only when 'emit_perf_map_'
evaluates to True ensuring 'perf_map_lock_' is not empty when asserted.

Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Reviewed-on: http://gerrit.cloudera.org:8080/8923
Reviewed-by: Tim Armstrong 
Reviewed-by: Thomas Tauber-Marshall 
Tested-by: Impala Public Jenkins
---
M be/src/codegen/codegen-symbol-emitter.cc
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, but someone else must approve
  Thomas Tauber-Marshall: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 6
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Thomas Tauber-Marshall (Code Review) 
Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 5
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 04 Jan 2018 22:30:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1673/


--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 5
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 04 Jan 2018 22:30:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Manaswini Maharana (Code Review) 
Manaswini Maharana has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..


Patch Set 5:

Jenkin tests-
pre-review-test:  https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/879/
gerrit-verify-dryrun-external:  
https://jenkins.impala.io/job/gerrit-verify-dryrun-external/52/


--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 5
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 04 Jan 2018 16:11:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..


Patch Set 5: Code-Review+1

Thank Mansi. I'll let Thomas do the +2


--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 5
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 03 Jan 2018 16:50:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Manaswini Maharana (Code Review) 
Manaswini Maharana has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/8923 )

Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug 
mode
..

IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

Currently, when debug mode is enabled, any query using codegen can result
in an Impala daemon crash as it hits a DCHECK.

This patch ensures the DCHECK is hit only when specific condition is met to
avoid the crash. That condition here is to DCHECK only when 'emit_perf_map_'
evaluates to True ensuring 'perf_map_lock_' is not empty when asserted.

Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
---
M be/src/codegen/codegen-symbol-emitter.cc
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/8923/5
--
To view, visit http://gerrit.cloudera.org:8080/8923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e
Gerrit-Change-Number: 8923
Gerrit-PatchSet: 5
Gerrit-Owner: Manaswini Maharana 
Gerrit-Reviewer: Thomas Tauber-Marshall