[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..

IMPALA-6966: sort table memory by size in catalogd web UI

This patch fix the sorting order in "Top-K Tables with Highest
Memory Requirements" in which "Estimated memory" column is sorted
as strings.

Values got from the catalog-server are changed from pretty-printed
strings to bytes numbers. So the web UI is able to sort and render
them correctly.

Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Reviewed-on: http://gerrit.cloudera.org:8080/10292
Reviewed-by: Dimitris Tsirogiannis 
Tested-by: Impala Public Jenkins 
---
M be/src/catalog/catalog-server.cc
M www/catalog.tmpl
2 files changed, 17 insertions(+), 4 deletions(-)

Approvals:
  Dimitris Tsirogiannis: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Thu, 10 May 2018 22:39:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Thu, 10 May 2018 19:17:11 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2449/


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Thu, 10 May 2018 19:17:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Wed, 09 May 2018 00:08:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 3:

> Hi Dimitris, Philip,
 > Would you trigger gerrit-verify-dryrun test for this (I have no
 > permissions), or are we waiting for other reviews?

Sorry, completely forgot. Done


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Wed, 09 May 2018 00:07:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2428/


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Wed, 09 May 2018 00:07:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-08 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 3:

Hi Dimitris, Philip,
Would you trigger gerrit-verify-dryrun test for this (I have no permissions), 
or are we waiting for other reviews?


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Wed, 09 May 2018 00:03:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-07 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Mon, 07 May 2018 18:42:12 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-05 Thread Quanlong Huang (Code Review) 
Hello Philip Zeyliger, Dimitris Tsirogiannis,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10292

to look at the new patch set (#2).

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..

IMPALA-6966: sort table memory by size in catalogd web UI

This patch fix the sorting order in "Top-K Tables with Highest
Memory Requirements" in which "Estimated memory" column is sorted
as strings.

Values got from the catalog-server are changed from pretty-printed
strings to bytes numbers. So the web UI is able to sort and render
them correctly.

Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
---
M be/src/catalog/catalog-server.cc
M www/catalog.tmpl
2 files changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/10292/2
--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-05 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl@57
PS1, Line 57: var i = parseInt(Math.floor(Math.log(bytes) / 
Math.log(1024)));
> It's unlikely that someone uses this for more than 1024PB, but I think you
Sure. Let me add an 'EB' so it's enough for Long.MAX_VALUE.



--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sat, 05 May 2018 07:27:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-04 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl@57
PS1, Line 57: var i = parseInt(Math.floor(Math.log(bytes) / 
Math.log(1024)));
It's unlikely that someone uses this for more than 1024PB, but I think you need 
to make sure that 0 <= i < units.length.



--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sat, 05 May 2018 04:23:09 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-04 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl@56
PS1, Line 56: <=
> Can we get negative values here?
No. But just add this as a safeguard in case of backend errors (e.g. overflow).



--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 04 May 2018 23:01:03 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-04 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10292 )

Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..


Patch Set 1:

(1 comment)

Thanks!

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl
File www/catalog.tmpl:

http://gerrit.cloudera.org:8080/#/c/10292/1/www/catalog.tmpl@56
PS1, Line 56: <=
Can we get negative values here?



--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Comment-Date: Fri, 04 May 2018 19:06:20 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-03 Thread Quanlong Huang (Code Review) 
Quanlong Huang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10292


Change subject: IMPALA-6966: sort table memory by size in catalogd web UI
..

IMPALA-6966: sort table memory by size in catalogd web UI

This patch fix the sorting order in "Top-K Tables with Highest
Memory Requirements" in which "Estimated memory" column is sorted
as strings.

Values got from the catalog-server are changed from pretty-printed
strings to bytes numbers. So the web UI is able to sort and render
them correctly.

Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
---
M be/src/catalog/catalog-server.cc
M www/catalog.tmpl
2 files changed, 17 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/10292/1
--
To view, visit http://gerrit.cloudera.org:8080/10292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60dc253f862f5fde6fa96147f114d8765bb31a85
Gerrit-Change-Number: 10292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang