[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Sat, 18 Aug 2018 03:44:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. IMPALA-7444: Improve logging of opening/closing/expiring sessions. Recent troubleshooting efforts have shown we can improve logging of client session opening and expiry processing to enhance serviceability. This patch adds minor, but useful debug log improvements. Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Reviewed-on: http://gerrit.cloudera.org:8080/11234 Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc 2 files changed, 46 insertions(+), 32 deletions(-) Approvals: Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 5 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/403/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Sat, 18 Aug 2018 00:44:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3036/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Sat, 18 Aug 2018 00:33:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#4). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. IMPALA-7444: Improve logging of opening/closing/expiring sessions. Recent troubleshooting efforts have shown we can improve logging of client session opening and expiry processing to enhance serviceability. This patch adds minor, but useful debug log improvements. Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc 2 files changed, 46 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/11234/4 -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/11234 )
Change subject: IMPALA-7444: Improve logging of opening/closing/expiring
sessions.
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11234/3/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/11234/3/be/src/service/impala-server.cc@1975
PS3, Line 1975: LOG_IF(INFO, expired_cnt > 0) << "Expired sessions. Count:
" << expired_cnt
: << ". Time: " << UnixMillis()
- now << " milliseconds.";
nit: LOG_IF(INFO, expired_cnt > 0) << Substitute("Expired $0 sessions.",
expired_cnt);
I believe the timestamp at the log line is a reasonable proxy for the time when
the above critical section completed so there may not be a need to log the time
here.
--
To view, visit http://gerrit.cloudera.org:8080/11234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a
Gerrit-Change-Number: 11234
Gerrit-PatchSet: 3
Gerrit-Owner: Zoram Thanga
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Zoram Thanga
Gerrit-Reviewer: anujphadke
Gerrit-Comment-Date: Fri, 17 Aug 2018 22:49:20 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/379/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Thu, 16 Aug 2018 23:34:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#3). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. IMPALA-7444: Improve logging of opening/closing/expiring sessions. Recent troubleshooting efforts have shown we can improve logging of client session opening and expiry processing to enhance serviceability. This patch adds minor, but useful debug log improvements. Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc 2 files changed, 47 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/11234/3 -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc@1962 PS2, Line 1962: expired_cnt++; > ++expired_cnt; Done http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc@1975 PS2, Line 1975: LOG_IF(INFO, expired_cnt > 0) << "Expired sessions. Count: " << expired_cnt : << ". Time: " << UnixMillis() - now << " milliseconds."; > What's the purpose of this line ? Won't we be able to tell that from the "E The idea is to gauge how long session_state_map_lock_ is held in the process of expiring sessions. Probably less of an issue today after stack symbolization is removed. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Thu, 16 Aug 2018 23:00:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc@1962 PS2, Line 1962: expired_cnt++; ++expired_cnt; http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc@1975 PS2, Line 1975: LOG_IF(INFO, expired_cnt > 0) << "Expired sessions. Count: " << expired_cnt : << ". Time: " << UnixMillis() - now << " milliseconds."; What's the purpose of this line ? Won't we be able to tell that from the "Expiring session..." line above ? -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Thu, 16 Aug 2018 21:50:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/369/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Thu, 16 Aug 2018 06:04:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 1: (2 comments) > Just being paranoid here but I hope this doesn't make the log too > verbose. It's definitely more verbose than before, but I think it's worth it. Ordinarily, sessions are opened and stay around for a long time compared to individual queries. We would ordinarily see a lot of other messages in the log between open and close sessions. http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-hs2-server.cc@367 PS1, Line 367: Done opening > Opened Done http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-server.cc@1236 PS1, Line 1236: Done closing > Closed Done -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Thu, 16 Aug 2018 05:24:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#2). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. IMPALA-7444: Improve logging of opening/closing/expiring sessions. Recent troubleshooting efforts have shown we can improve logging of client session opening and expiry processing to enhance serviceability. This patch adds minor, but useful debug log improvements. Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc 2 files changed, 47 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/11234/2 -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zoram Thanga Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 1: Just being paranoid here but I hope this doesn't make the log too verbose. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Wed, 15 Aug 2018 19:25:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/349/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Wed, 15 Aug 2018 18:04:36 + Gerrit-HasComments: No
