[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. IMPALA-8369: Fixing some core tests in Hive environment Fixes: impala_test_suite.py: DROP PARTITIONS in the SETUP section of test files did not work with Hive 3, because 'max_parts' argument of hive_client.get_partition_names() was 0, while it should be -1 to return all partitions. The issue broke sevaral 'insert' tests. Hive 2 used to return all partitions with argument 0 too but Hive 3 changed this to be more consistent, see HIVE-18567. load_nested.py: query/test_mt_dop.py:test_parquet_filtering amd several planner tests were broken because Hive 3 generates different number of files for tpch_nested_parquet.customer than Hive 2. The fix is to split the loading of this table to two inserts on Hive 3 in order to produce an extra file. Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Reviewed-on: http://gerrit.cloudera.org:8080/13283 Tested-by: Impala Public Jenkins Reviewed-by: Vihang Karajgaonkar --- M testdata/bin/load_nested.py M tests/common/environ.py M tests/common/impala_test_suite.py 3 files changed, 38 insertions(+), 14 deletions(-) Approvals: Impala Public Jenkins: Verified Vihang Karajgaonkar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 14 May 2019 23:44:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 14 May 2019 18:01:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4249/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 14 May 2019 12:39:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3178/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 21:22:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 4: (1 comment) It turned out the -1 file in tpch_nested_parquet.customer broke several planner tests, so I reverted the changes around test-mt-dop.py and hacked load_nested.py instead to create 4 files on Hive 3 too. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py@738 PS3, Line 738: get_partition_names > I digged into this more. It looks like this a behavior change in Hive-3 bec Thanks for the investigation! I mentioned HIVE-18567 in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 21:00:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13283 to look at the new patch set (#4). Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. IMPALA-8369: Fixing some core tests in Hive environment Fixes: impala_test_suite.py: DROP PARTITIONS in the SETUP section of test files did not work with Hive 3, because 'max_parts' argument of hive_client.get_partition_names() was 0, while it should be -1 to return all partitions. The issue broke sevaral 'insert' tests. Hive 2 used to return all partitions with argument 0 too but Hive 3 changed this to be more consistent, see HIVE-18567. load_nested.py: query/test_mt_dop.py:test_parquet_filtering amd several planner tests were broken because Hive 3 generates different number of files for tpch_nested_parquet.customer than Hive 2. The fix is to split the loading of this table to two inserts on Hive 3 in order to produce an extra file. Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de --- M testdata/bin/load_nested.py M tests/common/environ.py M tests/common/impala_test_suite.py 3 files changed, 38 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13283/4 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py@738 PS3, Line 738: get_partition_names > It looks like that it doesn't, -1 works both in Hive 2 and 3. I digged into this more. It looks like this a behavior change in Hive-3 because of HIVE-18567. Previously, sending 0 would have returned all the partitions. Now, it returns empty result. I think Hive-3 is doing the right thing but it broke backwards compatibility as part of the fix. It would be good to document this in the comment to understand the context better in the future. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py@216 PS3, Line 216: == > For me "IfHive3" means that it should be exactly 3. If there will be a lot sounds reasonable to me. I just of making it consistent. I thought I saw in other patches we were using >= 3, for example, in hive-site.xml.py. I don't have strong opinion on this so feel free to keep it the way it is. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 19:09:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: (2 comments) It turned out that the changed file number in tpch_nested_parquet.customer broke several planner tests, so it would be much better to find a way to generate the same number of files both on Hive 2+3 instead of creating individual hacks for the different tests. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py@738 PS3, Line 738: get_partition_names > is this a change of behavior in hive client in version 3? If yes, is it bre It looks like that it doesn't, -1 works both in Hive 2 and 3. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py@216 PS3, Line 216: == > should this be >= 3 For me "IfHive3" means that it should be exactly 3. If there will be a lot of tests which should be skipped with both Hive 3 and 4, then a new SkipIf for >= 3 will make sense. I do not know of plans to work with Hive 4 - I hope that once this comes up, the support for Hive2 will be already dropped. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Fri, 10 May 2019 16:34:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4192/ -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 23:34:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: I killed the test job because it appeared to be stuck. You probably want to rebase and try again. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 23:34:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/3129/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 19:52:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/3128/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 19:52:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/3127/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 19:53:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4192/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 08 May 2019 19:18:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py@738 PS3, Line 738: get_partition_names is this a change of behavior in hive client in version 3? If yes, is it breaking backwards compatibility? http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py@216 PS3, Line 216: == should this be >= 3 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 08 May 2019 19:25:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13283/2/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/2/tests/common/skip.py@214 PS2, Line 214: > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 08 May 2019 19:11:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13283/2/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/2/tests/common/skip.py@214 PS2, Line 214: class SkipIfHive3: flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 08 May 2019 19:09:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. IMPALA-8369: Fixing some core tests in Hive environment Fixes: impala_test_suite.py: DROP PARTITIONS in the SETUP section of test files did not work with Hive 3, because 'max_parts' argument of hive_client.get_partition_names() was 0, while it should be -1 to return all partitions. The issue broke sevaral 'insert' tests. all other changed files: query/test_mt_dop.py:test_parquet_filtering was broken because Hive 3 generates different number of files for tpch_nested_parquet.customer than Hive 2. Tests that use this table were moved to a seperate .test file, which is not run in Hive 3 builds. Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de --- A testdata/workloads/functional-query/queries/QueryTest/parquet-filtering-tpch-nested-customer.test M testdata/workloads/functional-query/queries/QueryTest/parquet-filtering.test M tests/common/environ.py M tests/common/impala_test_suite.py M tests/common/skip.py M tests/query_test/test_mt_dop.py 6 files changed, 151 insertions(+), 136 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13283/2 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13283 to look at the new patch set (#3). Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. IMPALA-8369: Fixing some core tests in Hive environment Fixes: impala_test_suite.py: DROP PARTITIONS in the SETUP section of test files did not work with Hive 3, because 'max_parts' argument of hive_client.get_partition_names() was 0, while it should be -1 to return all partitions. The issue broke sevaral 'insert' tests. all other changed files: query/test_mt_dop.py:test_parquet_filtering was broken because Hive 3 generates different number of files for tpch_nested_parquet.customer than Hive 2. Tests that use this table were moved to a seperate .test file, which is not run in Hive 3 builds. Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de --- A testdata/workloads/functional-query/queries/QueryTest/parquet-filtering-tpch-nested-customer.test M testdata/workloads/functional-query/queries/QueryTest/parquet-filtering.test M tests/common/environ.py M tests/common/impala_test_suite.py M tests/common/skip.py M tests/query_test/test_mt_dop.py 6 files changed, 152 insertions(+), 136 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13283/3 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13283 Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. IMPALA-8369: Fixing some core tests in Hive environment Fixes: impala_test_suite.py: DROP PARTITIONS in the SETUP section of test files did not work with Hive 3, because 'max_parts' argument of hive_client.get_partition_names() was 0, while it should be -1 to return all partitions. The issue broke sevaral 'insert' tests. all other changed files: query/test_mt_dop.py:test_parquet_filtering was broken because Hive 3 generates different number of files for tpch_nested_parquet.customer than Hive 2. Tests that use this table were moved to a seperate .test file, which is not run in Hive 3 builds. Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de --- A testdata/workloads/functional-query/queries/QueryTest/parquet-filtering-tpch-nested-customer.test 1 file changed, 126 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/13283/1 -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
