[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 19 Aug 2019 03:22:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Reviewed-on: http://gerrit.cloudera.org:8080/14021 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 293 insertions(+), 79 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 10 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 9: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/457/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 16 Aug 2019 15:40:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/14021/8/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/8/docs/topics/impala_default_transactional_type.xml@46 PS8, Line 46: t > nit: capital T Done -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 16 Aug 2019 15:19:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Hello Greg Rahn, Tamas Mate, Lars Volker, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#9). Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 293 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/14021/9 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 9: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/457/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 9 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 16 Aug 2019 15:19:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 8: Code-Review+1 (1 comment) Looks good to me. One minor typo. http://gerrit.cloudera.org:8080/#/c/14021/8/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/8/docs/topics/impala_default_transactional_type.xml@46 PS8, Line 46: t nit: capital T -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 16 Aug 2019 07:21:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 15 Aug 2019 00:45:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 8: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/453/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 14 Aug 2019 15:38:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 8: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/453/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 14 Aug 2019 15:16:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Hello Greg Rahn, Tamas Mate, Lars Volker, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#8). Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 293 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/14021/8 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 8 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 7: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/444/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 7 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 10 Aug 2019 00:17:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 7: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/444/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 7 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 10 Aug 2019 00:09:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Hello Greg Rahn, Tamas Mate, Lars Volker, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#7). Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 292 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/14021/7 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 7 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14021/6/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/6/docs/topics/impala_default_transactional_type.xml@58 PS6, Line 58: The : INSERT operations will be transactional on this table. > I think that the best thing here would be a link to impala_transactions. Done http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@35 PS5, Line 35: satisfy ACID (Atomicity, Consistency, Isolation, Durability) properties, which intend to > I totally agree with Tim, we should think it through carefully what to writ Rewored more. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 10 Aug 2019 00:07:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14021/6/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/6/docs/topics/impala_default_transactional_type.xml@58 PS6, Line 58: The : INSERT operations will be transactional on this table. I think that the best thing here would be a link to impala_transactions. http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@35 PS5, Line 35: satisfy a level of ACID (Atomicity, Consistency, Isolation, Durability) properties, which > Slightly reworded. I totally agree with Tim, we should think it through carefully what to write here. What Impala should profit from Hive ACID at the moment is that a single table insert from Hive/Impala is either completely seen or not seen at all during a query (without ACID if an insert create more than one files, it was possible to list the files at the "wrong moment" when only some of them were copied to their final destination from the staging directory), and for a single table the inserts are "ordered", so if Impala doesn't see a committed insert, it won't see any insert committed after it. On the other side for different tables Impala can have snapshots from totally different times, so it may see a commit on table A while not see a much earlier commit on table B. This should not happen when reading with Hive. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 09 Aug 2019 20:44:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 6: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/442/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 09 Aug 2019 00:43:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Hello Greg Rahn, Tamas Mate, Lars Volker, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#6). Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 287 insertions(+), 79 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/14021/6 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 6: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/442/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 6 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 09 Aug 2019 00:34:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_create_table.xml@388 PS5, Line 388: When integrated with Hive3 and the > Maybe worth calling out at the top that this only works when Impala is buil Done http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@35 PS5, Line 35: satisfy ACID (Atomicity, Consistency, Isolation, Durability) properties, which intend to > Impala doesn't currently support strong consistency, since Impala may opera Slightly reworded. http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@41 PS5, Line 41: transactional tables at the row level. > Unclear what "at the row level" means. Maybe Done http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@50 PS5, Line 50: Impala currently supports auto-committed transactions, and thus every SQL statement is an > Could be clearer that this is the only behaviour, rather than an optional f Done http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@51 PS5, Line 51: automic > atomic Done -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 09 Aug 2019 00:32:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_create_table.xml@388 PS5, Line 388: When integrated with Hive3 and the Maybe worth calling out at the top that this only works when Impala is built with Hive 3 support? And the version of Impala that will support it? http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@35 PS5, Line 35: satisfy ACID (Atomicity, Consistency, Isolation, Durability) properties, which intend to Impala doesn't currently support strong consistency, since Impala may operate on cached snapshots of transactional tables, and those different snapshots are not guaranteed to be in sync with each other. I think the description here is reasonably but might be misconstrued by someone as being a claim of strong consistency. It does support a weaker form of consistency. I'm not sure about the best way to describe the current guarantees that will make sense to users. Maybe Greg Rahn would have some input on this. http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@41 PS5, Line 41: transactional tables at the row level. Unclear what "at the row level" means. Maybe "Specifically, Impala provides atomicity and isolation of DML operations on transactional tables. That is, the results of the DML operations are either committed in full or not committed, and the results of the DML operation are not visible to concurrent operations until the DML operation is committed." http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@50 PS5, Line 50: Impala currently supports auto-committed transactions, and thus every SQL statement is an Could be clearer that this is the only behaviour, rather than an optional feature. Maybe All transactions in Impala automatically commit at the end of the statement. I.e. there are no multi-statement transactions. http://gerrit.cloudera.org:8080/#/c/14021/5/docs/topics/impala_transactions.xml@51 PS5, Line 51: automic atomic -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 08 Aug 2019 16:06:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 5: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/438/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 07 Aug 2019 16:53:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Hello Greg Rahn, Tamas Mate, Lars Volker, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#5). Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 674 insertions(+), 759 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/14021/5 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 5: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/438/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 07 Aug 2019 16:46:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@42 PS4, Line 42: The query option applies only when integrated with Hive : 3. > nit: This could be in the pre-requisite note/important field. (please see m Done http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@50 PS4, Line 50: The default table type is not transactional. > nit: this is a bit ambiguous, would be more clear something like: Done http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@54 PS4, Line 54: The default table type is the insert-only transactional : table. > nit: would be more clear something like: Done http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@60 PS4, Line 60: : If either table properties, transactional or : transactional_properties, are set, this query option is ignored. : : : : The DEFAULT_TRANSACTION_TYPE query option does not affect external, Kudu, : or HBase tables as these cannot be transactional. : > nit: These could be in a note or important block, so users are warned about The first paragraph is common in query options. I will put the second paragraph in a note. I do not want to overuse the Note/Important as it will lessen the effect. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_transactions.xml@59 PS4, Line 59: Impala does not support changing transactional properties of tables. For example, you : cannot alter a transactional table to a non-transactional table. > nit: this could be in a note/important as well Done -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 07 Aug 2019 16:45:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 4: (5 comments) Hi Alex, thank you for the doc update. Added some minor comments. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@42 PS4, Line 42: The query option applies only when integrated with Hive : 3. nit: This could be in the pre-requisite note/important field. (please see my comment on line 60-68) http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@50 PS4, Line 50: The default table type is not transactional. nit: this is a bit ambiguous, would be more clear something like: Default value, the created table will not be transactional. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@54 PS4, Line 54: The default table type is the insert-only transactional : table. nit: would be more clear something like: The created table will be marked as transactional, INSERT queries will be transactional on this table. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@60 PS4, Line 60: : If either table properties, transactional or : transactional_properties, are set, this query option is ignored. : : : : The DEFAULT_TRANSACTION_TYPE query option does not affect external, Kudu, : or HBase tables as these cannot be transactional. : nit: These could be in a note or important block, so users are warned about the prerequisites and scope of the query option. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_transactions.xml@59 PS4, Line 59: Impala does not support changing transactional properties of tables. For example, you : cannot alter a transactional table to a non-transactional table. nit: this could be in a note/important as well -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tamas Mate Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 07 Aug 2019 16:00:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/436/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 07 Aug 2019 02:56:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala
Hello Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14021 to look at the new patch set (#4). Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala - Added impala_transactions.xml - Added impala_default_transactional_type.xml Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb --- M docs/impala.ditamap M docs/topics/impala_create_table.xml A docs/topics/impala_default_transactional_type.xml A docs/topics/impala_transactions.xml 4 files changed, 670 insertions(+), 759 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/14021/4 -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
