[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 06 Mar 2019 05:12:06 + Gerrit-HasComments: No
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Simplify JNI exception-handling macros. This simplifies the implementations of ABORT_IF_EXC() and CLEAN_EXIT_IF_EXC() by reducing them to usages of JniUtil::GetJniExceptionMsg() and our typical Status-handling macros. The existing implementations didn't clear the exception before calling additional Java methods, whereas JniUtil::GetJniExceptionMsg() already handled that correctly. I tested this manually by renaming a class in catalogd's startup sequence to a class that doesn't exist and checked that the crash logging was useful, containing both the Java and C++ stack traces with both macros. This is part of IMPALA-8250. Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Reviewed-on: http://gerrit.cloudera.org:8080/12659 Reviewed-by: Philip Zeyliger Tested-by: Impala Public Jenkins --- M be/src/util/jni-util.h 1 file changed, 9 insertions(+), 27 deletions(-) Approvals: Philip Zeyliger: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 3: Code-Review+2 Rebase; carrying +2. -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 06 Mar 2019 00:59:11 + Gerrit-HasComments: No
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3880/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 06 Mar 2019 00:59:29 + Gerrit-HasComments: No
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2358/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 05 Mar 2019 21:10:01 + Gerrit-HasComments: No
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Hello Sahil Takiar, Todd Lipcon, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12659 to look at the new patch set (#2). Change subject: Simplify JNI exception-handling macros. .. Simplify JNI exception-handling macros. This simplifies the implementations of ABORT_IF_EXC() and CLEAN_EXIT_IF_EXC() by reducing them to usages of JniUtil::GetJniExceptionMsg() and our typical Status-handling macros. The existing implementations didn't clear the exception before calling additional Java methods, whereas JniUtil::GetJniExceptionMsg() already handled that correctly. I tested this manually by renaming a class in catalogd's startup sequence to a class that doesn't exist and checked that the crash logging was useful, containing both the Java and C++ stack traces with both macros. This is part of IMPALA-8250. Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c --- M be/src/util/jni-util.h 1 file changed, 9 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12659/2 -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/12659 )
Change subject: Simplify JNI exception-handling macros.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12659/2/be/src/util/jni-util.h
File be/src/util/jni-util.h:
http://gerrit.cloudera.org:8080/#/c/12659/2/be/src/util/jni-util.h@58
PS2, Line 58: #define ABORT_IF_EXC(env) do {
ABORT_IF_ERROR(JniUtil::GetJniExceptionMsg(env)); } while (false)
line too long (96 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c
Gerrit-Change-Number: 12659
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Tue, 05 Mar 2019 20:37:09 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 05 Mar 2019 17:56:50 + Gerrit-HasComments: No
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12659 ) Change subject: Simplify JNI exception-handling macros. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2347/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 05 Mar 2019 02:07:03 + Gerrit-HasComments: No
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12659 Change subject: Simplify JNI exception-handling macros. .. Simplify JNI exception-handling macros. This simplifies the implementations of ABORT_IF_EXC() and CLEAN_EXIT_IF_EXC() by reducing them to usages of JniUtil::GetJniExceptionMsg() and our typical Status-handling macros. The existing implementations didn't clear the exception before calling additional Java methods, whereas JniUtil::GetJniExceptionMsg() already handled that correctly. I tested this manually by renaming a class in catalogd's startup sequence to a class that doesn't exist and checked that the crash logging was useful, containing both the Java and C++ stack traces with both macros. This is part of IMPALA-8250. Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c --- M be/src/util/jni-util.h 1 file changed, 9 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12659/1 -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger
[Impala-ASF-CR] Simplify JNI exception-handling macros.
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/12659 )
Change subject: Simplify JNI exception-handling macros.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12659/1/be/src/util/jni-util.h
File be/src/util/jni-util.h:
http://gerrit.cloudera.org:8080/#/c/12659/1/be/src/util/jni-util.h@58
PS1, Line 58: #define ABORT_IF_EXC(env) do {
ABORT_IF_ERROR(JniUtil::GetJniExceptionMsg(env)); } while (false)
line too long (96 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c
Gerrit-Change-Number: 12659
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Sahil Takiar
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Tue, 05 Mar 2019 01:24:17 +
Gerrit-HasComments: Yes
