[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 2:

I just noticed that we compile binutils before other components and it depends 
on Bison. So even with this change we still needs GNU Bison in the system.


--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 20:16:56 +
Gerrit-HasComments: No

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tianyi Wang (Code Review)]

Tianyi Wang has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..

Bump thrift to 0.9.3-p2; Add bison 3.0.4

This patch upgrades thrift to 0.9.3-p2. Two patches are applied:
1. THRIFT-3650.
2. Remove Twisted Python dependency.

Thrift 0.9.3 depends on bison 2.5 or higher, which is not available on
some distributions including centos 5. This patch adds bison 3.0.4 to
the toolchain.
The minimum openssl version is bumped to 1.0.1. Bundled openssl will be
used to build thrift if the requirement is not met.
Testing: It builds on all supported OSes.

Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
---
M buildall.sh
A source/bison/build.sh
M source/thrift/build.sh
A source/thrift/thrift-0.9.3-patches/0001-THRIFT-3650.patch
A source/thrift/thrift-0.9.3-patches/0002-reomve-twisted-pyton-dependency.patch
5 files changed, 163 insertions(+), 34 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Tim Armstrong: Looks good to me, approved
  Tianyi Wang: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 17 Jan 2018 21:22:30 +
Gerrit-HasComments: No

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 17 Jan 2018 19:40:48 +
Gerrit-HasComments: No

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 2:

I had a question on the JIRA about patch 0011 that was previous applied to 
thrift.


--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 17 Jan 2018 17:24:30 +
Gerrit-HasComments: No

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 2: Code-Review+2

Looks fine to me. Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 17 Jan 2018 04:44:06 +
Gerrit-HasComments: No

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tianyi Wang (Code Review)]

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 2:

(3 comments)

Other existing patches are not needed. The patch review is at: 
https://issues.apache.org/jira/browse/IMPALA-5690

http://gerrit.cloudera.org:8080/#/c/9035/1/source/bison/build.sh
File source/bison/build.sh:

http://gerrit.cloudera.org:8080/#/c/9035/1/source/bison/build.sh@2
PS1, Line 2: # Copyright 2018 Cloudera Inc.
> It's 2018.
Done


http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh
File source/thrift/build.sh:

http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh@38
PS1, Line 38:   read OPENSSL_MAJ_VER OPENSSL_MIN_VER OPENSSL_PATCH_VER <<< 
`openssl version |  \
> This section requires comments. When is this happening and what's it doing?
Done


http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh@63
PS1, Line 63:   PATH="${BISON_ROOT}"/bin:"${PATH}" \
> This CONFIGURE_OUTPUT=$(...) trick is weird and hard to spot. I think $BUIL
Done



--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 17 Jan 2018 00:29:16 +
Gerrit-HasComments: Yes

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tianyi Wang (Code Review)]

Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9035

to look at the new patch set (#2).

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..

Bump thrift to 0.9.3-p2; Add bison 3.0.4

This patch upgrades thrift to 0.9.3-p2. Two patches are applied:
1. THRIFT-3650.
2. Remove Twisted Python dependency.

Thrift 0.9.3 depends on bison 2.5 or higher, which is not available on
some distributions including centos 5. This patch adds bison 3.0.4 to
the toolchain.
The minimum openssl version is bumped to 1.0.1. Bundled openssl will be
used to build thrift if the requirement is not met.
Testing: It builds on all supported OSes.

Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
---
M buildall.sh
A source/bison/build.sh
M source/thrift/build.sh
A source/thrift/thrift-0.9.3-patches/0001-THRIFT-3650.patch
A source/thrift/thrift-0.9.3-patches/0002-reomve-twisted-pyton-dependency.patch
5 files changed, 163 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/35/9035/2
--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Philip Zeyliger (Code Review)]

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9035 )

Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..


Patch Set 1:

(3 comments)

Thanks! Minor comments below.

We had considerably more patches for older Thrift. Have you reviewed that we 
don't need any of them?

Thanks!

http://gerrit.cloudera.org:8080/#/c/9035/1/source/bison/build.sh
File source/bison/build.sh:

http://gerrit.cloudera.org:8080/#/c/9035/1/source/bison/build.sh@2
PS1, Line 2: # Copyright 2015 Cloudera Inc.
It's 2018.


http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh
File source/thrift/build.sh:

http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh@38
PS1, Line 38:   read OPENSSL_MAJ_VER OPENSSL_MIN_VER OPENSSL_PATCH_VER <<< 
`openssl version |  \
This section requires comments. When is this happening and what's it doing?


http://gerrit.cloudera.org:8080/#/c/9035/1/source/thrift/build.sh@63
PS1, Line 63: ./configure \
This CONFIGURE_OUTPUT=$(...) trick is weird and hard to spot. I think 
$BUILD_LOG is where the output of 'wrap' goes, so you can just grep that in 
line 90-97 and life will be more obvious.



--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Tue, 16 Jan 2018 22:58:54 +
Gerrit-HasComments: Yes

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

[Tianyi Wang (Code Review)]

Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9035


Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4
..

Bump thrift to 0.9.3-p2; Add bison 3.0.4

This patch upgrades thrift to 0.9.3-p2. Two patches are applied:
1. THRIFT-3650.
2. Remove Twisted Python dependency.

Thrift 0.9.3 depends on bison 2.5 or higher, which is not available on
some distributions including centos 5. This patch adds bison 3.0.4 to
the toolchain.
The minimum openssl version is bumped to 1.0.1. Bundled openssl will be
used to build thrift if the requirement is not met.
Testing: It builds on all supported OSes.

Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
---
M buildall.sh
A source/bison/build.sh
M source/thrift/build.sh
A source/thrift/thrift-0.9.3-patches/0001-THRIFT-3650.patch
A source/thrift/thrift-0.9.3-patches/0002-reomve-twisted-pyton-dependency.patch
5 files changed, 162 insertions(+), 34 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/35/9035/1
--
To view, visit http://gerrit.cloudera.org:8080/9035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I710e977e4a182e5d3aaf58f1233c68c04585bebd
Gerrit-Change-Number: 9035
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang