[native-toolchain-CR] Create CCACHE DIR if not present
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Create CCACHE_DIR if not present This caused buildall.sh to fail because of the directory not being present. Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Reviewed-on: http://gerrit.cloudera.org:8080/13232 Reviewed-by: Laszlo Gaal Reviewed-by: Hector Acosta Reviewed-by: Tim Armstrong Tested-by: Tim Armstrong --- M functions.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Laszlo Gaal: Looks good to me, but someone else must approve Hector Acosta: Looks good to me, but someone else must approve Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] Create CCACHE DIR if not present
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: Code-Review+2 I'll upgrade the two +1s to a +2 :) -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 May 2019 23:50:23 + Gerrit-HasComments: No
[native-toolchain-CR] Create CCACHE DIR if not present
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: Verified+1 Tested this locally. -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 May 2019 23:50:34 + Gerrit-HasComments: No
[native-toolchain-CR] Create CCACHE DIR if not present
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: > LGTM, I should have caught it the first time around though... > Apparently download_ccache is called before init-compiler.sh has a > chance to create the CCACHE dir. > Letting Hector take a look as well FWIW, this works fine in the docker path (https://github.com/cloudera/native-toolchain/blob/master/in-docker.py#L112), which is why the jenkins job works fine. -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Tue, 07 May 2019 19:15:38 + Gerrit-HasComments: No
[native-toolchain-CR] Create CCACHE DIR if not present
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Tue, 07 May 2019 18:49:12 + Gerrit-HasComments: No
[native-toolchain-CR] Create CCACHE DIR if not present
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/13232 ) Change subject: Create CCACHE_DIR if not present .. Patch Set 1: Code-Review+1 LGTM, I should have caught it the first time around though... Apparently download_ccache is called before init-compiler.sh has a chance to create the CCACHE dir. Letting Hector take a look as well -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 03 May 2019 17:18:02 + Gerrit-HasComments: No
[native-toolchain-CR] Create CCACHE DIR if not present
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13232 Change subject: Create CCACHE_DIR if not present .. Create CCACHE_DIR if not present This caused buildall.sh to fail because of the directory not being present. Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 --- M functions.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/32/13232/1 -- To view, visit http://gerrit.cloudera.org:8080/13232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64 Gerrit-Change-Number: 13232 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
