[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2:

(1 comment)

Just a thought passing by, no need to hold the change up for this.

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@274
PS2, Line 274:  << "Query " << PrintId(query_id()) << " may 
hang. See IMPALA-2990.";
Should we include the reason for the abort here? Otherwise the large number of 
cases that possibly lead to this error could make debugging unnecessarily hard.



--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 02:14:14 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6650: Add fine-grained DROP privilege

[Fredy Wijaya (Code Review)]

Fredy Wijaya has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/9911 )

Change subject: IMPALA-6650: Add fine-grained DROP privilege
..

IMPALA-6650: Add fine-grained DROP privilege

Add support for executing DROP statements by granting DROP privilege.

These are the new GRANT/REVOKE statements introduced at server,
database, and table scopes.

GRANT DROP on SERVER svr TO ROLE testrole;
GRANT DROP on DATABASE db TO ROLE testrole;
GRANT DROP on TABLE tbl TO ROLE testrole;

REVOKE DROP on SERVER svr FROM ROLE testrole;
REVOKE DROP on DATABASE db FROM ROLE testrole;
REVOKE DROP on TABLE tbl FROM ROLE testrole;

Testing:
- Added new front-end tests
- Ran front-end tests

Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
---
M common/thrift/CatalogObjects.thrift
M fe/.gitignore
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DropFunctionStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationChecker.java
M fe/src/main/java/org/apache/impala/authorization/Privilege.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/resources/authz-policy.ini.template
12 files changed, 187 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9911/3
--
To view, visit http://gerrit.cloudera.org:8080/9911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1dfb0b117cb1725e9656b9a79a9aebee82b5e4
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

[Mostafa Mokhtar (Code Review)]

Mostafa Mokhtar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9916 )

Change subject: IMPALA-6792: Fail status reporting if coordinator refuses 
connections
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@260
PS2, Line 260: if (i < 2) SleepForMs(100);
I would feel more comfortable if the 100ms is under a flag as this might 
uncover false positives on large clusters with busy coordinators.


http://gerrit.cloudera.org:8080/#/c/9916/2/be/src/runtime/query-state.cc@274
PS2, Line 274:  << "Query " << PrintId(query_id()) << " may 
hang. See IMPALA-2990.";
> Should we include the reason for the abort here? Otherwise the large number
Can't connect to coordinator Vs. Can't report status?



--
To view, visit http://gerrit.cloudera.org:8080/9916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If668838f99f78b5ffa713488178b2eb5799ba220
Gerrit-Change-Number: 9916
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 04 Apr 2018 02:41:34 +
Gerrit-HasComments: Yes