[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-24 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


IMPALA-5780,IMPALA-5779: extra spilling tests

* Test for disable_unsafe_spills
* Test for buffer size > I/O size (--read_size)

Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Reviewed-on: http://gerrit.cloudera.org:8080/7787
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
A 
testdata/workloads/functional-query/queries/QueryTest/disable-unsafe-spills.test
M 
testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test
M tests/query_test/test_spilling.py
3 files changed, 45 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-24 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1145/

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1143/

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1143/

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 2: Code-Review+2

rebased onto the naaj patch to confirm no merge conflicts

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1141/

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test
File 
testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test:

Line 197: # Test that we can spill with a buffer size larger than the default 
I/O size (8mb).
> I'm not sure if it's that interesting. My initial motivation for this was j
yeah, was trying to think if there's anything interesting with BTS, but doesn't 
seem like it.


-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1141/

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test
File 
testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test:

Line 197: # Test that we can spill with a buffer size larger than the default 
I/O size (8mb).
> worth writing a similar test for join/agg?
I'm not sure if it's that interesting. My initial motivation for this was just 
to make sure that there are no assumptions in TmpFileMgr or DiskIoMgr about the 
size of the reads and writes.


-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test
File 
testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test:

Line 197: # Test that we can spill with a buffer size larger than the default 
I/O size (8mb).
worth writing a similar test for join/agg?


-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/disable-unsafe-spills.test
File 
testdata/workloads/functional-query/queries/QueryTest/disable-unsafe-spills.test:

Line 5: set disable_unsafe_spills=true;
is there a similar test w/ SCRATCH_LIMIT set to 0 and maybe another non-zero 
value?


http://gerrit.cloudera.org:8080/#/c/7787/1/tests/query_test/test_spilling.py
File tests/query_test/test_spilling.py:

Line 67: self.run_test_case('QueryTest/disable-unsafe-spills', vector)
can this just go in test_spilling? I don't think we'll need to add more test 
cases to this file later, so may be worth reducing the number of test files.


-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7787

Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..

IMPALA-5780,IMPALA-5779: extra spilling tests

* Test for disable_unsafe_spills
* Test for buffer size > I/O size (--read_size)

Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
---
A 
testdata/workloads/functional-query/queries/QueryTest/disable-unsafe-spills.test
M 
testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test
M tests/query_test/test_spilling.py
3 files changed, 45 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7787/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong