[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error

Augment the error message to mention that oversubscription is likely the
problem and hint at solutions.

Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Reviewed-on: http://gerrit.cloudera.org:8080/7861
Reviewed-by: Dan Hecht 
Tested-by: Impala Public Jenkins
---
M common/thrift/generate_error_codes.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1163/

-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7861/1/common/thrift/generate_error_codes.py
File common/thrift/generate_error_codes.py:

PS1, Line 328: memory-based admission control
> I think we already do recommend it if you have a very specific set of use c
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review) 
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7861

to look at the new patch set (#3).

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..

IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error

Augment the error message to mention that oversubscription is likely the
problem and hint at solutions.

Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
---
M common/thrift/generate_error_codes.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7861/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review) 
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7861

to look at the new patch set (#2).

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..

IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error

Augment the error message to mention that oversubscription is likely the
problem and hint at solutions.

Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
---
M common/thrift/generate_error_codes.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7861/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7861/1/common/thrift/generate_error_codes.py
File common/thrift/generate_error_codes.py:

PS1, Line 328: memory-based admission control
> are we ready to recommend that widely? maybe we should just say "admission 
I think we already do recommend it if you have a very specific set of use 
cases. If you think this message would imply to some users that it might work 
in all cases, then I agree with your simplification.


-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7861/1/common/thrift/generate_error_codes.py
File common/thrift/generate_error_codes.py:

PS1, Line 328: memory-based admission control
are we ready to recommend that widely? maybe we should just say "admission 
control", since max-queries could also be a way to lower concurrency.  Matt, 
what do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..


Patch Set 1: Code-Review+1

Looks more helpful to me, thanks

-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5852: improve MINIMUM RESERVATION UNAVAILABLE error

2017-08-28 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7861

Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..

IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error

Augment the error message to mention that oversubscription is likely the
problem and hint at solutions.

Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
---
M common/thrift/generate_error_codes.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7861/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong