[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Internal Jenkins has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Internal Jenkins has submitted this change and it was merged. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Minor fixes to remove more "cloudera"s from the code. Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Reviewed-on: http://gerrit.cloudera.org:8080/4774 Reviewed-by: Jim Apple Tested-by: Internal Jenkins --- M tests/benchmark/report_benchmark_results.py M tests/test-hive-udfs/src/main/java/org/apache/impala/UnresolvedUdf.java 2 files changed, 15 insertions(+), 12 deletions(-) Approvals: Jim Apple: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 2: Code-Review+2 Carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Tim Armstrong has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Lars Volker has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: Line 249: url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha > If by "both repos", you mean github.com/cloudera/Impala and github.com/apac SGTM. -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: Line 249: url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha > Yes, it seems that commits that land in both repos end up having different If by "both repos", you mean github.com/cloudera/Impala and github.com/apache/incubator-impala, then I agree. However, (a) commits that land in the apache-hosted Impala repo at https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git;a=summary have the same hashes as those in the github mirror at github.com/apache/incubator-impala and (b) cloudera/Impaala is not receiving ANY new commits at the moment: https://issues.cloudera.org/browse/IMPALA-3691 As such, I doubt anyone is building from it anymore. -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Lars Volker has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: Line 249: url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha > I don't think that commit is in the upstream repo. Try this: Yes, it seems that commits that land in both repos end up having different hashes. Since the hash passed here is extracted from a profile, anyone who uses this would need to build from the incubator repo instead of cloudera/impala, so that the commit from the profile can be found. Let's update it and send a mail to dev@ afterwards to let everyone know. -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: Line 249: url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha > I tried opening this URL in my browser and it did not work: I don't think that commit is in the upstream repo. Try this: https://api.github.com/repos/apache/incubator-impala/commits/bf1d9677fc09dabc88ab6c71f82ec99ec59ec164 github lags behind the official repo. I don't know of any other tooling which needs to be updated at the moment. -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Lars Volker has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: Line 249: url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha I tried opening this URL in my browser and it did not work: https://api.github.com/repos/apache/incubator-impala/commits/01489997c8f6967c6b511591f4ac7da695de51aa The old one worked: https://api.github.com/repos/cloudera/Impala/commits/01489997c8f6967c6b511591f4ac7da695de51aa Do we need to point any other tooling to the new repo in a parallel change? -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Jim Apple has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1//COMMIT_MSG Commit Message: Line 7: Minor fixes to remove more "cloudera"s from the code. > Is there a Jira we could refer to here? Not really. IMPALA-3221 and IMPALA-4047 are closely related, though. -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Lars Volker has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1//COMMIT_MSG Commit Message: Line 7: Minor fixes to remove more "cloudera"s from the code. Is there a Jira we could refer to here? -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4774 Change subject: Minor fixes to remove more "cloudera"s from the code. .. Minor fixes to remove more "cloudera"s from the code. Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a --- M tests/benchmark/report_benchmark_results.py M tests/test-hive-udfs/src/main/java/org/apache/impala/UnresolvedUdf.java 2 files changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/4774/1 -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple