[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has submitted this change and it was merged.

Change subject: Remove Llama dependency
..


Remove Llama dependency

This change prevents us from depending on LLAMA to build.

Note that the LLAMA MiniKDC is left in - it is a test
utility that does not depend on LLAMA itself.
IMPALA-4292 tracks cleaning this up.

Testing:
Ran a private build to verify that all tests pass.

Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Reviewed-on: http://gerrit.cloudera.org:8080/4739
Reviewed-by: Tim Armstrong 
Reviewed-by: Henry Robinson 
Tested-by: Internal Jenkins
---
M bin/bootstrap_toolchain.py
M bin/generate_minidump_collection_testdata.py
M bin/impala-config.sh
M bin/start-impala-cluster.py
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/generate_metrics.py
M common/thrift/metrics.json
M infra/deploy/deploy.py
9 files changed, 13 insertions(+), 43 deletions(-)

Approvals:
  Henry Robinson: Looks good to me, approved
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] Remove Llama dependency

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] Remove Llama dependency

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json
File common/thrift/metrics.json:

PS1, Line 573: 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
> I don't have any way to easily test it. These metrics no longer exist so I 
Looks like we (I) have removed metrics pretty recently anyhow. I couldn't 
remember whether this file constituted any kind of public interface that we 
couldn't remove things from. You should be good to go.


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json
File common/thrift/metrics.json:

PS1, Line 573: 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
> Does anything break in (e.g.) Cloudera Manager if you remove this?
I don't have any way to easily test it. These metrics no longer exist so I 
can't see how anything downstream could be doing anything with them.


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json
File common/thrift/metrics.json:

PS1, Line 573: 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
Does anything break in (e.g.) Cloudera Manager if you remove this?


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 92:   21: optional i16 v_cpu_cores
> add some TODO here
Done


Line 108:   25: optional i64 rm_initial_mem = 0
> add same TODO here
Done


http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

Line 137:   V_CPU_CORES,
> add same TODO
Done


Line 153:   RM_INITIAL_MEM,
> add same TODO
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Hello Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4739

to look at the new patch set (#3).

Change subject: Remove Llama dependency
..

Remove Llama dependency

This change prevents us from depending on LLAMA to build.

Note that the LLAMA MiniKDC is left in - it is a test
utility that does not depend on LLAMA itself.
IMPALA-4292 tracks cleaning this up.

Testing:
Ran a private build to verify that all tests pass.

Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
---
M bin/bootstrap_toolchain.py
M bin/generate_minidump_collection_testdata.py
M bin/impala-config.sh
M bin/start-impala-cluster.py
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/generate_metrics.py
M common/thrift/metrics.json
M infra/deploy/deploy.py
9 files changed, 13 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/4739/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] Remove Llama dependency

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 2: Code-Review+2

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 92:   21: optional i16 v_cpu_cores
add some TODO here


Line 108:   25: optional i64 rm_initial_mem = 0
add same TODO here


http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

Line 137:   V_CPU_CORES,
add same TODO


Line 153:   RM_INITIAL_MEM,
add same TODO


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

Line 141:   // TODO: retire at compatibility-breaking version
> maybe we should create a JIRA for these things and then reference the jira 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4739

to look at the new patch set (#2).

Change subject: Remove Llama dependency
..

Remove Llama dependency

This change prevents us from depending on LLAMA to build.

Note that the LLAMA MiniKDC is left in - it is a test
utility that does not depend on LLAMA itself.
IMPALA-4292 tracks cleaning this up.

Testing:
Ran a private build to verify that all tests pass.

Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
---
M bin/bootstrap_toolchain.py
M bin/generate_minidump_collection_testdata.py
M bin/impala-config.sh
M bin/start-impala-cluster.py
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/generate_metrics.py
M common/thrift/metrics.json
M infra/deploy/deploy.py
9 files changed, 6 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/4739/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 

[Impala-ASF-CR] Remove Llama dependency

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change.

Change subject: Remove Llama dependency
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

Line 141:   // TODO: retire at compatibility-breaking version
maybe we should create a JIRA for these things and then reference the jira 
here, so that we don't forget to do it.


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Remove Llama dependency

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4739

Change subject: Remove Llama dependency
..

Remove Llama dependency

This change prevents us from depending on LLAMA to build.

Note that the LLAMA MiniKDC is left in - it is a test
utility that does not depend on LLAMA itself.
IMPALA-4292 tracks cleaning this up.

Testing:
Ran a private build to verify that all tests pass.

Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
---
M bin/bootstrap_toolchain.py
M bin/generate_minidump_collection_testdata.py
M bin/impala-config.sh
M bin/start-impala-cluster.py
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/generate_metrics.py
M common/thrift/metrics.json
M infra/deploy/deploy.py
9 files changed, 6 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/4739/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong