[GitHub] [incubator-iotdb] JulianFeinauer merged pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format().
JulianFeinauer merged pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format(). URL: https://github.com/apache/incubator-iotdb/pull/739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] SilverNarcissus closed pull request #741: [IOTDB-421] Fix merge problem
SilverNarcissus closed pull request #741: [IOTDB-421] Fix merge problem URL: https://github.com/apache/incubator-iotdb/pull/741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] SilverNarcissus commented on issue #741: [IOTDB-421] Fix merge problem
SilverNarcissus commented on issue #741: [IOTDB-421] Fix merge problem URL: https://github.com/apache/incubator-iotdb/pull/741#issuecomment-574535076 This problem has been fixed at https://github.com/apache/incubator-iotdb/pull/743 more gracefully. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] SilverNarcissus commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted
SilverNarcissus commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743#issuecomment-574534286 This fixing is amazing! I have tested it with large data which contains unordered problem. It gives the right result and the code is brilliant! Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] JulianFeinauer commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
JulianFeinauer commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format(). URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574533653 @sunjincheng121 I agree with your arguments and do not insist on em and as your change is, as you say "somewhat" idempotent we can leave it like that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format(). URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574533265 Thanks for your review @JulianFeinauer ! At the beginning I really wanted to restore the locale in the tearDown () method, but in that way, we should keep the original `Locale` info which is make the change a little bit complex, furthermore, currently, we always need `Locale.ENGLISH` in all of testCase, so, I think the change is fine. But I am fine, if you really want to do it, which make the code looks pretty complete. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #743: [IOTDB-421]fix that selected seq files for merge are not sorted
qiaojialin merged pull request #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] liutaohua opened a new pull request #744: fix some bug of new_series_reader
liutaohua opened a new pull request #744: fix some bug of new_series_reader URL: https://github.com/apache/incubator-iotdb/pull/744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574518684 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [40 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [0.5% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574529457 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [43 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [1.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted
sonarcloud[bot] commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743#issuecomment-574522175 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted
sonarcloud[bot] removed a comment on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743#issuecomment-574483663 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574518684 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [40 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [0.5% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574502082 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [52 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [20.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #742: [IOTDB-422]close files before merge
qiaojialin merged pull request #742: [IOTDB-422]close files before merge URL: https://github.com/apache/incubator-iotdb/pull/742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #738: [IOTDB-396] New query clause: disable align
qiaojialin merged pull request #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574502082 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [52 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [20.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574462427 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [20.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted
sonarcloud[bot] removed a comment on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743#issuecomment-574476411 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted
sonarcloud[bot] commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743#issuecomment-574483663 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb-website] qiaojialin merged pull request #50: Update contributor page
qiaojialin merged pull request #50: Update contributor page URL: https://github.com/apache/incubator-iotdb-website/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574465051 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574479916 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted
sonarcloud[bot] commented on issue #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743#issuecomment-574476411 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=743=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=743=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 opened a new pull request #743: [IOTDB-421]fix that selected seq files for merge are not sorted
jt2594838 opened a new pull request #743: [IOTDB-421]fix that selected seq files for merge are not sorted URL: https://github.com/apache/incubator-iotdb/pull/743 Because the current MergeFileSelector select merge files by unseq files if the unseq files overlap seq files in a reverted order, the selected seq files will be out of order. Example: 1. write a seq file A, which ranges [10, 20] 2. write a seq file B, which ranges [20, 30] 3. write an unseq file C, which ranges [20, 30] 4. write an unseq file D, which ranges [10, 20] C overlaps B and D overlaps and because C is generated before D, as a result, the selected seq files will be [B, A] instead of [A, B], which will make the following merge process write data into a wrong file. To resolve this, the selected seq files are reordered before starting the actual merge task. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574465051 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574180330 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [43.5% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574169987 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [21.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sunjincheng121 edited a comment on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
sunjincheng121 edited a comment on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format(). URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574455347 @jixuan1989 @JulianFeinauer Does this PR make sense to you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574155814 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [46.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574180330 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [43.5% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574140038 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [21.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574169987 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [21.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on issue #738: [IOTDB-396] New query clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574168364
CodeA does not encounter any concurrent correctness while CodeB does, so it
is reasonable to believe the usage of primitives is safe.
CodeA:
```
public static void main(String[] args) throws InterruptedException {
int[] ints = new int[100];
ExecutorService executorService = Executors.newFixedThreadPool(10);
for (int i = 0; i < 100; i++) {
executorService.submit(new TestRunnable(i, executorService, ints));
}
Thread.sleep(1);
executorService.shutdownNow();
for (int anInt : ints) {
System.out.println(anInt);
}
}
static class TestRunnable implements Runnable {
int i;
volatile int remain = 100;
ExecutorService service;
int[] ints;
public TestRunnable(int i, ExecutorService service, int[] ints) {
this.i = i;
this.service = service;
this.ints = ints;
}
@Override
public void run() {
ints[i] ++;
remain --;
if (remain > 0) {
service.submit(this);
}
}
}
```
CodeB:
```
public static void main(String[] args) throws InterruptedException {
int[] ints = new int[100];
ExecutorService executorService = Executors.newFixedThreadPool(10);
for (int i = 0; i < 100; i++) {
executorService.submit(new TestRunnable(i, executorService, ints));
}
Thread.sleep(1);
executorService.shutdownNow();
for (int anInt : ints) {
System.out.println(anInt);
}
}
static class TestRunnable implements Runnable {
int i;
volatile int remain = 100;
ExecutorService service;
int[] ints;
public TestRunnable(int i, ExecutorService service, int[] ints) {
this.i = i;
this.service = service;
this.ints = ints;
}
@Override
public void run() {
ints[0] ++;
remain --;
if (remain > 0) {
service.submit(this);
}
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 edited a comment on issue #738: [IOTDB-396] New query clause: disable align
jt2594838 edited a comment on issue #738: [IOTDB-396] New query clause: disable
align
URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574168364
CodeA does not encounter any concurrent correctness problem while CodeB
does, so it is reasonable to believe the usage of primitives is safe.
CodeA:
```
public static void main(String[] args) throws InterruptedException {
int[] ints = new int[100];
ExecutorService executorService = Executors.newFixedThreadPool(10);
for (int i = 0; i < 100; i++) {
executorService.submit(new TestRunnable(i, executorService, ints));
}
Thread.sleep(1);
executorService.shutdownNow();
for (int anInt : ints) {
System.out.println(anInt);
}
}
static class TestRunnable implements Runnable {
int i;
volatile int remain = 100;
ExecutorService service;
int[] ints;
public TestRunnable(int i, ExecutorService service, int[] ints) {
this.i = i;
this.service = service;
this.ints = ints;
}
@Override
public void run() {
ints[i] ++;
remain --;
if (remain > 0) {
service.submit(this);
}
}
}
```
CodeB:
```
public static void main(String[] args) throws InterruptedException {
int[] ints = new int[100];
ExecutorService executorService = Executors.newFixedThreadPool(10);
for (int i = 0; i < 100; i++) {
executorService.submit(new TestRunnable(i, executorService, ints));
}
Thread.sleep(1);
executorService.shutdownNow();
for (int anInt : ints) {
System.out.println(anInt);
}
}
static class TestRunnable implements Runnable {
int i;
volatile int remain = 100;
ExecutorService service;
int[] ints;
public TestRunnable(int i, ExecutorService service, int[] ints) {
this.i = i;
this.service = service;
this.ints = ints;
}
@Override
public void run() {
ints[0] ++;
remain --;
if (remain > 0) {
service.submit(this);
}
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #742: [IOTDB-422]close files before merge
sonarcloud[bot] commented on issue #742: [IOTDB-422]close files before merge URL: https://github.com/apache/incubator-iotdb/pull/742#issuecomment-574167903 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=742=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=742) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=742=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=742=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #741: [IOTDB-421] Fix merge problem
jt2594838 commented on issue #741: [IOTDB-421] Fix merge problem URL: https://github.com/apache/incubator-iotdb/pull/741#issuecomment-574166472 It is okay, but it seems you are trying to bypassing this problem instead of solving it directly. Please also dig out the root fo this bug, or someone may have to one day. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 opened a new pull request #742: [IOTDB-422]close files before merge
jt2594838 opened a new pull request #742: [IOTDB-422]close files before merge URL: https://github.com/apache/incubator-iotdb/pull/742 If some unseq file overlaps the unsealed seq file and a merge is triggered, the overlapped data may not be able to be merged into the right file. To resolve this, the files should be closed before a merge starts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366325254
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
+ private int fetchSize;
+ private boolean emptyResultSet = false;
+
+ private TSQueryNonAlignDataSet tsQueryNonAlignDataSet = null;
+ private byte[][] times; // used for disable align
+ private byte[][] values; // used to cache the current row record value
+
+ private long sessionId;
+ private long queryId;
+ private boolean ignoreTimeStamp = false;
+
+ public IoTDBNonAlignQueryResultSet() {
+// do nothing
+ }
+
+ // for disable align clause
+ public IoTDBNonAlignQueryResultSet(Statement statement, List
columnNameList,
+ List columnTypeList, boolean
ignoreTimeStamp, TSIService.Iface client,
+ String sql, long queryId, long sessionId,
TSQueryNonAlignDataSet dataset)
+ throws SQLException {
+this.statement = statement;
+this.fetchSize = statement.getFetchSize();
+this.columnTypeList = columnTypeList;
+
+times = new byte[columnNameList.size()][Long.BYTES];
+values = new byte[columnNameList.size()][];
+
+this.columnInfoList = new ArrayList<>();
+// deduplicate and map
+this.columnInfoMap = new HashMap<>();
+this.columnInfoMap.put(TIMESTAMP_STR, 1);
+this.columnTypeDeduplicatedList = new ArrayList<>();
+int index = START_INDEX;
+for (int i = 0; i < columnNameList.size(); i++) {
+ String name = columnNameList.get(i);
+ columnInfoList.add(TIMESTAMP_STR + name);
+ columnInfoList.add(name);
+ if (!columnInfoMap.containsKey(name)) {
+columnInfoMap.put(name, index++);
+columnTypeDeduplicatedList.add(columnTypeList.get(i));
+ }
+}
+
+this.ignoreTimeStamp = ignoreTimeStamp;
+this.client = client;
+this.sql = sql;
+this.queryId = queryId;
+this.tsQueryNonAlignDataSet = dataset;
+this.sessionId = sessionId;
+ }
+
+ @Override
+ public boolean isWrapperFor(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public T unwrap(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public boolean absolute(int arg0) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public void afterLast() throws SQLException {
+throw new
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366325171
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366325201
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366325149
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366322162
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
+ private int fetchSize;
+ private boolean emptyResultSet = false;
+
+ private TSQueryNonAlignDataSet tsQueryNonAlignDataSet = null;
+ private byte[][] times; // used for disable align
+ private byte[][] values; // used to cache the current row record value
+
+ private long sessionId;
+ private long queryId;
+ private boolean ignoreTimeStamp = false;
+
+ public IoTDBNonAlignQueryResultSet() {
+// do nothing
+ }
+
+ // for disable align clause
+ public IoTDBNonAlignQueryResultSet(Statement statement, List
columnNameList,
+ List columnTypeList, boolean
ignoreTimeStamp, TSIService.Iface client,
+ String sql, long queryId, long sessionId,
TSQueryNonAlignDataSet dataset)
+ throws SQLException {
+this.statement = statement;
+this.fetchSize = statement.getFetchSize();
+this.columnTypeList = columnTypeList;
+
+times = new byte[columnNameList.size()][Long.BYTES];
+values = new byte[columnNameList.size()][];
+
+this.columnInfoList = new ArrayList<>();
+// deduplicate and map
+this.columnInfoMap = new HashMap<>();
+this.columnInfoMap.put(TIMESTAMP_STR, 1);
+this.columnTypeDeduplicatedList = new ArrayList<>();
+int index = START_INDEX;
+for (int i = 0; i < columnNameList.size(); i++) {
+ String name = columnNameList.get(i);
+ columnInfoList.add(TIMESTAMP_STR + name);
+ columnInfoList.add(name);
+ if (!columnInfoMap.containsKey(name)) {
+columnInfoMap.put(name, index++);
+columnTypeDeduplicatedList.add(columnTypeList.get(i));
+ }
+}
+
+this.ignoreTimeStamp = ignoreTimeStamp;
+this.client = client;
+this.sql = sql;
+this.queryId = queryId;
+this.tsQueryNonAlignDataSet = dataset;
+this.sessionId = sessionId;
+ }
+
+ @Override
+ public boolean isWrapperFor(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public T unwrap(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public boolean absolute(int arg0) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public void afterLast() throws SQLException {
+throw new
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366322285
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
+private int index;
+
+
+public ReadTask(ManagedSeriesReader reader,
+BlockingQueue> blockingQueue,
+WatermarkEncoder encoder, NonAlignEngineDataSet dataSet,
int index) {
+ this.reader = reader;
+ this.blockingQueue = blockingQueue;
+ this.encoder = encoder;
+ this.dataSet = dataSet;
+ this.index = index;
+}
+
+@Override
+public void run() {
+ PublicBAOS timeBAOS = new PublicBAOS();
+ PublicBAOS valueBAOS = new PublicBAOS();
+ try {
+synchronized (reader) {
+ // if the task is submitted, there must be free space in the queue
+ // so here we don't need to check whether the queue has free space
+ // the reader has next batch
+ if ((dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ || reader.hasNextBatch()) {
+BatchData batchData;
+if (dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ batchData = dataSet.cachedBatchData[index];
+else
+ batchData = reader.nextBatch();
+
+int rowCount = 0;
+while (rowCount < dataSet.fetchSize) {
+
+ if ((dataSet.limit > 0 &&
dataSet.alreadyReturnedRowNumArray.get(index) >= dataSet.limit)) {
+break;
+ }
+
+ if (batchData != null && batchData.hasCurrent()) {
+if (dataSet.offsetArray.get(index) == 0) {
+ long time = batchData.currentTime();
+ ReadWriteIOUtils.write(time, timeBAOS);
+ TSDataType type = batchData.getDataType();
+ switch (type) {
+case INT32:
+ int intValue = batchData.getInt();
+ if (encoder != null && encoder.needEncode(time)) {
+intValue = encoder.encodeInt(intValue, time);
+ }
+ ReadWriteIOUtils.write(intValue, valueBAOS);
+ break;
+case INT64:
+ long longValue = batchData.getLong();
+ if (encoder != null && encoder.needEncode(time)) {
+longValue = encoder.encodeLong(longValue, time);
+ }
+
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366322249
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366322207
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
+private int index;
+
+
+public ReadTask(ManagedSeriesReader reader,
+BlockingQueue> blockingQueue,
+WatermarkEncoder encoder, NonAlignEngineDataSet dataSet,
int index) {
+ this.reader = reader;
+ this.blockingQueue = blockingQueue;
+ this.encoder = encoder;
+ this.dataSet = dataSet;
+ this.index = index;
+}
+
+@Override
+public void run() {
+ PublicBAOS timeBAOS = new PublicBAOS();
+ PublicBAOS valueBAOS = new PublicBAOS();
+ try {
+synchronized (reader) {
+ // if the task is submitted, there must be free space in the queue
+ // so here we don't need to check whether the queue has free space
+ // the reader has next batch
+ if ((dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ || reader.hasNextBatch()) {
+BatchData batchData;
+if (dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ batchData = dataSet.cachedBatchData[index];
+else
+ batchData = reader.nextBatch();
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] SilverNarcissus opened a new pull request #741: [IOTDB-421] Fix merge problem
SilverNarcissus opened a new pull request #741: [IOTDB-421] Fix merge problem URL: https://github.com/apache/incubator-iotdb/pull/741 After dividing storage groups by time partition, merge part contains a potential bug about merging different partition's data into one partition. So I change the logic of merge and only merge the data from the same time partition This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574155814 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [46.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] removed a comment on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574130028 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [46.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 closed pull request #740: [IOTDB-422] Close files before merge
jt2594838 closed pull request #740: [IOTDB-422] Close files before merge URL: https://github.com/apache/incubator-iotdb/pull/740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 opened a new pull request #740: [IOTDB-422] Close files before merge
jt2594838 opened a new pull request #740: [IOTDB-422] Close files before merge URL: https://github.com/apache/incubator-iotdb/pull/740 If some unseq file overlaps the unsealed seq file and a merge is triggered, the overlapped data may not be able to be merged into the right file. To resolve this, the files should be closed before a merge starts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] removed a comment on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574092280 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [21.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574140038 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [21.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366273177
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
+ private int fetchSize;
+ private boolean emptyResultSet = false;
+
+ private TSQueryNonAlignDataSet tsQueryNonAlignDataSet = null;
+ private byte[][] times; // used for disable align
+ private byte[][] values; // used to cache the current row record value
+
+ private long sessionId;
+ private long queryId;
+ private boolean ignoreTimeStamp = false;
+
+ public IoTDBNonAlignQueryResultSet() {
+// do nothing
+ }
+
+ // for disable align clause
+ public IoTDBNonAlignQueryResultSet(Statement statement, List
columnNameList,
+ List columnTypeList, boolean
ignoreTimeStamp, TSIService.Iface client,
+ String sql, long queryId, long sessionId,
TSQueryNonAlignDataSet dataset)
+ throws SQLException {
+this.statement = statement;
+this.fetchSize = statement.getFetchSize();
+this.columnTypeList = columnTypeList;
+
+times = new byte[columnNameList.size()][Long.BYTES];
+values = new byte[columnNameList.size()][];
+
+this.columnInfoList = new ArrayList<>();
+// deduplicate and map
+this.columnInfoMap = new HashMap<>();
+this.columnInfoMap.put(TIMESTAMP_STR, 1);
+this.columnTypeDeduplicatedList = new ArrayList<>();
+int index = START_INDEX;
+for (int i = 0; i < columnNameList.size(); i++) {
+ String name = columnNameList.get(i);
+ columnInfoList.add(TIMESTAMP_STR + name);
+ columnInfoList.add(name);
+ if (!columnInfoMap.containsKey(name)) {
+columnInfoMap.put(name, index++);
+columnTypeDeduplicatedList.add(columnTypeList.get(i));
+ }
+}
+
+this.ignoreTimeStamp = ignoreTimeStamp;
+this.client = client;
+this.sql = sql;
+this.queryId = queryId;
+this.tsQueryNonAlignDataSet = dataset;
+this.sessionId = sessionId;
+ }
+
+ @Override
+ public boolean isWrapperFor(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public T unwrap(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public boolean absolute(int arg0) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public void afterLast() throws SQLException {
+throw new
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366224122 ## File path: example/jdbc/src/main/java/org/apache/iotdb/JDBCExample.java ## @@ -1,21 +1,3 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ package org.apache.iotdb; Review comment: Why remove the license？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366227391
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
Review comment:
It would be more clear to call it "columnBufferPositionMap" or
"columnOrdinalMap" or something else.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366295291
##
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##
@@ -802,23 +781,44 @@ public TSFetchResultsResp fetchResults(TSFetchResultsReq
req) {
if (!queryId2DataSet.containsKey(req.queryId)) {
return getTSFetchResultsResp(
-getStatus(TSStatusCode.EXECUTE_STATEMENT_ERROR, "Has not executed
query"));
+getStatus(TSStatusCode.EXECUTE_STATEMENT_ERROR, "Has not
executed query"));
}
QueryDataSet queryDataSet = queryId2DataSet.get(req.queryId);
- TSQueryDataSet result = fillRpcReturnData(req.fetchSize, queryDataSet,
- sessionIdUsernameMap.get(req.sessionId));
-
- boolean hasResultSet = result.bufferForTime().limit() != 0;
- if (!hasResultSet) {
-queryId2DataSet.remove(req.queryId);
+ if (req.isAlign) {
+TSQueryDataSet result = fillRpcReturnData(req.fetchSize, queryDataSet,
+sessionIdUsernameMap.get(req.sessionId));
+boolean hasResultSet = result.bufferForTime().limit() != 0;
+if (!hasResultSet) {
+ queryId2DataSet.remove(req.queryId);
Review comment:
It may be better to also end this query in case anyone forgets to close the
resultset.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366219463
##
File path: client/src/main/java/org/apache/iotdb/client/AbstractClient.java
##
@@ -297,13 +324,24 @@ private static void printColumnData(ResultSetMetaData
resultSetMetaData, ResultS
printf(formatValue, "null");
handleException(e);
}
-} else {
+}
+else if (align) {
if (i == 2 &&
resultSetMetaData.getColumnName(2).equals(GROUPBY_DEVICE_COLUMN_NAME)) {
printf("%" + deviceColumnLength + "s|", res.getString(i));
} else {
printf(formatValue, res.getString(i));
}
}
+// for disable align clause
+else {
+ if (res.getString(i * 2 - 2) == null) {
Review comment:
These "2"s appear frequently, I suggest replace them with a constant and add
a comment for the constant to explain what column is skipped.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366229362
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
+ private int fetchSize;
+ private boolean emptyResultSet = false;
+
+ private TSQueryNonAlignDataSet tsQueryNonAlignDataSet = null;
+ private byte[][] times; // used for disable align
+ private byte[][] values; // used to cache the current row record value
+
+ private long sessionId;
+ private long queryId;
+ private boolean ignoreTimeStamp = false;
+
+ public IoTDBNonAlignQueryResultSet() {
+// do nothing
+ }
+
+ // for disable align clause
+ public IoTDBNonAlignQueryResultSet(Statement statement, List
columnNameList,
+ List columnTypeList, boolean
ignoreTimeStamp, TSIService.Iface client,
+ String sql, long queryId, long sessionId,
TSQueryNonAlignDataSet dataset)
+ throws SQLException {
+this.statement = statement;
+this.fetchSize = statement.getFetchSize();
+this.columnTypeList = columnTypeList;
+
+times = new byte[columnNameList.size()][Long.BYTES];
+values = new byte[columnNameList.size()][];
+
+this.columnInfoList = new ArrayList<>();
+// deduplicate and map
+this.columnInfoMap = new HashMap<>();
+this.columnInfoMap.put(TIMESTAMP_STR, 1);
+this.columnTypeDeduplicatedList = new ArrayList<>();
+int index = START_INDEX;
+for (int i = 0; i < columnNameList.size(); i++) {
+ String name = columnNameList.get(i);
+ columnInfoList.add(TIMESTAMP_STR + name);
+ columnInfoList.add(name);
+ if (!columnInfoMap.containsKey(name)) {
+columnInfoMap.put(name, index++);
+columnTypeDeduplicatedList.add(columnTypeList.get(i));
+ }
+}
+
+this.ignoreTimeStamp = ignoreTimeStamp;
+this.client = client;
+this.sql = sql;
+this.queryId = queryId;
+this.tsQueryNonAlignDataSet = dataset;
+this.sessionId = sessionId;
+ }
+
+ @Override
+ public boolean isWrapperFor(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public T unwrap(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public boolean absolute(int arg0) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public void afterLast() throws SQLException {
+throw new
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366289729
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
+private int index;
+
+
+public ReadTask(ManagedSeriesReader reader,
+BlockingQueue> blockingQueue,
+WatermarkEncoder encoder, NonAlignEngineDataSet dataSet,
int index) {
+ this.reader = reader;
+ this.blockingQueue = blockingQueue;
+ this.encoder = encoder;
+ this.dataSet = dataSet;
+ this.index = index;
+}
+
+@Override
+public void run() {
+ PublicBAOS timeBAOS = new PublicBAOS();
+ PublicBAOS valueBAOS = new PublicBAOS();
+ try {
+synchronized (reader) {
+ // if the task is submitted, there must be free space in the queue
+ // so here we don't need to check whether the queue has free space
+ // the reader has next batch
+ if ((dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ || reader.hasNextBatch()) {
+BatchData batchData;
+if (dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ batchData = dataSet.cachedBatchData[index];
+else
+ batchData = reader.nextBatch();
+
+int rowCount = 0;
+while (rowCount < dataSet.fetchSize) {
+
+ if ((dataSet.limit > 0 &&
dataSet.alreadyReturnedRowNumArray.get(index) >= dataSet.limit)) {
+break;
+ }
+
+ if (batchData != null && batchData.hasCurrent()) {
+if (dataSet.offsetArray.get(index) == 0) {
+ long time = batchData.currentTime();
+ ReadWriteIOUtils.write(time, timeBAOS);
+ TSDataType type = batchData.getDataType();
+ switch (type) {
+case INT32:
+ int intValue = batchData.getInt();
+ if (encoder != null && encoder.needEncode(time)) {
+intValue = encoder.encodeInt(intValue, time);
+ }
+ ReadWriteIOUtils.write(intValue, valueBAOS);
+ break;
+case INT64:
+ long longValue = batchData.getLong();
+ if (encoder != null && encoder.needEncode(time)) {
+longValue = encoder.encodeLong(longValue, time);
+ }
+
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366225892
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
Review comment:
It would be better if you just make it a List of TsDataType, it is
unnecessary to convert a string to TsDataType every time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366266157
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
+ private List columnTypeList; // no deduplication
+ private Map columnInfoMap; // used because the server
returns deduplicated columns
+ private List columnTypeDeduplicatedList; // deduplicated from
columnTypeList
+ private int fetchSize;
+ private boolean emptyResultSet = false;
+
+ private TSQueryNonAlignDataSet tsQueryNonAlignDataSet = null;
+ private byte[][] times; // used for disable align
+ private byte[][] values; // used to cache the current row record value
+
+ private long sessionId;
+ private long queryId;
+ private boolean ignoreTimeStamp = false;
+
+ public IoTDBNonAlignQueryResultSet() {
+// do nothing
+ }
+
+ // for disable align clause
+ public IoTDBNonAlignQueryResultSet(Statement statement, List
columnNameList,
+ List columnTypeList, boolean
ignoreTimeStamp, TSIService.Iface client,
+ String sql, long queryId, long sessionId,
TSQueryNonAlignDataSet dataset)
+ throws SQLException {
+this.statement = statement;
+this.fetchSize = statement.getFetchSize();
+this.columnTypeList = columnTypeList;
+
+times = new byte[columnNameList.size()][Long.BYTES];
+values = new byte[columnNameList.size()][];
+
+this.columnInfoList = new ArrayList<>();
+// deduplicate and map
+this.columnInfoMap = new HashMap<>();
+this.columnInfoMap.put(TIMESTAMP_STR, 1);
+this.columnTypeDeduplicatedList = new ArrayList<>();
+int index = START_INDEX;
+for (int i = 0; i < columnNameList.size(); i++) {
+ String name = columnNameList.get(i);
+ columnInfoList.add(TIMESTAMP_STR + name);
+ columnInfoList.add(name);
+ if (!columnInfoMap.containsKey(name)) {
+columnInfoMap.put(name, index++);
+columnTypeDeduplicatedList.add(columnTypeList.get(i));
+ }
+}
+
+this.ignoreTimeStamp = ignoreTimeStamp;
+this.client = client;
+this.sql = sql;
+this.queryId = queryId;
+this.tsQueryNonAlignDataSet = dataset;
+this.sessionId = sessionId;
+ }
+
+ @Override
+ public boolean isWrapperFor(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public T unwrap(Class iface) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public boolean absolute(int arg0) throws SQLException {
+throw new SQLException(Constant.METHOD_NOT_SUPPORTED);
+ }
+
+ @Override
+ public void afterLast() throws SQLException {
+throw new
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366280738
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
+private int index;
+
+
+public ReadTask(ManagedSeriesReader reader,
+BlockingQueue> blockingQueue,
+WatermarkEncoder encoder, NonAlignEngineDataSet dataSet,
int index) {
+ this.reader = reader;
+ this.blockingQueue = blockingQueue;
+ this.encoder = encoder;
+ this.dataSet = dataSet;
+ this.index = index;
+}
+
+@Override
+public void run() {
+ PublicBAOS timeBAOS = new PublicBAOS();
+ PublicBAOS valueBAOS = new PublicBAOS();
+ try {
+synchronized (reader) {
+ // if the task is submitted, there must be free space in the queue
+ // so here we don't need to check whether the queue has free space
+ // the reader has next batch
+ if ((dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ || reader.hasNextBatch()) {
+BatchData batchData;
+if (dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ batchData = dataSet.cachedBatchData[index];
+else
+ batchData = reader.nextBatch();
+
+int rowCount = 0;
+while (rowCount < dataSet.fetchSize) {
+
+ if ((dataSet.limit > 0 &&
dataSet.alreadyReturnedRowNumArray.get(index) >= dataSet.limit)) {
+break;
+ }
+
+ if (batchData != null && batchData.hasCurrent()) {
+if (dataSet.offsetArray.get(index) == 0) {
+ long time = batchData.currentTime();
+ ReadWriteIOUtils.write(time, timeBAOS);
+ TSDataType type = batchData.getDataType();
+ switch (type) {
+case INT32:
+ int intValue = batchData.getInt();
+ if (encoder != null && encoder.needEncode(time)) {
+intValue = encoder.encodeInt(intValue, time);
+ }
+ ReadWriteIOUtils.write(intValue, valueBAOS);
+ break;
+case INT64:
+ long longValue = batchData.getLong();
+ if (encoder != null && encoder.needEncode(time)) {
+longValue = encoder.encodeLong(longValue, time);
+ }
+
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366276562
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
+private int index;
+
+
+public ReadTask(ManagedSeriesReader reader,
+BlockingQueue> blockingQueue,
+WatermarkEncoder encoder, NonAlignEngineDataSet dataSet,
int index) {
+ this.reader = reader;
+ this.blockingQueue = blockingQueue;
+ this.encoder = encoder;
+ this.dataSet = dataSet;
+ this.index = index;
+}
+
+@Override
+public void run() {
+ PublicBAOS timeBAOS = new PublicBAOS();
+ PublicBAOS valueBAOS = new PublicBAOS();
+ try {
+synchronized (reader) {
+ // if the task is submitted, there must be free space in the queue
+ // so here we don't need to check whether the queue has free space
+ // the reader has next batch
+ if ((dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ || reader.hasNextBatch()) {
+BatchData batchData;
+if (dataSet.cachedBatchData[index] != null &&
dataSet.cachedBatchData[index].hasCurrent())
+ batchData = dataSet.cachedBatchData[index];
+else
+ batchData = reader.nextBatch();
Review comment:
Always use "{}" for code blocks (even if it only contains a single line), as
we obey the google code-style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366279675
##
File path:
server/src/main/java/org/apache/iotdb/db/query/dataset/NonAlignEngineDataSet.java
##
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.query.dataset;
+
+import org.apache.iotdb.db.query.pool.QueryTaskPoolManager;
+import org.apache.iotdb.db.query.reader.ManagedSeriesReader;
+import org.apache.iotdb.db.tools.watermark.WatermarkEncoder;
+import org.apache.iotdb.service.rpc.thrift.TSQueryNonAlignDataSet;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.common.BatchData;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.common.RowRecord;
+import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet;
+import org.apache.iotdb.tsfile.utils.Pair;
+import org.apache.iotdb.tsfile.utils.PublicBAOS;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.atomic.AtomicIntegerArray;
+
+public class NonAlignEngineDataSet extends QueryDataSet {
+
+ private static class ReadTask implements Runnable {
+
+private final ManagedSeriesReader reader;
+private BlockingQueue> blockingQueue;
+private WatermarkEncoder encoder;
+NonAlignEngineDataSet dataSet;
Review comment:
This field is not necessary if you make ReadTask a non-static class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366226547
##
File path:
jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java
##
@@ -0,0 +1,1289 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc;
+
+import org.apache.iotdb.rpc.IoTDBRPCException;
+import org.apache.iotdb.rpc.RpcUtils;
+import org.apache.iotdb.service.rpc.thrift.*;
+import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.utils.BytesUtils;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+import org.apache.thrift.TException;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.net.URL;
+import java.nio.ByteBuffer;
+import java.sql.Date;
+import java.sql.*;
+import java.util.*;
+
+public class IoTDBNonAlignQueryResultSet implements ResultSet {
+
+ private static final String TIMESTAMP_STR = "Time";
+ private static final int TIMESTAMP_STR_LENGTH = 4;
+ private static final int START_INDEX = 2;
+ private static final String VALUE_IS_NULL = "The value got by %s (column
name) is NULL.";
+ private static final String EMPTY_STR = "";
+ private Statement statement = null;
+ private String sql;
+ private SQLWarning warningChain = null;
+ private boolean isClosed = false;
+ private TSIService.Iface client = null;
+ private List columnInfoList; // no deduplication
Review comment:
"Info" is too ambiguous, just call it "columnName".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query
clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366224728
##
File path: example/jdbc/src/main/java/org/apache/iotdb/JDBCExample.java
##
@@ -31,23 +13,11 @@ public static void main(String[] args) throws
ClassNotFoundException, SQLExcepti
Class.forName("org.apache.iotdb.jdbc.IoTDBDriver");
try (Connection connection =
DriverManager.getConnection("jdbc:iotdb://127.0.0.1:6667/", "root", "root");
Statement statement = connection.createStatement()) {
- statement.execute("SET STORAGE GROUP TO root.sg1");
- statement.execute("CREATE TIMESERIES root.sg1.d1.s1 WITH DATATYPE=INT64,
ENCODING=RLE");
- statement.execute("CREATE TIMESERIES root.sg1.d1.s2 WITH DATATYPE=INT64,
ENCODING=RLE");
- statement.execute("CREATE TIMESERIES root.sg1.d1.s3 WITH DATATYPE=INT64,
ENCODING=RLE");
-
- for (int i = 0; i <= 100; i++) {
-statement.addBatch("insert into root.sg1.d1(timestamp, s1, s2, s3)
values("+ i + "," + 1 + "," + 1 + "," + 1 + ")");
- }
- statement.executeBatch();
- statement.clearBatch();
-
- ResultSet resultSet = statement.executeQuery("select * from root where
time <= 10");
- outputResult(resultSet);
- resultSet = statement.executeQuery("select count(*) from root");
- outputResult(resultSet);
- resultSet = statement.executeQuery("select count(*) from root where time
>= 1 and time <= 100 group by ([0, 100], 20ms, 20ms)");
+ long startTime = System.currentTimeMillis();
+ ResultSet resultSet = statement.executeQuery("select * from root where
time < 1 disable align");
outputResult(resultSet);
+ long endTime = System.currentTimeMillis();
+ System.out.println("Cost Time: " + (endTime - startTime));
Review comment:
I don't think you should remove the old examples unless they are incorrect,
you should only add the new ones.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align
jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366296983 ## File path: service-rpc/rpc-changelist.md ## @@ -107,9 +107,11 @@ Last Updated on November 12th, 2019 by Tian Jiang. | Latest Changes | Related Committers | | | -- | | Add parameter sessionId in getTimeZone, getProperties, setStorageGroup, createTimeseries... | Tian Jiang| +| Add struct TSQueryNonAlignDataSet| Haonan Hou| ## 3. Update | Latest Changes | Related Committers | | | -- | -| Replace TS_SessionHandles with SessionIds, TSOperationHandle with queryIds | Tian Jiang | \ No newline at end of file +| Replace TS_SessionHandles with SessionIds, TSOperationHandle with queryIds | Tian Jiang | +| Add optional TSQueryNonAlignDataSet in TSExecuteStatementResp, TSFetchResultsResp | Haonan Hou | Review comment: And the field "isAlign". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align
sonarcloud[bot] commented on issue #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#issuecomment-574130028 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=738=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) [46.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=738=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sunjincheng121 opened a new pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format().
sunjincheng121 opened a new pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format(). URL: https://github.com/apache/incubator-iotdb/pull/739 I would like to make the change simple which I mentioned here: https://github.com/apache/incubator-iotdb/pull/726#discussion_r365042005 What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader
sonarcloud[bot] commented on issue #713: [IOTDB-418] New series reader URL: https://github.com/apache/incubator-iotdb/pull/713#issuecomment-574092280 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=713=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) [21.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=713=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 opened a new pull request #738: [IOTDB-396] New query clause: disable align
JackieTien97 opened a new pull request #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] JackieTien97 closed pull request #705: [IOTDB-396] New query clause: disable align
JackieTien97 closed pull request #705: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
