[kudu-CR] KUDU-2237: Allow idle server connection scanning to be disabled

[Michael Ho (Code Review)]

Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8831

to look at the new patch set (#5).

Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
..

KUDU-2237: Allow idle server connection scanning to be disabled

Currently, a server connection being idle for more than
FLAGS_rpc_default_keepalive_time_ms ms will be closed.
However, certain services (e.g. Impala) using KRPC may want to
keep the idle connections alive for various reasons (e.g. sheer
number of connections to re-establish,  negotiation overhead
in a secure cluster). To avoid idle connection from being
closed, one currently have to set FLAGS_rpc_default_keepalive_time_ms
to a very large value.

This change implements a cleaner solution by disabling idle
connection scanning if FLAGS_rpc_default_keepalive_time_ms is
set to 0. This avoids the unnecessary overhead of scanning
for idle server connections and alleviates the user from having
to pick a random large number to make sure the connection is
always kept alive.

Change-Id: I6161b9e753f05620784565a417d248acf8e7050a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
6 files changed, 105 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/8831/5
--
To view, visit http://gerrit.cloudera.org:8080/8831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6161b9e753f05620784565a417d248acf8e7050a
Gerrit-Change-Number: 8831
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2115: remove unnecessary compaction selection check

[Andrew Wong (Code Review)]

Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8859

to look at the new patch set (#2).

Change subject: KUDU-2115: remove unnecessary compaction selection check
..

KUDU-2115: remove unnecessary compaction selection check

Tablets will perform compaction selection on a copy of the currently
available rowsets in order to avoid holding the component_lock_ for the
duration of rowset selection.

It is then verified that nothing else compacted the selected rowsets by
iterating over the selected rowsets and checking that they still exist
to be compacted.

However, the initial selection of rowsets is performed on a snapshotted
copy of the available rowsets, and in between the snapshot of the
rowsets and the verification, the component_lock_ is dropped. As such,
the verification hits false negatives if other threads are able to take
the component_lock_ and modify the available rowsets.

The verification itself is unnecessary, as the correct set of rowsets
would be returned by PickRowSetsToCompact(), even if the verification
were to fail, so I've removed it.

I verified the diagnosis by placing a random sleep just after making the
copy in PickRowSetsToCompact() and seeing
TabletServerDiskFailureTest.TestRandomOpSequence, which schedules many
compactions, fail consistently with the failed verification. Upon making
the fix, this passes.

Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236
---
M src/kudu/tablet/tablet.cc
1 file changed, 0 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8859/2
--
To view, visit http://gerrit.cloudera.org:8080/8859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236
Gerrit-Change-Number: 8859
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2237: Allow idle server connection scanning to be disabled

[Michael Ho (Code Review)]

Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8831

to look at the new patch set (#4).

Change subject: KUDU-2237: Allow idle server connection scanning to be disabled
..

KUDU-2237: Allow idle server connection scanning to be disabled

Currently, a server connection being idle for more than
FLAGS_rpc_default_keepalive_time_ms ms will be closed.
However, certain services (e.g. Impala) using KRPC may want to
keep the idle connections alive for various reasons (e.g. sheer
number of connections to re-establish,  negotiation overhead
in a secure cluster). To avoid idle connection from being
closed, one currently have to set FLAGS_rpc_default_keepalive_time_ms
to a very large value.

This change implements a cleaner solution by disabling idle
connection scanning if FLAGS_rpc_default_keepalive_time_ms is
set to 0. This avoids the unnecessary overhead of scanning
for idle server connections and alleviates the user from having
to pick a random large number to make sure the connection is
always kept alive.

Change-Id: I6161b9e753f05620784565a417d248acf8e7050a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
6 files changed, 104 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/8831/4
--
To view, visit http://gerrit.cloudera.org:8080/8831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6161b9e753f05620784565a417d248acf8e7050a
Gerrit-Change-Number: 8831
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2115: remove unnecessary compaction selection check

[Andrew Wong (Code Review)]

Andrew Wong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8859


Change subject: KUDU-2115: remove unnecessary compaction selection check
..

KUDU-2115: remove unnecessary compaction selection check

Tablets will perform compaction selection on a copy of the currently
available rowsets in order to avoid holding the component_lock_ for the
duration of rowset selection.

It is then verified that nothing else compacted the selected rowsets by
iterating over the selected rowsets and checking that they still exist
to be compacted.

However, the initial selection of rowsets is performed on a snapshotted
copy of the available rowsets, and in between the snapshot of the
rowsets and the verification, the component_lock_ is dropped. As such,
the verification hits false positives when other threads are able to
take the component_lock_ and modify the available rowsets.

This verification failure here is harmless, and the verification itself
so I've taken the block of code for it. Removal of this should be
harmless, as it still maintains the invariant that only things that are
available to be compacted are returned by PickRowSetsToCompact().

I verified the diagnosis by placing a random sleep just after making the
copy in PickRowSetsToCompact() and seeing TestRandomOpSequence, which
schedules many compactions, fail consistently with the failed
verification. Upon making the fix, it passed.

Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236
---
M src/kudu/tablet/tablet.cc
1 file changed, 0 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8859/1
--
To view, visit http://gerrit.cloudera.org:8080/8859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236
Gerrit-Change-Number: 8859
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 

[kudu-CR] [tests] update for 3-4-3 replica management scheme (2/3)

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8857 )

Change subject: [tests] update for 3-4-3 replica management scheme (2/3)
..


Patch Set 3: Verified+1

Unrelated flake due to https://issues.apache.org/jira/browse/KUDU-2115


--
To view, visit http://gerrit.cloudera.org:8080/8857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
Gerrit-Change-Number: 8857
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Sat, 16 Dec 2017 01:18:21 +
Gerrit-HasComments: No

[kudu-CR] [tests] update for 3-4-3 replica management scheme (2/3)

[Alexey Serbin (Code Review)]

Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/8857 )

Change subject: [tests] update for 3-4-3 replica management scheme (2/3)
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
Gerrit-Change-Number: 8857
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] WIP [raft consensus] 3-4-3 replica management by default (0/n)

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8672 
)

Change subject: WIP [raft_consensus] 3-4-3 replica management by default (0/n)
..


Abandoned

Abandoned in favor of https://gerrit.cloudera.org/#/c/885{6,7,8}/
--
To view, visit http://gerrit.cloudera.org:8080/8672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I37cb6b58340f247a675fcba253cb23790009d709
Gerrit-Change-Number: 8672
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] WIP [raft consensus] 3-4-3 replica management by default (2/n)

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8850 
)

Change subject: WIP [raft_consensus] 3-4-3 replica management by default (2/n)
..


Abandoned

Abandoned in favor of https://gerrit.cloudera.org/#/c/88567/
--
To view, visit http://gerrit.cloudera.org:8080/8850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I364f227da539a0fce69a995120d2bb701a891d45
Gerrit-Change-Number: 8850
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] WIP [raft consensus] 3-4-3 replica management by default (3/n)

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8855 
)

Change subject: WIP [raft_consensus] 3-4-3 replica management by default (3/n)
..


Abandoned

Abandoned in favor of https://gerrit.cloudera.org/#/c/8858/
--
To view, visit http://gerrit.cloudera.org:8080/8855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6a8682eb8000d05788dc1f8919e35770399ffabe
Gerrit-Change-Number: 8855
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] WIP [raft consensus] 3-4-3 replica management by default (1/n)

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8819 
)

Change subject: WIP [raft_consensus] 3-4-3 replica management by default (1/n)
..


Abandoned

Abandoned in favor of https://gerrit.cloudera.org/#/c/8856/
--
To view, visit http://gerrit.cloudera.org:8080/8819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaab57f57b4c4466fedd8178682342ec3a49ab261
Gerrit-Change-Number: 8819
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8858

to look at the new patch set (#4).

Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
..

[tests] update for 3-4-3 replica management scheme (3/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DiskFailureITest
  * TabletCopyFailureITest
  * TabletCopyITest
  * TsTabletManagerITest

Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/4
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8858

to look at the new patch set (#3).

Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
..

[tests] update for 3-4-3 replica management scheme (3/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DiskFailureITest
  * TabletCopyFailureITest
  * TabletCopyITest
  * TsTabletManagerITest

Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/3
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8856

to look at the new patch set (#3).

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
..

[tests] update for 3-4-3 replica management scheme (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/3
--
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] update for 3-4-3 replica management scheme (2/3)

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8857

to look at the new patch set (#3).

Change subject: [tests] update for 3-4-3 replica management scheme (2/3)
..

[tests] update for 3-4-3 replica management scheme (2/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DeleteTableITest
  * RaftConsensusFailureDetectorIMCTest
  * TabletReplacementITest
  * AdminCliTest

Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
---
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 333 insertions(+), 171 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/8857/3
--
To view, visit http://gerrit.cloudera.org:8080/8857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
Gerrit-Change-Number: 8857
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8858

to look at the new patch set (#2).

Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
..

[tests] update for 3-4-3 replica management scheme (3/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DiskFailureITest
  * TabletCopyFailureITest
  * TabletCopyITest
  * TsTabletManagerITest

Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/2
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8858


Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
..

[tests] update for 3-4-3 replica management scheme (3/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DiskFailureITest
  * TabletCopyFailureITest
  * TabletCopyITest
  * TsTabletManagerITest

Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/1
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] [tests] update for 3-4-3 replica management scheme (2/3)

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8857

to look at the new patch set (#2).

Change subject: [tests] update for 3-4-3 replica management scheme (2/3)
..

[tests] update for 3-4-3 replica management scheme (2/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DeleteTableITest
  * RaftConsensusFailureDetectorIMCTest
  * TabletReplacementITest
  * AdminCliTest

Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
---
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 333 insertions(+), 171 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/8857/2
--
To view, visit http://gerrit.cloudera.org:8080/8857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
Gerrit-Change-Number: 8857
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [raft consensus] 3-4-3 replica management by default (2/3)

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8857


Change subject: WIP [raft_consensus] 3-4-3 replica management by default (2/3)
..

WIP [raft_consensus] 3-4-3 replica management by default (2/3)

Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
  * DeleteTableITest
  * RaftConsensusFailureDetectorIMCTest
  * TabletReplacementITest
  * AdminCliTest

Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
---
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 333 insertions(+), 171 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/8857/1
--
To view, visit http://gerrit.cloudera.org:8080/8857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I618e1b973d7952bc7ec84d36027db8e260cf91e2
Gerrit-Change-Number: 8857
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] [test] update for 3-4-3 replica management scheme (2/3)

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8856

to look at the new patch set (#2).

Change subject: [test] update for 3-4-3 replica management scheme (2/3)
..

[test] update for 3-4-3 replica management scheme (2/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/2
--
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [docs] Add scaling guide

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8842 )

Change subject: [docs] Add scaling guide
..


Patch Set 1:

(17 comments)

This is a great and useful doc. I did a first pass, and while I didn't validate 
the numbers and have various "usability" related comments.

http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc
File docs/scaling.adoc:

http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@1
PS1, Line 1: [[scaling]]
name this file scaling_guide.adoc for SEO reasons


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@2
PS1, Line 2: Scaling
Scaling Guide


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@13
PS1, Line 13:
Add a blurb at the top of this document describing the purpose of the document


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@46
PS1, Line 46: /
nit: missing space before slash


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@57
PS1, Line 57: Memory
Memory Consumption?


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@61
PS1, Line 61: baseline
rough estimate


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@62
PS1, Line 62: limit
approximate memory requirements


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@66
PS1, Line 66: Scaling
Is scaling the right word here?


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@68
PS1, Line 68: Data on disk
"Memory required per TB of data on disk" ?


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@68
PS1, Line 68: /
Here and below, i mentally read this as "divided by" when you mean "per". I 
think we should write out "per" here.


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@95
PS1, Line 95: Verifying a Memory Limit
Verifying if the memory limit is sufficient?


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@129
PS1, Line 129: | File cache | 40% of process maximum | Percentage of maximum 
allowed open fds reserved for use by
can we indicate how this can be tuned?


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@133
PS1, Line 133: /
per


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@150
PS1, Line 150: / cold replica
how about: * 1600 cold replicas


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@151
PS1, Line 151: | 200 hot replicas | 2 / segment * 10 segments/hot replica * 200 
hot replicas + 1 / index * 10 indices / hot replica * 200 hot replicas = 6000 
fds
having a hard time parsing this expression; consider writing it like (2 fds * 
10 segments * 200 hot replicas) + (1 fd * 10 indices * 200 hot replicas) = 6000 
fds

except frankly i'm not sure how you're supposed to know how many WAL indexes 
there are and you might need to state some assumptions here given that we say 
there are 200 hot replicas


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@177
PS1, Line 177: /
nit: per, here and below


http://gerrit.cloudera.org:8080/#/c/8842/1/docs/scaling.adoc@183
PS1, Line 183: /
per



--
To view, visit http://gerrit.cloudera.org:8080/8842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d8999addc41fe0b726342a27dbba199ddf7dd2
Gerrit-Change-Number: 8842
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 15 Dec 2017 23:25:32 +
Gerrit-HasComments: Yes

[kudu-CR] [raft consensus] 3-4-3 replica management by default (1/3)

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8856


Change subject: [raft_consensus] 3-4-3 replica management by default (1/3)
..

[raft_consensus] 3-4-3 replica management by default (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/1
--
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR](gh-pages) site tool: document --no-verify-source flag

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8848 )

Change subject: site_tool: document --no-verify-source flag
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 15 Dec 2017 23:09:37 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) site tool: document --no-verify-source flag

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8848 )

Change subject: site_tool: document --no-verify-source flag
..

site_tool: document --no-verify-source flag

Print that this flag exists in the usage text so that I don't have to
read the source code every time I want to do a static render for testing
and code review purposes.

Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Reviewed-on: http://gerrit.cloudera.org:8080/8848
Reviewed-by: Will Berkeley 
Tested-by: Mike Percy 
---
M site_tool
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Will Berkeley: Looks good to me, approved
  Mike Percy: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [docs] Document how to recover from a majority failed tablet

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8402 )

Change subject: [docs] Document how to recover from a majority failed tablet
..


Patch Set 4:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@709
PS4, Line 709: Reviving a tablet that's lost a majority of replicas
how about: Bringing a tablet that's lost a majority of replicas back online


http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@711
PS4, Line 711: If a tablet has permanently lost a majority of its replicas, it 
cannot recover
It is critical to emphasize that in a majority-lost scenario, permanent data 
loss is likely, and in fact there is no guarantee that any data can be 
recovered. It may only be due to luck that they get some or all of their data 
back after this procedure. We should also emphasize that this procedure should 
only be performed if it is not possible to bring the majority back online.


http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@723
PS4, Line 723:   638a20403e3e4ae3b55d4d07d920e6de (tserver-00:7150): RUNNING 
[LEADER]
This is kind of a cool scenario but this whole thing only works if the leader 
survives. I think it's worth indicating how to handle this when the leader did 
not survive as well and a discussion around the implications of that. Actually, 
if the leader survives, the likelihood of losing data is much lower (although 
not zero, because it could have been an old, partitioned leader in some nasty 
cases)


http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@760
PS4, Line 760: $ kudu remote_replica delete tserver-01:7150 
e822cab6c0584bc0858219d1539a17e6 "delete failed replica"
this is not actually required; the master should do it automatically once they 
get evicted when we do the unsafe config change


http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@767
PS4, Line 767: [source,bash]
 : 
 : $ kudu remote_replica unsafe_change_config  
   ...
 : 
I found this confusing. It seems like a command, I was trying to figure out who 
uuid1 and uuid2 were and why we're changing the config to those two, etc. I 
think we need to pick one of the "prototype" or the "example" for the same 
command. I actually think the prototype (this example) is more useful than the 
one below, except that you indicate a "uuid2" which doesn't apply here.


http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@775
PS4, Line 775: [source,bash]
If you are going to put this in, at least mark it with a label like "Example:"


http://gerrit.cloudera.org:8080/#/c/8402/4/docs/administration.adoc@777
PS4, Line 777: $ kudu remote_replica unsafe_change_config tserver-00:7150 
e822cab6c0584bc0858219d1539a17e6 638a20403e3e4ae3b55d4d07d920e6de
Because having a long UUID for tablet_id and UUID for tablet server id can be 
confusing, and these example uuids are never going to actually be what a user 
would paste in, I think something that is sort of a compromise of what you 
wrote on line 770 and what is here on line 777 would be ideal:

$ kudu remote_replica unsafe_change_config tserver-00:7150  


explaining that tserver-000-uuid would be the tablet server UUID of the 
remaining replica on tserver-00



--
To view, visit http://gerrit.cloudera.org:8080/8402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6326f65d029a1cd75e487b16ce5be4baea2f215
Gerrit-Change-Number: 8402
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 15 Dec 2017 22:46:36 +
Gerrit-HasComments: Yes

[kudu-CR] WIP [raft consensus] 3-4-3 replica management by default (3/n)

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8855


Change subject: WIP [raft_consensus] 3-4-3 replica management by default (3/n)
..

WIP [raft_consensus] 3-4-3 replica management by default (3/n)

Update corresponding scenarios of the following tests after turning
on 3-4-3 replica management by default:
  * DiskFailureITest
  * TabletCopyFailureITest
  * TabletCopyITest
  * TsTabletManagerITest

WIP: need to combine the patches

Change-Id: I6a8682eb8000d05788dc1f8919e35770399ffabe
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 122 insertions(+), 49 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/8855/1
--
To view, visit http://gerrit.cloudera.org:8080/8855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a8682eb8000d05788dc1f8919e35770399ffabe
Gerrit-Change-Number: 8855
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] KUDU-1704: add READ OWN WRITES scan mode

[Hao Hao (Code Review)]

Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8804 )

Change subject: KUDU-1704: add READ_OWN_WRITES scan mode
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto
File src/kudu/common/common.proto:

http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto@228
PS1, Line 228: transactions before it are committed.
 :   //
 :   // Reads in this mode are not repeatable: two stale reads, 
even if they
 :   // provide the same propagated timestamp bound, can execute at 
different
 :   // timestamps and thus return inconsistent results. Ho
> makes sense. shall we preface this patch with that change then.
Yes, will do, thanks!



--
To view, visit http://gerrit.cloudera.org:8080/8804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48
Gerrit-Change-Number: 8804
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 15 Dec 2017 21:43:59 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1704: add READ OWN WRITES scan mode

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8804 )

Change subject: KUDU-1704: add READ_OWN_WRITES scan mode
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto
File src/kudu/common/common.proto:

http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto@228
PS1, Line 228: Boundedly stale reads are not repeatable: two stale reads, even 
if they
 :   // use the same staleness bound, can execute at different 
timestamps and thus
 :   // return inconsistent results. However, it allows 
read-your-writes for each
 :   // client, as the picked timestamp must be higher than the one 
of the last
 :   // write or read, known from the propagated timestamp.
> I would lean to the second option, that stop calling READ_AT_SNAPSHOT witho
makes sense. shall we preface this patch with that change then.
we can make the change in a backward compatible manner by having the old mode 
be transformed to the new mode, while issuing a warning (logged only once).
To be clear, let's add a new mode, READ_CONSISTENT, that is equivalent to the 
current READ_AT_SNAPSHOT with no timestamp and reword whenever we refer to 
repeatable read to mean READ_AT_SNAPSHOT.



--
To view, visit http://gerrit.cloudera.org:8080/8804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48
Gerrit-Change-Number: 8804
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 15 Dec 2017 21:40:07 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) site tool: document --no-verify-source flag

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8848 )

Change subject: site_tool: document --no-verify-source flag
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 15 Dec 2017 18:47:55 +
Gerrit-HasComments: No

[kudu-CR] [docs] Add scaling guide

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8842 )

Change subject: [docs] Add scaling guide
..


Patch Set 1:

Check out https://github.com/wdberkeley/kudu/blob/showdocs/docs/scaling.adoc


--
To view, visit http://gerrit.cloudera.org:8080/8842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38d8999addc41fe0b726342a27dbba199ddf7dd2
Gerrit-Change-Number: 8842
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 15 Dec 2017 18:46:24 +
Gerrit-HasComments: No

[kudu-CR] [docs] Document how to recover from a majority failed tablet

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8402 )

Change subject: [docs] Document how to recover from a majority failed tablet
..


Patch Set 4:

> Mind pushing a rev of this to your personal GitHub so we can read
 > it rendered?

Check out 
https://github.com/wdberkeley/kudu/blob/showdocs/docs/administration.adoc#tablet_majority_down_recovery


--
To view, visit http://gerrit.cloudera.org:8080/8402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6326f65d029a1cd75e487b16ce5be4baea2f215
Gerrit-Change-Number: 8402
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 15 Dec 2017 18:45:51 +
Gerrit-HasComments: No

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

[Grant Henke (Code Review)]

Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8830

to look at the new patch set (#3).

Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)
..

KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

Introduces the Decimal type to the server and
C++ client. Follow on work will enhance the
utility in the client and add support to the
Java client and other integrations and add
documentation.

The decimal type has column type attributes to
support the “parameterized type”. The precision
and scale column type attributes are not stored,
but instead are leveraged to map to a correctly
sized internal type
(DECIMAL32, DECIMAL64, DECIMAL128). These
internal types are represented and stored as
equivalently sized integers.

This also removes the int128 suffixes because they break the
client by using C++11 features. They may be added back in a
different way later.

Change-Id: I3b06142f43c66973f36376bd2c88ca6f8d9f7632
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/value-internal.h
M src/kudu/client/value.cc
M src/kudu/client/value.h
M src/kudu/common/CMakeLists.txt
M src/kudu/common/common.proto
A src/kudu/common/decimal_value.cc
A src/kudu/common/decimal_value.h
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/common/wire_protocol.cc
M src/kudu/consensus/log-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/util/int128-test.cc
M src/kudu/util/int128.h
25 files changed, 636 insertions(+), 139 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/8830/3
--
To view, visit http://gerrit.cloudera.org:8080/8830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3b06142f43c66973f36376bd2c88ca6f8d9f7632
Gerrit-Change-Number: 8830
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot