David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_OWN_WRITES scan mode ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8804/1/src/kudu/common/common.proto@228 PS1, Line 228: Boundedly stale reads are not repeatable: two stale reads, even if they : // use the same staleness bound, can execute at different timestamps and thus : // return inconsistent results. However, it allows read-your-writes for each : // client, as the picked timestamp must be higher than the one of the last : // write or read, known from the propagated timestamp. > I would lean to the second option, that stop calling READ_AT_SNAPSHOT witho makes sense. shall we preface this patch with that change then. we can make the change in a backward compatible manner by having the old mode be transformed to the new mode, while issuing a warning (logged only once). To be clear, let's add a new mode, READ_CONSISTENT, that is equivalent to the current READ_AT_SNAPSHOT with no timestamp and reword whenever we refer to repeatable read to mean READ_AT_SNAPSHOT. -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 15 Dec 2017 21:40:07 +0000 Gerrit-HasComments: Yes