[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.h@356 PS4, Line 356: CHECK_NE(state_, KsckFetchState::UNINITIALIZED); Does state_ reflect all of FetchUnusualFlags, FetchConsensusState, and FetchInfo? It's probably worth documenting its semantics, e.g. if FetchInfo() succeeds but FetchUnusualFlags() hasn't been called, is it still valid to call flags()? Is that an important point to make? Since we don't set the state in FetchUnusualFlags(), it seems a little weird to have this check here. http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.h@356 PS4, Line 356: state_, KsckFetchState::UNINITIALIZED nit: reverse the order of these here and L252 http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.h@485 PS4, Line 485: Check for "unusual" flags on masters. : // "Unusual" flags are ones tagged hidden, experimental, or unsafe. Note only non-default unusual flags. I don't think that's mentioned anywhere except the commit message. http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.cc@298 PS4, Line 298: "Some masters have unsafe, experimental, or hidden flags set")); nit: spacing http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.cc@302 PS4, Line 302: return Status::Incomplete( nit: spacing http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck.cc@436 PS4, Line 436: "Some tablet servers have unsafe, experimental, or hidden flags set")); nit: spacing http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck_remote-test.cc@94 PS4, Line 94: // Add a harmless experimental flag so we can detect it with ksck. : FLAGS_safe_time_max_lag_ms = 6; Can we put this down in TestCheckUnusualFlags? It's kind of weird seeing L244 without seeing this. http://gerrit.cloudera.org:8080/#/c/10061/4/src/kudu/tools/ksck_remote-test.cc@229 PS4, Line 229: ASSERT_OK(ksck_->CheckMasterHealth()); : ASSERT_OK(ksck_->CheckMasterHealth()); : ASSERT_OK(ksck_->CheckMasterUnusualFlags()); : ASSERT_OK(ksck_->CheckMasterConsensus()); : ASSERT_OK(ksck_->CheckClusterRunning()); : ASSERT_OK(ksck_->FetchTableAndTabletInfo()); : ASSERT_OK(ksck_->FetchInfoFromTabletServers()); : ASSERT_OK(ksck_->CheckTabletServerUnusualFlags()); Must all of these be run to pass this test? -- To view, visit http://gerrit.cloudera.org:8080/10061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706 Gerrit-Change-Number: 10061 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 25 May 2018 02:49:24 + Gerrit-HasComments: Yes
[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10061 to look at the new patch set (#4). Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags This adds checks to ksck that look for experimental, unsafe, and hidden flags set to non-default values on Kudu masters and tablet servers. If any are found, ksck generates a table summarizing the different flags and their values. For example: Flag |Value| Tags | Master +-+--+-- codegen_dump_functions | true| runtime,experimental | localhost:7052,localhost:7053 min_compression_ratio | 0.80004 | experimental | localhost:7052,localhost:7051,localhost:7053 safe_time_max_lag_ms | 4 | experimental | localhost:7052 safe_time_max_lag_ms | 5 | experimental | localhost:7053 The table has one row for each unique (flag, value) pair, listing all daemons with --flag=value. So, in the above output, there are two rows for the flag --safe_time_max_lag_ms because it's set to two different values on two masters. This makes it easy to scan for concerning flags and their values. Having unusual flags or failing to gather flags isn't considered an error, since it doesn't indicate the cluster is unhealthy (in the latter case because the daemon may not support the GetFlags RPC). Instead, flag checks surface their results in a new warnings section near the end of the ksck output. Finally, since the output might not scale to a large number of servers, the CSV of servers is abbreviated, by default, to 3 entries, with the number of additional servers indicated. The number of entries before truncation kicks in is controlled by --truncate_server_csv_length. Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h M src/kudu/tools/ksck_results.cc M src/kudu/tools/ksck_results.h 8 files changed, 396 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/10061/4 -- To view, visit http://gerrit.cloudera.org:8080/10061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idd6c179e5256b2f2bae2f7486c5e0365ef184706 Gerrit-Change-Number: 10061 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] WIP: Possible fix for the timeouts
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10468 to look at the new patch set (#2). Change subject: WIP: Possible fix for the timeouts .. WIP: Possible fix for the timeouts Change-Id: I7ae9951927066f574b095d3d3922f477bd71e49c --- M src/kudu/consensus/consensus_queue.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/mini-cluster/internal_mini_cluster.cc M src/kudu/mini-cluster/internal_mini_cluster.h M src/kudu/mini-cluster/mini_cluster.h 8 files changed, 35 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/10468/2 -- To view, visit http://gerrit.cloudera.org:8080/10468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ae9951927066f574b095d3d3922f477bd71e49c Gerrit-Change-Number: 10468 Gerrit-PatchSet: 2 Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10300 to look at the new patch set (#2). Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin .. [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin If ksck is not run as an admin user, then it cannot gather all of the information it uses to do cluster checks. "Not authorized" errors are easy to mistake for other errors. This patch handles these errors specially to make it obvious to administrators when they have forgotten to run as an administrative user. Change-Id: I644957103efefceeba4b82f4557376a603507423 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck_results.cc M src/kudu/tools/ksck_results.h M src/kudu/tools/tool.proto 5 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/10300/2 -- To view, visit http://gerrit.cloudera.org:8080/10300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I644957103efefceeba4b82f4557376a603507423 Gerrit-Change-Number: 10300 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. KUDU-2426 Fix WRONG_SERVER_UUID case in ksck RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since KUDU-2364 to indicate a UUID mismatch. Ksck::FetchInfoFromTabletServers() checked for this Status, and this resulted in any RemoteError showing as a WRONG_SERVER_UUID in the tablet server health list. This commit adds KsckServerHealth output argument to FetchInfo() and FetchConsensusState() which can be used to add further context to a non-OK Status. Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Reviewed-on: http://gerrit.cloudera.org:8080/10293 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong Reviewed-by: Alexey Serbin --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h M src/kudu/tools/ksck_results.cc 7 files changed, 62 insertions(+), 29 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-702 Add block IDs to more log messages
Mike Percy has posted comments on this change. (
http://gerrit.cloudera.org:8080/10505 )
Change subject: KUDU-702 Add block IDs to more log messages
..
Patch Set 1:
(4 comments)
Thanks for the patch! See inline for comments. Could use more detail in the
commit message as well as a comment about how this was tested. For log
messages, manual testing by running some of the tests and manually checking
that the log messages were printed as expected is usually how we do it.
Maybe log_block_manager-test would be a good test to check for the messages.
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/cfile/cfile_reader.cc
File src/kudu/cfile/cfile_reader.cc:
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/cfile/cfile_reader.cc@491
PS1, Line 491: LOG(WARNING) << "Unable to validate compressed block at "
:<< ptr.offset() << " with id " <<
block_id().ToString()
:<< " of size " << block.size() << ": "
:<< s.ToString();
Nit: the ordering here seems off to me, I think we should first identify the
block id and then print the offset and size, since offset and size are
logically the two parts you need for a pointer.
Same with the below change around line 510.
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/cfile/index_btree.cc
File src/kudu/cfile/index_btree.cc:
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/cfile/index_btree.cc@109
PS1, Line 109: LOG(ERROR) << "Unable to flush root index block" <<
ptr.ToString();
This is not likely to work as intended because a non-OK Status was returned
from FinishAndWriteBlock(), resulting in the out-parameter 'ptr' being left in
an undefined state (probably untouched).
Actually in this case I think we should remove the ERROR log and instead put
the same information in the return Status object like:
return s.CloneAndPrepend("Unable to flush root index block");
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/fs/log_block_manager.cc@2041
PS1, Line 2041: VLOG(2) << Substitute("Added block: offset $0, length $1, id
$2",
nit: for consistency i have the same suggestion for ordering in this file (here
and below) as in the other file
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/tserver/tablet_copy_source_session.cc
File src/kudu/tserver/tablet_copy_source_session.cc:
http://gerrit.cloudera.org:8080/#/c/10505/1/src/kudu/tserver/tablet_copy_source_session.cc@395
PS1, Line 395: LOG(DFATAL) << "Data block " << block_id.ToString() << "
disappeared: " << s.ToString();
This isn't necessary because we already included it in the error message on the
line above
--
To view, visit http://gerrit.cloudera.org:8080/10505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I895da1cc04ecbf006f412f06b31461b03072d32d
Gerrit-Change-Number: 10505
Gerrit-PatchSet: 1
Gerrit-Owner: Anupama Gupta
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Thu, 24 May 2018 22:00:31 +
Gerrit-HasComments: Yes
[kudu-CR] Mark the ImportExportFiles tool unstable
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10507 Change subject: Mark the ImportExportFiles tool unstable .. Mark the ImportExportFiles tool unstable Given we did not add an audience interface annotation and the issues found in KUDU-2454, this change markes ImportExportFiles.scala as unstable to discourage it’s use until more fixes and testing can be done. It also marks IntegrationTestBigLinkedList.scala private given it was also missing an audience interface annotation. Change-Id: I60af80b675e9918ad0e1742076d23d3c00738574 --- M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10507/1 -- To view, visit http://gerrit.cloudera.org:8080/10507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I60af80b675e9918ad0e1742076d23d3c00738574 Gerrit-Change-Number: 10507 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] WIP: Improve non-matching schema error message for client provided defaults
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10506 to review the following change. Change subject: WIP: Improve non-matching schema error message for client provided defaults .. WIP: Improve non-matching schema error message for client provided defaults In the case where the client provides a schema with an additional column with a default, and does not provide the value of the column in the write, the server should reject that request with a message indicating that the client wanted the default, not that the client provided the value for the missing column. While we have not verified this, Will saw a case in the wild involving alter table abort where the client appears to have not provided a value for the column, intending to use the default, but got the error message "Client provided column foo_bar not present in tablet". TODO: We are not sure if the client actually provided the value but it got projected out when printing the values being inserted or if indeed the client was attempting to use the default from its provided schema. Also TODO: This patch needs a test. Change-Id: I087c130a0f19c1feb8f4c0cd3c9cc794c4a552c2 --- M src/kudu/common/row_operations.cc 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10506/1 -- To view, visit http://gerrit.cloudera.org:8080/10506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I087c130a0f19c1feb8f4c0cd3c9cc794c4a552c2 Gerrit-Change-Number: 10506 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-702 Add block IDs to more log messages
Anupama Gupta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10505 Change subject: KUDU-702 Add block IDs to more log messages .. KUDU-702 Add block IDs to more log messages Change-Id: I895da1cc04ecbf006f412f06b31461b03072d32d --- M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/index_btree.cc M src/kudu/fs/log_block_manager.cc M src/kudu/tserver/tablet_copy_source_session.cc 4 files changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/10505/1 -- To view, visit http://gerrit.cloudera.org:8080/10505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I895da1cc04ecbf006f412f06b31461b03072d32d Gerrit-Change-Number: 10505 Gerrit-PatchSet: 1 Gerrit-Owner: Anupama Gupta
[kudu-CR] [rebalancing] Add a randomized rebalancing algorithm test
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10453 ) Change subject: [rebalancing] Add a randomized rebalancing algorithm test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id870d1290cf6681fa8bee79d8799f879b7dc8712 Gerrit-Change-Number: 10453 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 20:26:04 + Gerrit-HasComments: No
[kudu-CR] [docs] Add short troubleshooting note about nscd
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10498 ) Change subject: [docs] Add short troubleshooting note about nscd .. [docs] Add short troubleshooting note about nscd Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Reviewed-on: http://gerrit.cloudera.org:8080/10498 Reviewed-by: Andrew Wong Tested-by: Will Berkeley --- M docs/troubleshooting.adoc 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Will Berkeley: Verified -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Will Berkeley
[kudu-CR] [docs] Add short troubleshooting note about nscd
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10498 ) Change subject: [docs] Add short troubleshooting note about nscd .. Patch Set 2: Verified+1 Skipping tests- docs only change. -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 20:07:12 + Gerrit-HasComments: No
[kudu-CR] [docs] Add short troubleshooting note about nscd
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10498 ) Change subject: [docs] Add short troubleshooting note about nscd .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Will Berkeley
[kudu-CR] [docs] Add short troubleshooting note about nscd
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10498 ) Change subject: [docs] Add short troubleshooting note about nscd .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 19:58:06 + Gerrit-HasComments: No
[kudu-CR] [docs] Add short troubleshooting note about nscd
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10498 ) Change subject: [docs] Add short troubleshooting note about nscd .. Patch Set 1: (1 comment) > Does this apply to all versions? Yep! http://gerrit.cloudera.org:8080/#/c/10498/1/docs/troubleshooting.adoc File docs/troubleshooting.adoc: http://gerrit.cloudera.org:8080/#/c/10498/1/docs/troubleshooting.adoc@588 PS1, Line 588: nscd > nit: wrap ncsd with backticks? Done -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 19:51:07 + Gerrit-HasComments: Yes
[kudu-CR] [docs] Add short troubleshooting note about nscd
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10498 to look at the new patch set (#2). Change subject: [docs] Add short troubleshooting note about nscd .. [docs] Add short troubleshooting note about nscd Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 --- M docs/troubleshooting.adoc 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/10498/2 -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Add short troubleshooting note about nscd
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10498 ) Change subject: [docs] Add short troubleshooting note about nscd .. Patch Set 1: Does this apply to all versions? -- To view, visit http://gerrit.cloudera.org:8080/10498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99c33d9161a0878c7c7570313ca5f895a7a9 Gerrit-Change-Number: 10498 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 24 May 2018 19:18:15 + Gerrit-HasComments: No
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10502 Change subject: [java] Add Timestamp APIs to kudu-client .. [java] Add Timestamp APIs to kudu-client Adds support for java.sql.Timestamp to PartialRow, RowResult, and KuduPredicate. This simplifies and unfies the handling of Timestamps when reading and writing from Kudu. This functionality existied in the kudu-spark integration, but has been moved into the kudu-client and can be leveraged in other integrations going forward. Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1 --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java A java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java A java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala 13 files changed, 280 insertions(+), 104 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/10502/1 -- To view, visit http://gerrit.cloudera.org:8080/10502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1 Gerrit-Change-Number: 10502 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 16:01:31 + Gerrit-HasComments: No
[kudu-CR] [docs] KUDU-2107 Document how to add reviewers
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10501 to review the following change. Change subject: [docs] KUDU-2107 Document how to add reviewers .. [docs] KUDU-2107 Document how to add reviewers The contribution guidelines didn't mention how to add reviewers to gerrit. This patch documents this process and also adds a tip about how to find possible reviewers for a patch Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5 --- M docs/contributing.adoc 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/10501/1 -- To view, visit http://gerrit.cloudera.org:8080/10501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5 Gerrit-Change-Number: 10501 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Dan Burkert
[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 14: Code-Review+2 Leaving this open in case Alexey or Will have more feedback -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 15:13:33 + Gerrit-HasComments: No
[kudu-CR] KUDU-2287 Expose election failures as metrics
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 ) Change subject: KUDU-2287 Expose election failures as metrics .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10076/15/src/kudu/consensus/raft_consensus.cc@439 PS15, Line 439: time_since_leader_lost_ = MonoTime::Now(); > If a node loses contact with the leader for 10 seconds, say, and calls a pr I see, so it should be time_since_last_heartbeat_ instead of time_since_leader_lost_ effectively? -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 12:52:44 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10293 to look at the new patch set (#14). Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. KUDU-2426 Fix WRONG_SERVER_UUID case in ksck RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since KUDU-2364 to indicate a UUID mismatch. Ksck::FetchInfoFromTabletServers() checked for this Status, and this resulted in any RemoteError showing as a WRONG_SERVER_UUID in the tablet server health list. This commit adds KsckServerHealth output argument to FetchInfo() and FetchConsensusState() which can be used to add further context to a non-OK Status. Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h M src/kudu/tools/ksck_results.cc 7 files changed, 62 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10293/14 -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck
Hello Will Berkeley, Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10293 to look at the new patch set (#13). Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. KUDU-2426 Fix WRONG_SERVER_UUID case in ksck RemoteKsckTabletServer::FetchInfo() returned a Status::RemoteError since KUDU-2364 to indicate a UUID mismatch. Ksck::FetchInfoFromTabletServers() checked for this Status, and this resulted in any RemoteError showing as a WRONG_SERVER_UUID in the tablet server health list. This commit adds KsckServerHealth output argument to FetchInfo() and FetchConsensusState() which can be used to add further context to a non-OK Status. Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h M src/kudu/tools/ksck_results.cc 7 files changed, 60 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10293/13 -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/10293/12/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10293/12/src/kudu/tools/ksck.cc@296 PS12, Line 296: , > nit: Missing space. Done http://gerrit.cloudera.org:8080/#/c/10293/12/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/10293/12/src/kudu/tools/ksck_remote.cc@156 PS12, Line 156: DCHECK > Just in FetchInfo in ksck-test, which is a test file so a different situati Done -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 24 May 2018 09:06:44 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2191: Metadata Downgrade Tool
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10500 Change subject: KUDU-2191: Metadata Downgrade Tool .. KUDU-2191: Metadata Downgrade Tool This commit introduces a downgrade tool to allows downgrading of HMS integration feature. It provides support to downgrade the metadata format of existing Impala managed/external tables in HMS entries to external tables in the legacy metadata format. It adds test case using external mini cluster to ensure the downgrade tool works as expected. Change-Id: Ieac752e5c1fe5e63bc1ad5455b2c5dba8d3deba5 --- M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_catalog.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_hms.cc 6 files changed, 134 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/10500/1 -- To view, visit http://gerrit.cloudera.org:8080/10500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieac752e5c1fe5e63bc1ad5455b2c5dba8d3deba5 Gerrit-Change-Number: 10500 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
[kudu-CR] KUDU-2191: HMS Metadata Consistency Check Tool
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10217 to look at the new patch set (#8). Change subject: KUDU-2191: HMS Metadata Consistency Check Tool .. KUDU-2191: HMS Metadata Consistency Check Tool This commit introduces a metadata consistency check CLI tool for Hive Metastore integration. It checks metadata (table ID, table name, Kudu master addresses, and colnum name and type) between Kudu and HMS, and report inconsistent metadata to the user if any. It adds test case using external mini cluster to ensure the tool works as expected. Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 --- M src/kudu/hms/hms_catalog.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_hms.cc 3 files changed, 355 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/10217/8 -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2191: HMS inconsistent metadata fix tool
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10303 to look at the new patch set (#3). Change subject: KUDU-2191: HMS inconsistent metadata fix tool .. KUDU-2191: HMS inconsistent metadata fix tool This commit introduces a CLI tool that fixes inconsistent metadata for Hive Metastore integration. It corrects the table name based on the users input. Ant it fixes the master addresses property, column name and type based on the values in Kudu. Test case is added using external mini cluster to ensure the tool works as expected. Change-Id: I63c694b5d9877cfbd218139f2e9ecf05fd69c997 --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_hms.cc 2 files changed, 191 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/10303/3 -- To view, visit http://gerrit.cloudera.org:8080/10303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I63c694b5d9877cfbd218139f2e9ecf05fd69c997 Gerrit-Change-Number: 10303 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
