[kudu-CR] WIP [HaClient] introduce client metrics
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: WIP [HaClient] introduce client metrics .. Patch Set 1: Verified+1 unrelated flakes in: org.apache.kudu.spark.kudu.DefaultSourceTest org.apache.kudu.client.TestKuduPartitioner org.apache.kudu.client.TestSecurity -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 06 Apr 2019 04:35:53 + Gerrit-HasComments: No
[kudu-CR] WIP [HaClient] introduce client metrics
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: WIP [HaClient] introduce client metrics .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] WIP [HaClient] introduce client metrics
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12951 Change subject: WIP [HaClient] introduce client metrics .. WIP [HaClient] introduce client metrics Introduced metrics for Sentry client in SentryAuthzProvider. WIP: needed tests Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f --- M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc M src/kudu/master/sentry_authz_provider.cc M src/kudu/master/sentry_authz_provider.h A src/kudu/master/sentry_client_metrics.cc A src/kudu/master/sentry_client_metrics.h M src/kudu/thrift/client.h A src/kudu/thrift/ha_client_metrics.h 8 files changed, 191 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/12951/1 -- To view, visit http://gerrit.cloudera.org:8080/12951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I86e12ee6ee34f39c11f18b21e846cc5a1dee6b6f Gerrit-Change-Number: 12951 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: Is this ABI-compatible? (do we have a documented ABI-compatibility guarantee for the Java client?) -- To view, visit http://gerrit.cloudera.org:8080/12949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206 Gerrit-Change-Number: 12949 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Brian McDevitt Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Sat, 06 Apr 2019 03:37:08 + Gerrit-HasComments: No
[kudu-CR] tool: perf tablet scan action
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/12945 )
Change subject: tool: perf tablet_scan action
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12945/1/src/kudu/tools/tool_action_perf.cc
File src/kudu/tools/tool_action_perf.cc:
http://gerrit.cloudera.org:8080/#/c/12945/1/src/kudu/tools/tool_action_perf.cc@727
PS1, Line 727: MiniTabletServer mts(fs_root, HostPort("127.0.0.1", 0));
:
: // Don't bother heartbeating; we didn't start any masters.
: mts.options()->master_addresses.clear();
:
: RETURN_NOT_OK(mts.Start());
: RETURN_NOT_OK(mts.WaitStarted());
: scoped_refptr replica;
:
RETURN_NOT_OK(mts.server()->tablet_manager()->GetTabletReplica(tablet_id,
));
Do we need the entire tserver? Could we get by just opening the FsManager and
TabletMetadata, and constructing just the Tablet? Then you could actually use
this on a real server.
--
To view, visit http://gerrit.cloudera.org:8080/12945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4667dcb2d9a21d77149ebdae2e29b7fce8b460b
Gerrit-Change-Number: 12945
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Sat, 06 Apr 2019 00:40:57 +
Gerrit-HasComments: Yes
[kudu-CR] sentry: sanitize and parse privileges from Sentry
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: > (14 comments) > > Sorry I'm late to the party; hope this is still useful. Thank you for review. I'll try to address those comments in http://gerrit.cloudera.org:8080/12833, which is re-based atop of this patch. -- To view, visit http://gerrit.cloudera.org:8080/12919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6de6814f99abfbee4f030298b74f21f4e7c729b Gerrit-Change-Number: 12919 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 06 Apr 2019 00:37:33 + Gerrit-HasComments: No
[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher
Hello Tidy Bot, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#9). Change subject: WIP [master] introduced SentryPrivilegesFetcher .. WIP [master] introduced SentryPrivilegesFetcher This patch incorporates a TTL-based cache into the data paths of SentryAuthzProvider. As of now, the cache stores raw responses received from Sentry. It's possible to enable or disable caching upon creation of SentryAuthzProvider instance: set the newly introduced `--sentry_authz_cache_capacity_mb` command-line flag to 0 to disable caching of authz privilege information returned from Sentry. WIP: * address Adar's comments carried over from https://gerrit.cloudera.org/#/c/12919/ * avoid copying from cache's memory, pass as a result ? Change-Id: Idaefacd50736f1f152dae34e76778e17b2e84cbe --- M src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/master/CMakeLists.txt M src/kudu/master/catalog_manager.cc M src/kudu/master/default_authz_provider.h M src/kudu/master/sentry_authz_provider-test.cc M src/kudu/master/sentry_authz_provider.cc M src/kudu/master/sentry_authz_provider.h A src/kudu/master/sentry_privileges_cache_metrics.cc A src/kudu/master/sentry_privileges_cache_metrics.h A src/kudu/master/sentry_privileges_fetcher.cc A src/kudu/master/sentry_privileges_fetcher.h M src/kudu/sentry/sentry_authorizable_scope.cc M src/kudu/sentry/sentry_authorizable_scope.h 13 files changed, 1,235 insertions(+), 596 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/12833/9 -- To view, visit http://gerrit.cloudera.org:8080/12833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idaefacd50736f1f152dae34e76778e17b2e84cbe Gerrit-Change-Number: 12833 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.
raym...@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12949 Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. KUDU-2689: Made PartialRow setters use a fluent-style. Changed PartialRow return types from void to PartialRow so that the method calls can be chained. Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206 --- M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java 2 files changed, 132 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/12949/1 -- To view, visit http://gerrit.cloudera.org:8080/12949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206 Gerrit-Change-Number: 12949 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[kudu-CR] authz: authorize ListTablets
Hello Dan Burkert, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11752 to look at the new patch set (#2). Change subject: authz: authorize ListTablets .. authz: authorize ListTablets See the comment in tablet_service.h for details. Change-Id: I4bb2d09f23d7b77729e21060dad41c0501b17ded --- M src/kudu/integration-tests/security-itest.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/tserver_service.proto 4 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11752/2 -- To view, visit http://gerrit.cloudera.org:8080/11752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4bb2d09f23d7b77729e21060dad41c0501b17ded Gerrit-Change-Number: 11752 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12944 to review the following change. Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. generic_iterators: switch MergeIterator to intrusive list of states I originally wanted this for dominance because, in that world, a state is either linked to the main list or to another state's dominated list. We're going to go in a different direction, but an intrusive list still makes sense because: 1. We don't need random access into states_, and 2. An intrusive list will yield O(1) erase without increasing the total number of allocations. I also changed the MergeIterator tests to use int64_t instead of uint32_t for values, as the latter reliably overflowed the non-overlapped input test when num_lists >= 30. Change-Id: I1a165858e37c3e0a6ef85e46e20078c264fa8a65 --- M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc 2 files changed, 91 insertions(+), 67 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/12944/1 -- To view, visit http://gerrit.cloudera.org:8080/12944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a165858e37c3e0a6ef85e46e20078c264fa8a65 Gerrit-Change-Number: 12944 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] generic iterators: pass rowset bounds into grouping iterators
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12946 to review the following change. Change subject: generic_iterators: pass rowset bounds into grouping iterators .. generic_iterators: pass rowset bounds into grouping iterators The rowset bounds will be used to reduce MergeIterator memory consumption by restricting the "eager RowBlock fetching" behavior at Init time to only those sub-iterators whose rowsets could conceivably participate in the beginning of the merge. Normally the rowset bounds are encoded, but they need to be decoded upon arrival because they're going to be compared against decoded rows returned from sub-iterators, and it's far more efficient to decode the bounds once when initializing the MergeIterator than to encode the rows repeatedly during the merge. Change-Id: Id1aebd84507f87c869d781e117225c37c8f15969 --- M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/generic_iterators.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h 7 files changed, 174 insertions(+), 84 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/12946/1 -- To view, visit http://gerrit.cloudera.org:8080/12946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id1aebd84507f87c869d781e117225c37c8f15969 Gerrit-Change-Number: 12946 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] generic iterators: basic MergeIterator dominance
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/12197 ) Change subject: generic_iterators: basic MergeIterator dominance .. Abandoned This has been superceded by https://gerrit.cloudera.org/c/12947/ -- To view, visit http://gerrit.cloudera.org:8080/12197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If59d831240af15bfa7ef5709ec3d105d13b28322 Gerrit-Change-Number: 12197 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] remove schema copies from RowBlock and RowBuilder
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12907 to look at the new patch set (#5). Change subject: remove schema copies from RowBlock and RowBuilder .. remove schema copies from RowBlock and RowBuilder AFAICT the schemas in these two always outlive the classes themselves, so there's no reason to make schema copies. This is especially painful for the MergeIterator where each sub-iterator has a RowBlock (and thus a full copy of the schema). Change-Id: Ie4d60640b2bac4f2b3077ddd696966e1f6658740 --- M src/kudu/codegen/codegen-test.cc M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/row.h M src/kudu/common/row_changelist-test.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h M src/kudu/common/schema-test.cc M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-pushdown-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 31 files changed, 157 insertions(+), 143 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/12907/5 -- To view, visit http://gerrit.cloudera.org:8080/12907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4d60640b2bac4f2b3077ddd696966e1f6658740 Gerrit-Change-Number: 12907 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] row operations: suppress a gcc warning
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12943 to review the following change. Change subject: row_operations: suppress a gcc warning .. row_operations: suppress a gcc warning I couldn't get this one to budge with pragma suppressions, so I added a default value instead. Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788 --- M src/kudu/common/row_operations.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12943/1 -- To view, visit http://gerrit.cloudera.org:8080/12943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I606958b25e8cd02bcf610a52e6c35b618f9f9788 Gerrit-Change-Number: 12943 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tool: perf tablet scan action
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12945 to review the following change. Change subject: tool: perf tablet_scan action .. tool: perf tablet_scan action I found this action useful for benchmarking raw tserver scan performance (i.e. by removing the client from the picture). Not sure it's generally useful, but if it is, burying it in the 'perf' mode makes sense. Change-Id: Id4667dcb2d9a21d77149ebdae2e29b7fce8b460b --- M src/kudu/tools/tool_action_perf.cc 1 file changed, 70 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/12945/1 -- To view, visit http://gerrit.cloudera.org:8080/12945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id4667dcb2d9a21d77149ebdae2e29b7fce8b460b Gerrit-Change-Number: 12945 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] generic iterators: implement three-heap merge algorithm
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12947 to review the following change. Change subject: generic_iterators: implement three-heap merge algorithm .. generic_iterators: implement three-heap merge algorithm This patch implements a new algorithm for efficient merging in MergeIterator. The algorithm is documented extensively in the code so there's no point in recapping it here. There's also a high-level overview with pseudocode available[1]. I microbenchmarked the old implementation against the new one, using both overlapping and non-overlapping inputs with a varying number of lists and 1 rows per list (see generic_iterators-test). Here are the scan times, averaged across five runs: Parameters | old | new | diff +--+--+-- overlapping, 10 lists | 0.015s | 0.0522s | +0.0372 (0.29x) overlapping, 100 lists | 1.0798s | 1.1024s | +0.0226 (0.98x) overlapping, 1000 lists | 184.245s | 22.8156s | -161.4294 (8.07x) non-overlapping, 10 lists | 0.0126s | 0.0196s | +0.007(0.64x) non-overlapping, 100 lists | 0.5038s | 0.129s | -0.3748 (3.91x) non-overlapping, 1000 lists | 89.8626s | 0.9874s | -88.8752 (91x) +--+--+-- The goal was to optimize ORDERED scans for large and mostly compacted tablets, and the new algorithm does just that. With smaller input, the overhead of using heaps becomes more pronounced. Overlapping input still benefits from heap-based merging, but the overlapping defeats the hot vs. cold optimization provided by the algorithm. Another goal of the algorithm was to reduce peak memory consumption by using rowset bounds as proxies for hot vs. cold separation, thus deferring the loading of blocks into memory until absolutely necessary. I didn't measure this explicitly in microbenchmarks, but I plan to explore it next. Lastly, the new algorithm opens the door to another optimization: while there's just one sub-iterator in the hot heap, we can copy data block-by-block instead of row-by-row. I'll implement it in a follow-up. 1. https://docs.google.com/document/d/1uP0ubjM6ulnKVCRrXtwT_dqrTWjF9tlFSRk0JN2e_O0/edit# Change-Id: I6deab76a103f45c1b5042b104731e46a771a0f5d --- M src/kudu/common/encoded_key.cc M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/generic_iterators.h M src/kudu/common/schema.cc M src/kudu/common/schema.h 6 files changed, 387 insertions(+), 111 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12947/1 -- To view, visit http://gerrit.cloudera.org:8080/12947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6deab76a103f45c1b5042b104731e46a771a0f5d Gerrit-Change-Number: 12947 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] authz: add interface for generating authz tokens
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/12896 ) Change subject: authz: add interface for generating authz tokens .. Abandoned This is being done in another patch. -- To view, visit http://gerrit.cloudera.org:8080/12896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I266abe3609480fe9f7f777081690d555e51d627e Gerrit-Change-Number: 12896 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] wip sentry: generate authz tokens
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/12897 ) Change subject: wip sentry: generate authz tokens .. Abandoned This is split into multiple other patches. -- To view, visit http://gerrit.cloudera.org:8080/12897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I052432408045c48f6fe9bf921fd3cb6bcc36e9ad Gerrit-Change-Number: 12897 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] sentry: generate table privileges
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#2). Change subject: sentry: generate table privileges .. sentry: generate table privileges This patch adds TablePrivilegePB generation to the authz provider. A follow-up patch will integrate this functionality with the catalog manager. Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f --- M src/kudu/master/authz_provider.h M src/kudu/master/default_authz_provider.h M src/kudu/master/sentry_authz_provider-test.cc M src/kudu/master/sentry_authz_provider.cc M src/kudu/master/sentry_authz_provider.h 5 files changed, 256 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12941/2 -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] sentry: generate table privileges
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12941 Change subject: sentry: generate table privileges .. sentry: generate table privileges This patch adds token generation to the authz provider. A follow-up patch will integrate this functionality with the catalog manager. Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f --- M src/kudu/master/authz_provider.h M src/kudu/master/default_authz_provider.h M src/kudu/master/sentry_authz_provider-test.cc M src/kudu/master/sentry_authz_provider.cc M src/kudu/master/sentry_authz_provider.h 5 files changed, 256 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12941/1 -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icb6c533a04d2749e0ee68546dac61011432cba2f Gerrit-Change-Number: 12941 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] [build] Fix building codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix building codegen on MacOS Mojave .. Patch Set 2: Verified+1 Code-Review+2 (1 comment) > Patch Set 1: Code-Review+2 > > (1 comment) > > Fix the one misspelling and then forward my +2 and submit it. http://gerrit.cloudera.org:8080/#/c/12936/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12936/1//COMMIT_MSG@7 PS1, Line 7: buildin > building Done -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 18:52:12 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix building codegen on MacOS Mojave
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix building codegen on MacOS Mojave .. [build] Fix building codegen on MacOS Mojave When macOS_SDK_headers_for_macOS_10.14 is installed setting the --sysroot to the default header location breaks the build, which is why there was a check whether /usr/include existed and only set --sysroot to the SDK path if it didn't. The problem with this is if something creates the /usr/include directory, the build will fail again. This commit changes the check to look for /usr/include/libc.h instead. Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Reviewed-on: http://gerrit.cloudera.org:8080/12936 Reviewed-by: Attila Bukor Tested-by: Attila Bukor --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Attila Bukor: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix building codegen on MacOS Mojave
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12936 to look at the new patch set (#2). Change subject: [build] Fix building codegen on MacOS Mojave .. [build] Fix building codegen on MacOS Mojave When macOS_SDK_headers_for_macOS_10.14 is installed setting the --sysroot to the default header location breaks the build, which is why there was a check whether /usr/include existed and only set --sysroot to the SDK path if it didn't. The problem with this is if something creates the /usr/include directory, the build will fail again. This commit changes the check to look for /usr/include/libc.h instead. Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/12936/2 -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+2 (1 comment) Fix the one misspelling and then forward my +2 and submit it. http://gerrit.cloudera.org:8080/#/c/12936/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12936/1//COMMIT_MSG@7 PS1, Line 7: bulding building -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 18:27:40 + Gerrit-HasComments: Yes
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: > Patch Set 1: Code-Review+1 > > I don't have the ability to test this since I used the workaround to install > the headers, but I am onboard with the fix. It could be worth backporting to > 1.9.x too. I tested it yesterday without the workaround, Will tested it with the workaround installed on his MacBook. -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 18:26:38 + Gerrit-HasComments: No
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb Gerrit-Change-Number: 12932 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 05 Apr 2019 16:02:05 + Gerrit-HasComments: No
[kudu-CR] [metrics] Remove incorrect comments
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 Gerrit-Change-Number: 12921 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 05 Apr 2019 16:06:29 + Gerrit-HasComments: No
[kudu-CR] [metrics] Remove incorrect comments
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. [metrics] Remove incorrect comments Data store in std::map with key type 'const char*' is not in alphabetical order, and it's not needed to sort metrics. Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 Reviewed-on: http://gerrit.cloudera.org:8080/12921 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/util/metrics.cc 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 Gerrit-Change-Number: 12921 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable Under mode UPSERT_TO_EXIST_TABLE, destination table is not empty before copying, it may has more rows than source table, so it may still has more rows than source table after copying. Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb Reviewed-on: http://gerrit.cloudera.org:8080/12932 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/tools/kudu-tool-test.cc 1 file changed, 30 insertions(+), 25 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb Gerrit-Change-Number: 12932 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] [metrics] Remove incorrect comments
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12921/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12921/1//COMMIT_MSG@10 PS1, Line 10: and it's not needed to sort metrics. > I see how this was previously broken, but don't we want to sort the output? There are dozens of metrics, and dozens of metric entities on a server, it's hard to check any metric even if they are sorted. I think users may prefer to search a certain metric name when they check the raw metrics output. For third-party monitor systems, it doesn't matter whether metrics are sorted or not. This rule seems have been broken for years and nobody complains, it's not a real need in my opinion. http://gerrit.cloudera.org:8080/#/c/12921/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/12921/1/src/kudu/util/metrics.cc@224 PS1, Line 224: InsertOrDie(, prototype, metric); > With 'metrics' now being a MetricMap, it may be faster to reduce the amount Done -- To view, visit http://gerrit.cloudera.org:8080/12921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 Gerrit-Change-Number: 12921 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 05 Apr 2019 14:44:42 + Gerrit-HasComments: Yes
[kudu-CR] [metrics] Remove incorrect comments
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12921 to look at the new patch set (#2). Change subject: [metrics] Remove incorrect comments .. [metrics] Remove incorrect comments Data store in std::map with key type 'const char*' is not in alphabetical order, and it's not needed to sort metrics. Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 --- M src/kudu/util/metrics.cc 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/12921/2 -- To view, visit http://gerrit.cloudera.org:8080/12921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id8788c38b73c623616b3fb2b73fcb6973df4ec87 Gerrit-Change-Number: 12921 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 ) Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@572 PS1, Line 572: // Rows scaned from source table can be found in destination table. > scanned Done http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@583 PS1, Line 583: has > Nit: "should have" Done http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@643 PS1, Line 643: ww.set_write_batch_size(1); > Why this change? Not related, I'll remove it. -- To view, visit http://gerrit.cloudera.org:8080/12932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb Gerrit-Change-Number: 12932 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 05 Apr 2019 13:45:10 + Gerrit-HasComments: Yes
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12932 to look at the new patch set (#2). Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable .. [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable Under mode UPSERT_TO_EXIST_TABLE, destination table is not empty before copying, it may has more rows than source table, so it may still has more rows than source table after copying. Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb --- M src/kudu/tools/kudu-tool-test.cc 1 file changed, 30 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/12932/2 -- To view, visit http://gerrit.cloudera.org:8080/12932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb Gerrit-Change-Number: 12932 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix bulding codegen on MacOS Mojave
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12936 ) Change subject: [build] Fix bulding codegen on MacOS Mojave .. Patch Set 1: Code-Review+1 I don't have the ability to test this since I used the workaround to install the headers, but I am onboard with the fix. It could be worth backporting to 1.9.x too. -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 05 Apr 2019 13:28:16 + Gerrit-HasComments: No
