date:20220223

[kudu-CR] [security] handle a few unexpected authn token conditions

2022-02-23 Thread Alexey Serbin (Code Review)

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18271


Change subject: [security] handle a few unexpected authn token conditions
..

[security] handle a few unexpected authn token conditions

This patch addresses a few unexpected error conditions in the
server-side negotiation code when authenticating a client with
its authn token.

I didn't add any tests since there is no mock for the corresponding
client side and implementing it from scratch just to verify these
two simple cases looked like an overkill.

Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901
---
M src/kudu/rpc/server_negotiation.cc
1 file changed, 14 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18271/1
--
To view, visit http://gerrit.cloudera.org:8080/18271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic05ff6a9b289877d8440b94f00b2375da938c901
Gerrit-Change-Number: 18271
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin

[kudu-CR] [tests] harmonize assertions on the expected status

2022-02-23 Thread Alexey Serbin (Code Review)

Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18269 )

Change subject: [tests] harmonize assertions on the expected status
..

[tests] harmonize assertions on the expected status

I was trying to understand why a test scenario from security-itest
failed in one of gerrit pre-commit runs and found that it would be
great to know the actual vs the expected type of the status when an
assertion of type ASSERT_{FALSE,TRUE}(s.IsXxx()) triggers.

This patch updates the corresponding call sites of ASSERT_{FALSE,TRUE}
in the code of that and other tests to provide such information for
easier troubleshooting and debugging in future.

Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Reviewed-on: http://gerrit.cloudera.org:8080/18269
Reviewed-by: Andrew Wong 
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/predicate-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/net/socket-test.cc
M src/kudu/util/oid_generator-test.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/yamlreader-test.cc
42 files changed, 121 insertions(+), 120 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/18269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Gerrit-Change-Number: 18269
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy

[kudu-CR] [tests] harmonize assertions on the expected status

2022-02-23 Thread Andrew Wong (Code Review)

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18269 )

Change subject: [tests] harmonize assertions on the expected status
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/18269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Gerrit-Change-Number: 18269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Comment-Date: Thu, 24 Feb 2022 01:23:14 +
Gerrit-HasComments: No

[kudu-CR] [tests] harmonize assertions on the expected status

2022-02-23 Thread Alexey Serbin (Code Review)

Hello Mahesh Reddy, Kudu Jenkins, Andrew Wong, Abhishek Chennaka,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/18269

to look at the new patch set (#2).

Change subject: [tests] harmonize assertions on the expected status
..

[tests] harmonize assertions on the expected status

I was trying to understand why a test scenario from security-itest
failed in one of gerrit pre-commit runs and found that it would be
great to know the actual vs the expected type of the status when an
assertion of type ASSERT_{FALSE,TRUE}(s.IsXxx()) triggers.

This patch updates the corresponding call sites of ASSERT_{FALSE,TRUE}
in the code of that and other tests to provide such information for
easier troubleshooting and debugging in future.

Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/predicate-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/net/socket-test.cc
M src/kudu/util/oid_generator-test.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/yamlreader-test.cc
42 files changed, 121 insertions(+), 120 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/18269/2
--
To view, visit http://gerrit.cloudera.org:8080/18269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Gerrit-Change-Number: 18269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy

[kudu-CR] [tests] harmonize assertions on the expected status

2022-02-23 Thread Mahesh Reddy (Code Review)

Mahesh Reddy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18269 )

Change subject: [tests] harmonize assertions on the expected status
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Gerrit-Change-Number: 18269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Comment-Date: Thu, 24 Feb 2022 00:30:03 +
Gerrit-HasComments: No

[kudu-CR] [tests] harmonize assertions on the expected status

2022-02-23 Thread Alexey Serbin (Code Review)

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18269


Change subject: [tests] harmonize assertions on the expected status
..

[tests] harmonize assertions on the expected status

I was trying to understand why a test scenario from security-itest
failed in one of gerrit pre-commit runs and found that it would be
great to know the actual vs the expected type of the status when an
assertion of type ASSERT_{FALSE,TRUE}(s.IsXxx()) triggers.

This patch updates the corresponding call sites of ASSERT_{FALSE,TRUE}
in the code of that and other tests to provide such information for
easier troubleshooting and debugging in future.

Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/predicate-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/net/socket-test.cc
M src/kudu/util/oid_generator-test.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/yamlreader-test.cc
42 files changed, 119 insertions(+), 119 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/18269/1
--
To view, visit http://gerrit.cloudera.org:8080/18269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Gerrit-Change-Number: 18269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

2022-02-23 Thread Yingchun Lai (Code Review)

Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18255 )

Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using 
std::shared_ptr
..


Patch Set 3:

(2 comments)

Good work!

http://gerrit.cloudera.org:8080/#/c/18255/3/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

http://gerrit.cloudera.org:8080/#/c/18255/3/src/kudu/tablet/tablet.cc@548
PS3, Line 548: schema().get()
Why there are two styles, one is declear a new variable, like 'SchemaPtr 
schema_ptr = schema()', while another use 'schema().get()' directly?


http://gerrit.cloudera.org:8080/#/c/18255/3/src/kudu/tablet/tablet.cc@1616
PS3, Line 1616:   SchemaPtr schema(new Schema(new_schema));
How about use std::make_shared?



--
To view, visit http://gerrit.cloudera.org:8080/18255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35
Gerrit-Change-Number: 18255
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Wed, 23 Feb 2022 11:59:45 +
Gerrit-HasComments: Yes

[kudu-CR] [security] handle a few unexpected authn token conditions

[kudu-CR] [tests] harmonize assertions on the expected status

[kudu-CR] [tests] harmonize assertions on the expected status

[kudu-CR] [tests] harmonize assertions on the expected status

[kudu-CR] [tests] harmonize assertions on the expected status

[kudu-CR] [tests] harmonize assertions on the expected status

[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr

7 matches

Site Navigation

Mail list logo

Footer information