[kudu-CR] [tools] use thread pool for 'kudu local replica copy from local'
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/18448 )
Change subject: [tools] use thread pool for 'kudu local_replica copy_from_local'
..
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_common.cc
File src/kudu/tools/tool_action_common.cc:
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_common.cc@136
PS5, Line 136: . Each thread runs its own "
: "KuduSession.
nit: since this is being used in common code, maybe remove this. Or consider
adding a separate flag for the copy tool
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@448
PS5, Line 448: vector
nit: just FYI this can also be a set, to deduplicate up front. That way some of
the sets we maintain below could just be vectors
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@483
PS5, Line 483: INFO
nit: maybe make this a warning or error?
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@483
PS5, Line 483: "Tablet $0 copy failed, error=Not found in source filesystem."
nit: maybe "Tablet $0 copy failed, not found in source filesystem"
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@498
PS5, Line 498: LOG(INFO) << copying_replica->last_status();
Just curious, does this also print the tablet IDs? If not, it might be worth
considering
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@536
PS5, Line 536: do {
: s = client.Start(tablet_id, /* meta */ nullptr);
: if (PREDICT_FALSE(!s.ok())) {
: s = s.CloneAndPrepend("Start copy tablet failed");
: break;
: }
: s = client.FetchAll(fake_replica);
: if (PREDICT_FALSE(!s.ok())) {
: s = s.CloneAndPrepend("Fetch all tablet data failed");
: break;
: }
: s = client.Finish();
: if (PREDICT_FALSE(!s.ok())) {
: s = s.CloneAndPrepend("Finish copy tablet failed");
: break;
: }
: } while (false);
nit: consider writing as
Status s = client.Start(tablet_id, nullptr).AndThen([&] {
return client.FetchAll(fake_replica);
}).AndThen([&] {
return client.Finish();
})
http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@558
PS5, Line 558: Tablet $0 copy failed, error=$1.
nit: maybe "Tablet $0 copy failed: $1"
--
To view, visit http://gerrit.cloudera.org:8080/18448
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4de49e948cc1a686db5e1bf424470ca9e800ee36
Gerrit-Change-Number: 18448
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang
Gerrit-Reviewer: Yingchun Lai
Gerrit-Comment-Date: Sat, 30 Apr 2022 05:35:17 +
Gerrit-HasComments: Yes
[kudu-CR] [client] fix toggling fault-tolerance for a scanner
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 ) Change subject: [client] fix toggling fault-tolerance for a scanner .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::READ_AT_SNAPSHOT, sc.read_mode()); > It turns out the code in Java client assumes that switching to non-fault-to Right, I might expect that kind of behavior in some ResetToDefault() call or somesuch, but it seemed a bit odd otherwise. Things like scanner.SetReadMode(READ_AT_SNAPSHOT); scanner.SetFaultTolerant(false); would be have surprising results in that case IMO -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Apr 2022 05:14:30 + Gerrit-HasComments: Yes
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and DELETE_IGNORE. However, it was lacking the per-session metrics about how many rows get ignored vs modified. This patch implements the per-session metrics by introducing a new ResourceMetricsPB field into the WriteResponsePB that's populated in every response sent back to the client. Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Reviewed-on: http://gerrit.cloudera.org:8080/18451 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/client/batcher.cc M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/resource_metrics.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h M src/kudu/tserver/tserver.proto 11 files changed, 138 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 10: Code-Review+2 Thank you for the contribution! -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Sat, 30 Apr 2022 05:00:49 + Gerrit-HasComments: No
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#10). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and DELETE_IGNORE. However, it was lacking the per-session metrics about how many rows get ignored vs modified. This patch implements the per-session metrics by introducing a new ResourceMetricsPB field into the WriteResponsePB that's populated in every response sent back to the client. Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 --- M src/kudu/client/batcher.cc M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/resource_metrics.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h M src/kudu/tserver/tserver.proto 11 files changed, 138 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/18451/10 -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto
[kudu-CR] [client] fix toggling fault-tolerance for a scanner
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 ) Change subject: [client] fix toggling fault-tolerance for a scanner .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::READ_AT_SNAPSHOT, sc.read_mode()); > The idea was to return it back to the original state that ScanConfiguration It turns out the code in Java client assumes that switching to non-fault-tolerant scan keeps the read mode as READ_AT_SNAPSHOT. So, it seems that's a manifestation of the the Hyrum's law in this particular case :) -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Apr 2022 02:26:15 + Gerrit-HasComments: Yes
[kudu-CR] [client] fix toggling fault-tolerance for a scanner
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18462 to look at the new patch set (#2). Change subject: [client] fix toggling fault-tolerance for a scanner .. [client] fix toggling fault-tolerance for a scanner Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 --- M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java M src/kudu/client/scan_configuration.cc M src/kudu/client/scan_token-test.cc 4 files changed, 57 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/18462/2 -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] fix toggling fault-tolerance for a scanner
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 ) Change subject: [client] fix toggling fault-tolerance for a scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::ReadMode::READ_LATEST, sc.read_mode()); > This seems a bit surprising -- why not have SetFaultTolerant(false) leave t The idea was to return it back to the original state that ScanConfiguration was created with. I agree there might be different idea how it works: the current API is a bit clumsy for fault tolerance settings. -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Apr 2022 02:02:18 + Gerrit-HasComments: Yes
[kudu-CR] [client] fix toggling fault-tolerance for a scanner
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18462 ) Change subject: [client] fix toggling fault-tolerance for a scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18462/1/src/kudu/client/scan_token-test.cc@1085 PS1, Line 1085: ASSERT_EQ(KuduScanner::ReadMode::READ_LATEST, sc.read_mode()); This seems a bit surprising -- why not have SetFaultTolerant(false) leave the read mode as is? -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Apr 2022 01:13:38 + Gerrit-HasComments: Yes
[kudu-CR] [client] fix toggling fault-tolerance for a scanner
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18462 Change subject: [client] fix toggling fault-tolerance for a scanner .. [client] fix toggling fault-tolerance for a scanner Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 --- M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java M src/kudu/client/scan_configuration.cc M src/kudu/client/scan_token-test.cc 4 files changed, 50 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/18462/1 -- To view, visit http://gerrit.cloudera.org:8080/18462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic50f9d62623d8b9ced7d854ce0e80a0faaa60ad3 Gerrit-Change-Number: 18462 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/18451 )
Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
..
Patch Set 9:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/client/client-test.cc@2939
PS7, Line 2939: const KuduSession* s
> Done
OK, thanks: const pointer will do here as well -- it's a just a test after all.
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/integration-tests/exactly_once_writes-itest.cc
File src/kudu/integration-tests/exactly_once_writes-itest.cc:
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/integration-tests/exactly_once_writes-itest.cc@178
PS7, Line 178: esponse.has_resource_metrics()) {
> You are right. The rest of responses actually match.
Thanks!
http://gerrit.cloudera.org:8080/#/c/18451/9/src/kudu/integration-tests/exactly_once_writes-itest.cc
File src/kudu/integration-tests/exactly_once_writes-itest.cc:
http://gerrit.cloudera.org:8080/#/c/18451/9/src/kudu/integration-tests/exactly_once_writes-itest.cc@183
PS9, Line 183: response.release_resource_metrics();
I didn't notice that in previous review cycle, but instead here should be
response.clear_resource_metrics();
Otherwise, it's a memory leak -- release returns the underlying structure along
with transferring the ownership of the allocated structure to the caller.
--
To view, visit http://gerrit.cloudera.org:8080/18451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3
Gerrit-Change-Number: 18451
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Riza Suminto
Gerrit-Comment-Date: Fri, 29 Apr 2022 21:00:51 +
Gerrit-HasComments: Yes
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Riza Suminto has posted comments on this change. (
http://gerrit.cloudera.org:8080/18451 )
Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
..
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/client/client-test.cc@2939
PS7, Line 2939: const KuduSession* s
> nit: since GetWriteOpMetrics() has become a const method, the style guide d
Done
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/integration-tests/exactly_once_writes-itest.cc
File src/kudu/integration-tests/exactly_once_writes-itest.cc:
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/integration-tests/exactly_once_writes-itest.cc@178
PS7, Line 178: esponse.has_resource_metrics()) {
> Just to reassure it's a right thing to do, could you please add a comment e
You are right. The rest of responses actually match.
Added more descriptive comment.
--
To view, visit http://gerrit.cloudera.org:8080/18451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3
Gerrit-Change-Number: 18451
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Riza Suminto
Gerrit-Comment-Date: Fri, 29 Apr 2022 17:52:56 +
Gerrit-HasComments: Yes
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#9). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and DELETE_IGNORE. However, it was lacking the per-session metrics about how many rows get ignored vs modified. This patch implements the per-session metrics by introducing a new ResourceMetricsPB field into the WriteResponsePB that's populated in every response sent back to the client. Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 --- M src/kudu/client/batcher.cc M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/resource_metrics.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h M src/kudu/tserver/tserver.proto 11 files changed, 138 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/18451/9 -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18461/2//COMMIT_MSG Commit Message: PS2: Does it make sense to rebase this patch on top of current HEAD of the master branch (i.e. before upgrading glog to 0.6.0)? -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 16:50:15 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG@18 PS2, Line 18: had to be modified Do you mind explaining the reason for the modification? BTW, is it still buildable on aarch64 after the modification? http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch File thirdparty/patches/glog-make-internals-visible.patch: http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch@8 PS2, Line 8: > nit: whitespace That's a patch file, so whitespace in a must for the unified diff format here. -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 16:49:11 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 2: The build is failing now with the errors as below. Is that something related to the contaminated workspace? Did you try to build it on a Linux build machine? 05:26:14 [ 6%] Running C++ protocol buffer compiler on transactions.proto 05:26:14 /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory 05:26:14 --insertions_out: protoc-gen-insertions: Plugin failed with status code 127. 05:26:14 /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory 05:26:14 --insertions_out: protoc-gen-insertions: Plugin failed with status code 127. 05:26:14 src/kudu/util/CMakeFiles/kudu_util_hash_proto.dir/build.make:81: recipe for target 'src/kudu/util/hash.pb.cc' failed 05:26:14 make[2]: *** [src/kudu/util/hash.pb.cc] Error 1 05:26:14 /home/jenkins-slave/workspace/kudu-master/2/build/debug/bin/protoc-gen-insertions: error while loading shared libraries: libgflags.so.2.2: cannot open shared object file: No such file or directory -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 16:46:30 + Gerrit-HasComments: No
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/18451 )
Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
..
Patch Set 8: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/client/client-test.cc@2939
PS7, Line 2939: KuduSession* session
nit: since GetWriteOpMetrics() has become a const method, the style guide
dictates passing this parameter as a const reference.
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/integration-tests/exactly_once_writes-itest.cc
File src/kudu/integration-tests/exactly_once_writes-itest.cc:
http://gerrit.cloudera.org:8080/#/c/18451/7/src/kudu/integration-tests/exactly_once_writes-itest.cc@178
PS7, Line 178: esponse.has_resource_metrics()) {
Just to reassure it's a right thing to do, could you please add a comment
explaining the reasoning behind. I guess the reason is that in case of
exactly-once RPC semantics, metrics in retried requests all come zeroed out or
even not populated, right?
--
To view, visit http://gerrit.cloudera.org:8080/18451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3
Gerrit-Change-Number: 18451
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Riza Suminto
Gerrit-Comment-Date: Fri, 29 Apr 2022 16:42:58 +
Gerrit-HasComments: Yes
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 8: (1 comment) Patch set 8 fix the IWYU error and submitted to rerun the precommit tests. I ended up changing exacly_once_writes-itest by dropping the resource metrics from the responses as it is not relevant for the assertion. http://gerrit.cloudera.org:8080/#/c/18451/6/src/kudu/tablet/ops/write_op.h File src/kudu/tablet/ops/write_op.h: http://gerrit.cloudera.org:8080/#/c/18451/6/src/kudu/tablet/ops/write_op.h@264 PS6, Line 264: // Copy metrics from 'op_metrics_' into the response's > Forgot to write documentation here. Done -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Fri, 29 Apr 2022 16:09:59 + Gerrit-HasComments: Yes
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18451 to look at the new patch set (#8). Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB KUDU-1563 adds support for INSERT_IGNORE, UPDATE_IGNORE, and DELETE_IGNORE. However, it was lacking the per-session metrics about how many rows get ignored vs modified. This patch implements the per-session metrics by introducing a new ResourceMetricsPB field into the WriteResponsePB that's populated in every response sent back to the client. Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 --- M src/kudu/client/batcher.cc M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/resource_metrics.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h M src/kudu/tserver/tserver.proto 11 files changed, 135 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/18451/8 -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto
[kudu-CR] [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18451 ) Change subject: [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB .. Patch Set 7: Aside from the unrelated test failures, the IWYU build isn't yet happy: >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/kudu-master/2/src/kudu/integration-tests/exactly_once_writes-itest.cc' @@ -28,6 +28,7 @@ #include #include +#include "kudu/common/row_operations.pb.h" #include "kudu/common/schema.h" #include "kudu/common/wire_protocol-test-util.h" #include "kudu/common/wire_protocol.h" IWYU would have edited 1 files on your behalf. -- To view, visit http://gerrit.cloudera.org:8080/18451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9adefd64b0058c66274a00e1b12334653fcab2b3 Gerrit-Change-Number: 18451 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Fri, 29 Apr 2022 16:01:04 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 ) Change subject: [thirdparty] Upgrade glog to 0.6.0 .. Patch Set 2: Code-Review+1 (1 comment) Thanks for this patch! Aside from the TidyBot and a few trailing whitespaces it looks good to me. I also built thirdparty and kudu locally on a 2019 MBP using macOs Monterey (12.1) successfully. Also did some simple manual tests, kudu seems to start up and function fine. http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch File thirdparty/patches/glog-make-internals-visible.patch: http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch@8 PS2, Line 8: nit: whitespace -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 13:22:01 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, Andrew Wong, Khazar Mammadli, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18460 to look at the new patch set (#2). Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 117 insertions(+), 526 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/2 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18461 ) Change subject: [build] Fix codegen build on MacOS Monterey .. Patch Set 1: Could someone double check if this works on older Macs too? -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan Gerrit-Comment-Date: Fri, 29 Apr 2022 12:16:54 + Gerrit-HasComments: No
[kudu-CR] [build] Fix codegen build on MacOS Monterey
Hello Zoltan Chovan, Alexey Serbin, Andrew Wong, Khazar Mammadli, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/18461 to review the following change. Change subject: [build] Fix codegen build on MacOS Monterey .. [build] Fix codegen build on MacOS Monterey 0e2c28864c27727c9723db7f319a5d7ebcbeead7 changed -cxx-isystem to /Library/Developer/CommandLineTools/usr/include/c++/v1 when building codegen on MacOS, which no longer seems to work on MacOS Monterey. This commit changes this to CMAKE_OSX_SYSROOT, which CMake sets to the SDK location, and should work across MacOS versions. Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/18461/1 -- To view, visit http://gerrit.cloudera.org:8080/18461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idc5721cb2445303b2e79d08b547e746929c7486d Gerrit-Change-Number: 18461 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [thirdparty] Upgrade glog to 0.6.0
Hello Zoltan Chovan, Alexey Serbin, Andrew Wong, Khazar Mammadli, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/18460 to review the following change. Change subject: [thirdparty] Upgrade glog to 0.6.0 .. [thirdparty] Upgrade glog to 0.6.0 Our current glog version is 0.3.5, which is very old, and apparently broken on MacOS Monterey, as it doesn't print integers when appended to the log stream, and it can also crash the process in certain cases. Some of the glog API changed, requiring small changes in the code, and the internal API, some of which Kudu relies on (stack traces, symbolizing addresses), is now hidden, so this commit also adds a patch to change glog's CMakeLists to make the internal API visible. Some older patches that were merged upstream have been removed, and the one adding stacktrace support for aarch64 had to be modified. Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 --- M cmake_modules/FindGLog.cmake M src/kudu/common/row_operations-test.cc M src/kudu/fs/dir_util-test.cc M src/kudu/ranger/ranger_client.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/util/async_logger.cc M src/kudu/util/async_logger.h M src/kudu/util/debug-util.cc M src/kudu/util/debug/trace_logging.h M src/kudu/util/flags.cc M src/kudu/util/logging-test.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/logging_test_util.h M src/kudu/util/rw_mutex-test.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh D thirdparty/patches/glog-fix-symbolization.patch D thirdparty/patches/glog-issue-198-fix-unused-warnings.patch D thirdparty/patches/glog-issue-54-dont-build-tests.patch A thirdparty/patches/glog-make-internals-visible.patch M thirdparty/patches/glog-support-stacktrace-for-aarch64.patch M thirdparty/vars.sh 24 files changed, 128 insertions(+), 500 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/18460/1 -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Zoltan Chovan
[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18428 ) Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG@7 PS6, Line 7: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc nit:How about "[master_log] Correction for the value of `table_rows_limit`" http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc@3649 PS6, Line 3649: FLAGS_table_write_limit_ratio nit: How about adding this flag to the log? Seems it's not always 1, just in case we need this info to find out why write ops are rejected. -- To view, visit http://gerrit.cloudera.org:8080/18428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa Gerrit-Change-Number: 18428 Gerrit-PatchSet: 6 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Comment-Date: Fri, 29 Apr 2022 11:54:42 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add .asf.yaml
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18410 ) Change subject: Add .asf.yaml .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98 Gerrit-Change-Number: 18410 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Comment-Date: Fri, 29 Apr 2022 10:47:11 + Gerrit-HasComments: No
[kudu-CR](gh-pages) Add .asf.yaml
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18410 ) Change subject: Add .asf.yaml .. Add .asf.yaml An .asf.yaml was committed to the kudu-site repo from which the site is published some time ago, but this is deleted when regenerating the site from kudu/gh-pages. Adding this file in kudu/gh-pages should resolve this issue. This file is a config file required by the ASF infra[1], without it, the updated site wouldn't be published. [1] https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-WebsitedeploymentserviceforGitrepositories Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98 Reviewed-on: http://gerrit.cloudera.org:8080/18410 Reviewed-by: Alexey Serbin Tested-by: Attila Bukor --- A .asf.yaml M _config.yml 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Attila Bukor: Verified -- To view, visit http://gerrit.cloudera.org:8080/18410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: I58d8f85e83ac2ad46d192abb58b748eb7bba6c98 Gerrit-Change-Number: 18410 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor
[kudu-CR] [tools] use thread pool for 'kudu local replica copy from local'
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18448 ) Change subject: [tools] use thread pool for 'kudu local_replica copy_from_local' .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@476 PS5, Line 476: // Prepare to check copy progress. nit: What about "Protects 'copying_replicas' and 'failed_tablet_ids'"? http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@486 PS5, Line 486: continue nit: Is this needed? http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@518 PS5, Line 518: if (ContainsKey(failed_tablet_ids, tablet_id)) continue; nit: What about removing non-exist tablets from `tablet_ids_to_copy` in advance? -- To view, visit http://gerrit.cloudera.org:8080/18448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4de49e948cc1a686db5e1bf424470ca9e800ee36 Gerrit-Change-Number: 18448 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Fri, 29 Apr 2022 09:38:39 + Gerrit-HasComments: Yes
