[kudu-CR] [metrics] Add metrics for create and delete op time
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21316 ) Change subject: [metrics] Add metrics for create and delete op time .. [metrics] Add metrics for create and delete op time Add server-level statistics to track the time consumption of create tablet and delete tablet operations. The addition of monitoring items will aid in historical issue tracking and analysis, as well as facilitate the configuration of monitoring alarms. Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Reviewed-on: http://gerrit.cloudera.org:8080/21316 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 4 files changed, 82 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [metrics] Add metrics for create and delete op time
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21316 ) Change subject: [metrics] Add metrics for create and delete op time .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 14:04:00 + Gerrit-HasComments: No
[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 9: > (1 comment) > > > (1 comment) > > > > I realized that, the only proper way to add a 2-way load barrier > is > > with > > std::atomic_thread_fence(std::memory_order_acquire), which is > more > > strict, than > > the 1-way std::atomic::load(std::memory_order_acquire); > > > > I made some performance test. I used TestScanPerformance from > > cbtree-test and > > TestMemRowSetUpdatePerformance from memrowset-test. I also added > 2 > > more > > performance tests, one using basic arena, one using > > ThreadSafeMemoryTrackingArena (we only use the 2nd in > production). > > I will add g++ tests too (as soon as it compiles). > > See the branches sheet for name resolution. > > For some reason, I assumed you were going to add those tests into > this patch or as a separate patch, but it seems by 'adding > > > https://docs.google.com/spreadsheets/d/1whl8h7S0DcjVYp0jksR87P9v4U8TQH9nS1C9N0D-lUo/edit?usp=sharing > > > (1 comment) > > > > I realized that, the only proper way to add a 2-way load barrier > is > > with > > std::atomic_thread_fence(std::memory_order_acquire), which is > more > > strict, than > > the 1-way std::atomic::load(std::memory_order_acquire); > > > > I made some performance test. I used TestScanPerformance from > > cbtree-test and > > TestMemRowSetUpdatePerformance from memrowset-test. I also added > 2 > > more > > performance tests, one using basic arena, one using > > ThreadSafeMemoryTrackingArena (we only use the 2nd in > production). > > I will add g++ tests too (as soon as it compiles). > > See the branches sheet for name resolution. > > For some reason, I assumed you were going to add your new tests as > a part of this changelist as well, but it seems you just meant > adding results from running those tests into the spreadsheet :) > > OK, maybe it makes sense to add your new tests into Kudu as well? > Feel free to post that as a separate changelist. > > Also, it would be great if you could address other feedback items > (nits, questions of other reviewers, etc.) and post a follow-up > revision, if necessary. > > Thanks! > > > https://docs.google.com/spreadsheets/d/1whl8h7S0DcjVYp0jksR87P9v4U8TQH9nS1C9N0D-lUo/edit?usp=sharing I run the arm tests on a c6g.2xlarge arm machine, and the x86 tests on a physical pc in the bp office (I can include the spec if you want). I thought only the changes matter (not the comparison of x86 and ARM), however I can try to rerun the tests on a similar x86 than the arm machine (c6i.2xlarge?)/ All times are in ms, the value that the google test prints (TestMemRowSetUpdatePerformance included). The (same platform) tests were run on the same machine. One at a time through ssh. No other task was taking place (I even closed VS Code to prevent it from doing any background task). x86_master_clang_2 and x86_master_clang are the same, only 3 hours apart (And I have no idea why the second run is a bit slower). My new tests are nearly the same as "TestConcurrentInsert", just using the ThreadSafeMemoryTrackingArena and the sizes that production actually uses. I could add a test with less inserts using this parameters. (If the tree works while it is small, it will work, when it is big, because threads will "collide" less often). I will post a separate gerrit for this test (Same as TestPerformanceThreadSafe, just runs <1s). -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Tue, 07 May 2024 13:14:22 + Gerrit-HasComments: No
[kudu-CR] [security-flags-itest] Fix missing command line flags
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21399 ) Change subject: [security-flags-itest] Fix missing command line flags .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/114/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec751e8761562612d97b886740c9b20cd134a0bc Gerrit-Change-Number: 21399 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 07 May 2024 12:58:25 + Gerrit-HasComments: No
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#13). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/13 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 13 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 13: Verified+1 Build Successful http://jenkins.kudu.apache.org/job/pre_commit/118/ : SUCCESS -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 13 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:51:53 + Gerrit-HasComments: No
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 13: Build Started http://jenkins.kudu.apache.org/job/pre_commit/118/ -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 13 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:51:32 + Gerrit-HasComments: No
[kudu-CR](gh-pages) gh-pages should not tirgger build
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21404 Change subject: gh-pages should not tirgger build .. gh-pages should not tirgger build Change-Id: I50aaf71ae5bf8a288d8c7347f1fe5ecdb5143654 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/21404/1 -- To view, visit http://gerrit.cloudera.org:8080/21404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: newchange Gerrit-Change-Id: I50aaf71ae5bf8a288d8c7347f1fe5ecdb5143654 Gerrit-Change-Number: 21404 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#11). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/11 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 11 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#12). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/12 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 12 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#10). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A docs/test.txt A test.txt 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/10 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 10 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 11: Build Aborted http://jenkins.kudu.apache.org/job/pre_commit/117/ : ABORTED -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 11 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:39:28 + Gerrit-HasComments: No
[kudu-CR] test
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21132 to look at the new patch set (#9). Change subject: test .. test docs changes should not tirgger build. Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 --- A test.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/21132/9 -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 9 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 11: Build Started http://jenkins.kudu.apache.org/job/pre_commit/117/ -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 11 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:37:42 + Gerrit-HasComments: No
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 10: Build Aborted http://jenkins.kudu.apache.org/job/pre_commit/116/ : ABORTED -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 10 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:37:03 + Gerrit-HasComments: No
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 10: Build Started http://jenkins.kudu.apache.org/job/pre_commit/116/ -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 10 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:36:17 + Gerrit-HasComments: No
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 9: Build Aborted http://jenkins.kudu.apache.org/job/pre_commit/115/ : ABORTED -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 9 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:35:22 + Gerrit-HasComments: No
[kudu-CR] test
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21132 ) Change subject: test .. Patch Set 9: Build Started http://jenkins.kudu.apache.org/job/pre_commit/115/ -- To view, visit http://gerrit.cloudera.org:8080/21132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7093fb9d52a9a2b48871c527cc09b25dcbd44bf4 Gerrit-Change-Number: 21132 Gerrit-PatchSet: 9 Gerrit-Owner: Marton Greber Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Tue, 07 May 2024 12:34:57 + Gerrit-HasComments: No
[kudu-CR](gh-pages) [blog] Fix typo in blogpost
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21378 ) Change subject: [blog] Fix typo in blogpost .. [blog] Fix typo in blogpost This patch adds a missing space for Backup and Restore heading and uniform some line spacings. Change-Id: Iec743b5151ac9c139d3b3513f99d0369cfe0fc93 Reviewed-on: http://gerrit.cloudera.org:8080/21378 Tested-by: Abhishek Chennaka Reviewed-by: Mahesh Reddy Reviewed-by: Alexey Serbin --- M _posts/2024-03-07-introducing-auto-incrementing-column.md 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Abhishek Chennaka: Verified Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: merged Gerrit-Change-Id: Iec743b5151ac9c139d3b3513f99d0369cfe0fc93 Gerrit-Change-Number: 21378 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber
[kudu-CR] [security-flags-itest] Fix missing command line flags
Anonymous Coward (763) has posted comments on this change. ( http://gerrit.cloudera.org:8080/21399 ) Change subject: [security-flags-itest] Fix missing command line flags .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21399/1/src/kudu/integration-tests/security-flags-itest.cc File src/kudu/integration-tests/security-flags-itest.cc: http://gerrit.cloudera.org:8080/#/c/21399/1/src/kudu/integration-tests/security-flags-itest.cc@54 PS1, Line 54: ASSERT_EQ The whole point of this test is that we can find the flag with its string name at runtime without declaring it in the current file, right? If you fix it here, what guarantees that the find will work in actual usage? Also, some questions: We test three other flags; why is this the only flag that needs to be declared? Why does it work in the Debug build, but not in the Release? I have the (clearly wrong) understanding that the DEFINE_string(...) macro contains some magic initialization that adds the string name to the FlagRegistry::flags_ variable. This flags_ variable is used by the SetCommandLineOption function. How can the linker throw it away? Additionally, this test fails on Ubuntu 18.04. I checked out the original Gerrit commit (https://gerrit.cloudera.org/#/c/20961/), where this test was added. It passes on the same Ubuntu 18.04 where the current master fails. The file itself is unchanged since. Please identify and fix the original problem, not just the unittest indicating the problem. -- To view, visit http://gerrit.cloudera.org:8080/21399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec751e8761562612d97b886740c9b20cd134a0bc Gerrit-Change-Number: 21399 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 07 May 2024 12:04:18 + Gerrit-HasComments: Yes
[kudu-CR] [security-flags-itest] Fix missing command line flags
Hello Mahesh Reddy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21399 to look at the new patch set (#2). Change subject: [security-flags-itest] Fix missing command line flags .. [security-flags-itest] Fix missing command line flags Change-Id: Iec751e8761562612d97b886740c9b20cd134a0bc --- M src/kudu/integration-tests/security-flags-itest.cc 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/21399/2 -- To view, visit http://gerrit.cloudera.org:8080/21399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec751e8761562612d97b886740c9b20cd134a0bc Gerrit-Change-Number: 21399 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Ádám Bakai
[kudu-CR] [security-flags-itest] Fix missing command line flags
Ádám Bakai has posted comments on this change. (
http://gerrit.cloudera.org:8080/21399 )
Change subject: [security-flags-itest] Fix missing command line flags
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21399/1/src/kudu/integration-tests/security-flags-itest.cc
File src/kudu/integration-tests/security-flags-itest.cc:
http://gerrit.cloudera.org:8080/#/c/21399/1/src/kudu/integration-tests/security-flags-itest.cc@50
PS1, Line 50: purpose
> nit: purposes
Done
http://gerrit.cloudera.org:8080/#/c/21399/1/src/kudu/integration-tests/security-flags-itest.cc@54
PS1, Line 54: ASSERT_EQ(FLAGS_rpc_authentication, "required");
> nit for {ASSERT,EXPECT}_EQ: the expected value comes first -- that way it's
Done
--
To view, visit http://gerrit.cloudera.org:8080/21399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec751e8761562612d97b886740c9b20cd134a0bc
Gerrit-Change-Number: 21399
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy
Gerrit-Reviewer: Ádám Bakai
Gerrit-Comment-Date: Tue, 07 May 2024 11:30:28 +
Gerrit-HasComments: Yes
[kudu-CR] [security-flags-itest] Fix missing command line flags
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21399 ) Change subject: [security-flags-itest] Fix missing command line flags .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/114/ -- To view, visit http://gerrit.cloudera.org:8080/21399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec751e8761562612d97b886740c9b20cd134a0bc Gerrit-Change-Number: 21399 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 07 May 2024 11:32:22 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add metrics for create and delete op time
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21316 ) Change subject: [metrics] Add metrics for create and delete op time .. Patch Set 5: Verified+1 Build Successful http://jenkins.kudu.apache.org/job/pre_commit/113/ : SUCCESS -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 10:25:16 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add metrics for create and delete op time
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21316 ) Change subject: [metrics] Add metrics for create and delete op time .. Patch Set 5: (6 comments) Thanks a lot for your reviews. http://gerrit.cloudera.org:8080/#/c/21316/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21316/1//COMMIT_MSG@11 PS1, Line 11: The addition of monitoring items will aid in historical issue : tracking and analysis, as well as > Yes: in general that makes sense, of course. I was just trying to say that Thank you for your additional reply. I will update the commit message to provide more specific descriptions of the use cases for these new monitoring items. http://gerrit.cloudera.org:8080/#/c/21316/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21316/4//COMMIT_MSG@11 PS4, Line 11: rical issue : tracking and analysis, as well a > How the stats on the duration of create/delete a tablet replica could help Thank you for your advice, it will indeed be helpful in real-time analysis of issues. Adding this part of operation time monitoring is mainly for historical issue tracking and analysis, as well as facilitating the configuration of monitoring alarms. These require adding new monitoring items to achieve. http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@273 PS4, Line 273: .", > What is the significance of this 'on the current node' part? All the table Done http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@274 PS4, Line 274: kDebu > Why kInfo, not kDebug? Looking at metrics like 'tablets_opening_time_start Done http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@281 PS4, Line 281: kDebu > ditto: maybe, kDebug is a better choice here? Done http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@1168 PS4, Line 1168: delete_tablet_run_time_->Increment( > Shouldn't the delete_tablet_run_time_ metric be updated before return here Done -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 09:28:56 + Gerrit-HasComments: Yes
[kudu-CR] [metrics] Add metrics for create and delete op time
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21316 ) Change subject: [metrics] Add metrics for create and delete op time .. Patch Set 5: Build Started http://jenkins.kudu.apache.org/job/pre_commit/113/ -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 09:27:36 + Gerrit-HasComments: No
[kudu-CR] [metrics] Add metrics for create and delete op time
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21316 to look at the new patch set (#5). Change subject: [metrics] Add metrics for create and delete op time .. [metrics] Add metrics for create and delete op time Add server-level statistics to track the time consumption of create tablet and delete tablet operations. The addition of monitoring items will aid in historical issue tracking and analysis, as well as facilitate the configuration of monitoring alarms. Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 --- M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 4 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/21316/5 -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] DONT BUILD KUDU-1261 Java client complex type introduction
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 ) Change subject: [WIP] DONT BUILD KUDU-1261 Java client complex type introduction .. Patch Set 3: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/112/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/20749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92825c4ab430ccd4bbd902b06679488af91d9804 Gerrit-Change-Number: 20749 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 07:35:30 + Gerrit-HasComments: No
[kudu-CR] [CMakeLists] Make kudu test main static
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 7: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 7 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 07 May 2024 07:26:40 + Gerrit-HasComments: No
[kudu-CR] [CMakeLists] Make kudu test main static
Alexey Serbin has removed a vote on this change. Change subject: [CMakeLists] Make kudu_test_main static .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 7 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai
[kudu-CR] [metrics] Add metrics for create and delete op time
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21316 ) Change subject: [metrics] Add metrics for create and delete op time .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/21316/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21316/1//COMMIT_MSG@11 PS1, Line 11: These monitoring metrics will be very helpful for analyzing : issues related to high CPU usage. > Thank you very much for your response. Yes: in general that makes sense, of course. I was just trying to say that creating/deleting a tablet replica is mostly disk IO, but not many CPU cycles. Adding metrics here and there might be a guessing game. If the goal is to spot CPU bottlenecks, I can also recommend using built-in tracing: https://kudu.apache.org/docs/troubleshooting.html#kudu_tracing In addition, running 'htop -p ' and performing stracing, etc. could pin-point particular threads that consume a lot of CPU. http://gerrit.cloudera.org:8080/#/c/21316/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21316/4//COMMIT_MSG@11 PS4, Line 11: analyzing : issues related to high CPU usage How the stats on the duration of create/delete a tablet replica could help with analyzing high CPU usage scenarios FWIW, most of the activity while creating/deleting a tablet is attributed to disk IO. If you are interested in tracking CPU usage of some activity (not attributed to IO wait times), I could recommend taking a look at the 'reactor_load_percent' metric. I hope this helps. http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@273 PS4, Line 273: What is the significance of this 'on the current node' part? All the tablet metrics are attributed to the node where the tablet replica is hosted, no? If so, maybe drop this part? http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@274 PS4, Line 274: Why kInfo, not kDebug? Looking at metrics like 'tablets_opening_time_startup', it seems this sort of metric is something that would be used mostly for troubleshooting. http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@281 PS4, Line 281: ditto: maybe, kDebug is a better choice here? http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@1168 PS4, Line 1168: Shouldn't the delete_tablet_run_time_ metric be updated before return here as well? -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 07:26:16 + Gerrit-HasComments: Yes
[kudu-CR] [WIP] DONT BUILD KUDU-1261 Java client complex type introduction
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20749 to look at the new patch set (#3). Change subject: [WIP] DONT BUILD KUDU-1261 Java client complex type introduction .. [WIP] DONT BUILD KUDU-1261 Java client complex type introduction This patch introduces complex type in Java client library. There is still work needed but the main feedback looking I am looking for in this revision is does the test case look like an acceptable way of exposing this feature through the API. Change-Id: I92825c4ab430ccd4bbd902b06679488af91d9804 --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java A java/kudu-client/src/main/java/org/apache/kudu/ComplexTypeArray.java M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java M java/kudu-client/src/test/java/org/TestSchema.java M src/kudu/common/common.proto 5 files changed, 113 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/20749/3 -- To view, visit http://gerrit.cloudera.org:8080/20749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I92825c4ab430ccd4bbd902b06679488af91d9804 Gerrit-Change-Number: 20749 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin
[kudu-CR] [WIP] DONT BUILD KUDU-1261 Java client complex type introduction
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 ) Change subject: [WIP] DONT BUILD KUDU-1261 Java client complex type introduction .. Patch Set 3: Build Started http://jenkins.kudu.apache.org/job/pre_commit/112/ -- To view, visit http://gerrit.cloudera.org:8080/20749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92825c4ab430ccd4bbd902b06679488af91d9804 Gerrit-Change-Number: 20749 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 07:29:46 + Gerrit-HasComments: No
[kudu-CR] [CMakeLists] Make kudu test main static
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. [CMakeLists] Make kudu_test_main static This change makes sure that kudu_util.so is loaded at the beginning of the library search order. This is needed because in unwind_safeness.cc there is a dlsym execution in the constructor function, that creates a wrapper for dlopen and dlclose to prevent a potential deadlock during unwind stack resolve. It looks for the next declaration of the functions called "dlopen" and "dlclose" in shared object files. If kudu_util is loaded too late, then it won't find these functions and throws an error. This happens in ubuntu 22.04 test runs. To solve this issue, the kudu_test_main was changed to a static library and kudu_util was moved to the front of the library list. This is a best effort fix, and it should only have impact on test execution. Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Reviewed-on: http://gerrit.cloudera.org:8080/21282 Tested-by: Alexey Serbin Reviewed-by: Alexey Serbin --- M src/kudu/util/CMakeLists.txt 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 8 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai
[kudu-CR] [CMakeLists] Make kudu test main static
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 7 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 07 May 2024 07:28:09 + Gerrit-HasComments: No
[kudu-CR] [CMakeLists] Make kudu test main static
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 7: Alright, if this helps in your environment, probably there is some value in this changelist. I couldn't see this happening in my Ubuntu 22.04 environments, though. Probably, there is something quite specific in your case and/or configuration. -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 7 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Reviewer: Ádám Bakai Gerrit-Comment-Date: Tue, 07 May 2024 07:28:08 + Gerrit-HasComments: No
