[kudu-CR](branch-1.15.x) [client] replace Equals() with operator==()
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17563 ) Change subject: [client] replace Equals() with operator==() .. [client] replace Equals() with operator==() This patch replaces the 'bool Equals(const X&)' method for Partition and PartitionSchema classes with 'bool operator==(const X&)'. For KuduSchema and KuduColumnSchema, both operator==() and operator!=() were introduced, and the Equals() method was marked as deprecated since KuduSchema's and KuduColumnsSchema's API are public at this point. I decided to perform minor refactoring while changing other code around: the presence of Equals() method looks a bit lame in a C++ API. This patch doesn't contain any functional modifications. Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Reviewed-on: http://gerrit.cloudera.org:8080/17558 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong (cherry picked from commit 79bd57546996c6e3c130960ba099fb637d58d51f) Reviewed-on: http://gerrit.cloudera.org:8080/17563 Reviewed-by: Bankim Bhavsar --- M src/kudu/client/client-test.cc M src/kudu/client/client-unittest.cc M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tools/table_scanner.cc 11 files changed, 117 insertions(+), 44 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: merged Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17563 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [client] replace Equals() with operator==()
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17563 ) Change subject: [client] replace Equals() with operator==() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17563 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Jun 2021 00:05:49 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [client] replace Equals() with operator==()
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17563 ) Change subject: [client] replace Equals() with operator==() .. Patch Set 1: Code-Review+2 LGTM but will defer to Bankim. -- To view, visit http://gerrit.cloudera.org:8080/17563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17563 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Jun 2021 21:14:21 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [client] replace Equals() with operator==()
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17563 ) Change subject: [client] replace Equals() with operator==() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17563/1//COMMIT_MSG Commit Message: PS1: Though not absolutely necessary to include into the upcoming 1.15 release, including this patch reduces the chance of conflicts in the related code if cherry-picking some changes from the main branch into branch-1.15.x in the future. -- To view, visit http://gerrit.cloudera.org:8080/17563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17563 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Jun 2021 17:45:34 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.15.x) [client] replace Equals() with operator==()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17563 Change subject: [client] replace Equals() with operator==() .. [client] replace Equals() with operator==() This patch replaces the 'bool Equals(const X&)' method for Partition and PartitionSchema classes with 'bool operator==(const X&)'. For KuduSchema and KuduColumnSchema, both operator==() and operator!=() were introduced, and the Equals() method was marked as deprecated since KuduSchema's and KuduColumnsSchema's API are public at this point. I decided to perform minor refactoring while changing other code around: the presence of Equals() method looks a bit lame in a C++ API. This patch doesn't contain any functional modifications. Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Reviewed-on: http://gerrit.cloudera.org:8080/17558 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong (cherry picked from commit 79bd57546996c6e3c130960ba099fb637d58d51f) --- M src/kudu/client/client-test.cc M src/kudu/client/client-unittest.cc M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tools/table_scanner.cc 11 files changed, 117 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/17563/1 -- To view, visit http://gerrit.cloudera.org:8080/17563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: newchange Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17563 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
