[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21007 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges This patch fixes WriteAsPrometheus() implementation for string-based gauges. The original changelist that introduced Prometheus metrics had a proper implementation of WriteAsPrometheus() only for StringGauge, but any FunctionGauge for a non-arithmetic type (e.g., for std::string) would still output a string value in Prometheus text format, and that could not be consumed by Prometheus. The patch also contains a test scenario that would fail without the fix. This is a follow-up to 00efc6826ac9a1f5d10750296c7357790a041fec. Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Reviewed-on: http://gerrit.cloudera.org:8080/20990 Tested-by: Alexey Serbin Reviewed-by: Marton Greber Reviewed-by: Attila Bukor (cherry picked from commit 6b1c1eb0c97a2349e0b3fa098bf40f8147b43a60) Conflicts: src/kudu/util/metrics.cc src/kudu/util/metrics.h Reviewed-on: http://gerrit.cloudera.org:8080/21007 Reviewed-by: Yingchun Lai --- M src/kudu/util/metrics-test.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 3 files changed, 98 insertions(+), 71 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Gerrit-Change-Number: 21007 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai
[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Gerrit-Change-Number: 21007 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai
[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21007 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/21007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Gerrit-Change-Number: 21007 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 07 Feb 2024 17:18:24 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21007 ) Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Gerrit-Change-Number: 21007 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 07 Feb 2024 09:29:07 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
Hello Marton Greber, Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21007 to review the following change. Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges .. KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges This patch fixes WriteAsPrometheus() implementation for string-based gauges. The original changelist that introduced Prometheus metrics had a proper implementation of WriteAsPrometheus() only for StringGauge, but any FunctionGauge for a non-arithmetic type (e.g., for std::string) would still output a string value in Prometheus text format, and that could not be consumed by Prometheus. The patch also contains a test scenario that would fail without the fix. This is a follow-up to 00efc6826ac9a1f5d10750296c7357790a041fec. Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Reviewed-on: http://gerrit.cloudera.org:8080/20990 Tested-by: Alexey Serbin Reviewed-by: Marton Greber Reviewed-by: Attila Bukor (cherry picked from commit 6b1c1eb0c97a2349e0b3fa098bf40f8147b43a60) Conflicts: src/kudu/util/metrics.cc src/kudu/util/metrics.h --- M src/kudu/util/metrics-test.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 3 files changed, 98 insertions(+), 71 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/21007/1 -- To view, visit http://gerrit.cloudera.org:8080/21007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b Gerrit-Change-Number: 21007 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Marton Greber
