[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc@54 PS2, Line 54: The masters will accept a : user-provided executable via the run-time `--location_mapping_cmd` : configuration flag to map machines to "locations". > Remove this? I think we can omit this detail in the release notes, given that the docs/administration.adoc has all the necessary details. -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Tue, 12 Feb 2019 08:53:41 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc@54 PS2, Line 54: The masters will accept a : user-provided executable via the run-time `--location_mapping_cmd` : configuration flag to map machines to "locations". Remove this? http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc@78 PS2, Line 78: improvements > I saw we have release note for KUDU-2636 in the gdoc as an improvement but Yeah, see Todd's comment: This makes me raise my eyebrows a bit. It sounds like a good thing. If it's a good thing why do I need to set a config? Also it seems this flag is marked experimental, and best I can tell from looking at the git log, we defaulted it to false because we found it made some tests crashy? Given that, maybe we should just wait until our next release, make it on by default, and document it as an improvement then? -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Mon, 11 Feb 2019 22:00:17 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/2/docs/release_notes.adoc@78 PS2, Line 78: improvements I saw we have release note for KUDU-2636 in the gdoc as an improvement but not here, Is that intentional? -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Mon, 11 Feb 2019 20:10:46 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 2: (21 comments) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@51 PS1, Line 51: > Looking at this, it looks like it was always unusable by clients because th Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@52 PS1, Line 52: [[rn_1.9.0_new_features]] : == New featur > +1 Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@57 PS1, Line 57: rity of r > drop the parenthesis: masters Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@58 PS1, Line 58: s been update > run-time configuration flag Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@59 PS1, Line 59: e with the p > "locations". Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@60 PS1, Line 60: nistrati > the majority of replicas Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@62 PS1, Line 62: un Kudu on various : operating sys > we should link to the appropriate docs here, and maybe even remove some of Ack http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@65 PS1, Line 65: he Kudu Dock > subdirectory of the source repository? Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@66 PS1, Line 66: * People wanting to integrate with Kudu can now write Java unit tests that > +1 Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@72 PS1, Line 72: artifacts when starting up, the `kudu-binary` module must be added as a test : time dependency, along with the `kudu-test-utils` module in the project’s : Maven or Gradle build. The binary test artifact is stil > writing nit: "Table creation checks now consider" was hard to parse because Ah you're right, I reworded this incorrectly. http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@79 PS1, Line 79: * When creating a table, the master now enforces a restriction on the total > can we say what metric this is? Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@80 PS1, Line 80: number of replicas rather than the total number of partitions. If manually > is this documented anywhere in our troubleshooting docs or somesuch? Not at the moment, no. Do you think it's not worth mentioning if we don't also provide a guide for how to use/understand it? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@81 PS1, Line 81: overriding `--max_create_tablets_per_ts`, the maximum size of a new table has : effectively been cut by a factor of its > Remove. Its value as a release note is pretty low, and it is easy to constr Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@83 PS1, Line 83: The compaction policy has been updated to > nit: I think this would be easier to understand if you said: "Scans which r Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@88 PS1, Line 88: much a replica needs to be compacted, as indicated by the average number of > This makes me raise my eyebrows a bit. It sounds like a good thing. If it's Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@91 PS1, Line 91: workload are now more CPU efficient. In some cases, scan performance of such > This isn't an incompatible change. It was done in a compatible way and the Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@98 PS1, Line 98: ias > add link Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@98 PS1, Line 98: * Added the short “kudu” format alias to Spark. This enables using > yea I think in general linking the word 'here' is also bad style Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@107 PS1, Line 107: primary key (see KUDU-2477). > To avoid glitches and undefined behavior, the Kudu Python client will now d Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@108 PS1, Line 108: > typo: a crash Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@167 PS1, Line 167: > typo Done -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12389 to look at the new patch set (#2). Change subject: WIP: add release notes for 1.9.0 .. WIP: add release notes for 1.9.0 WIP: - numerous tooling notes: - find row - scan - describe table - other bug fixes? - add links Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc --- M docs/release_notes.adoc 1 file changed, 72 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/12389/2 -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@66 PS1, Line 66: official artifactory has been created for Apache Kudu Docker artifacts > is "artifactory" the right term for docker? I thought it was a repository +1 http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@91 PS1, Line 91: * Apache Spark was upgraded to 2.4.0. As a part of this upgrade `spark-avro` > is this an incomptiable change if I'm using Kudu with an earlier version of This isn't an incompatible change. It was done in a compatible way and the api remains the same. -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Sat, 09 Feb 2019 02:34:24 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@51 PS1, Line 51: * KuduTable::ListPartitions() is now explicitly marked as private API. Looking at this, it looks like it was always unusable by clients because the class 'Partition' is not exported as part of the client library, right? ie a user could never have called this method to begin with because they couldn't make a 'vector'. Given that, does it need to be release-noted at all? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@52 PS1, Line 52: * Removed private API methods from the auto-generated documentation for Kudu : C++ client. > I'm not sure that's a deprecation, this is just an improvement on the docs +1 http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@62 PS1, Line 62: administrative : documentation we should link to the appropriate docs here, and maybe even remove some of the specific flag information from this release note to make it more concise http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@65 PS1, Line 65: subdirectory subdirectory of the source repository? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@66 PS1, Line 66: official artifactory has been created for Apache Kudu Docker artifacts is "artifactory" the right term for docker? I thought it was a repository http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@72 PS1, Line 72: * Table creation checks now consider the desired number of replicas instead of : the number of tablets. The default maximum size of a new table has effectively : been cut by a factor of the table's replication factor. writing nit: "Table creation checks now consider" was hard to parse because of "checks" being either a verb or a noun. I think it would be better to say "When creating a table, the master now enforces a restriction on the total number of replicas rather than the total number of partitions." That said, I thought we also bumped up the default for this value so effectively there is no change here for people using 3 replicas, and an increase for people using 1 replica? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@79 PS1, Line 79: * A tablet-level metric is added to indicate how much a replica needs to be can we say what metric this is? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@80 PS1, Line 80: compacted, as indicated by the average number of rowsets per unit of keyspace. is this documented anywhere in our troubleshooting docs or somesuch? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@83 PS1, Line 83: Multi-column scans of UPDATE heavy tables nit: I think this would be easier to understand if you said: "Scans which read multiple columns of tables undergoing a heavy UPDATE workload..." May also be good to say something about the relative performance improvement possible. maybe "In some cases, scan performance of such tables may be several times faster upon upgrading to this release." http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@88 PS1, Line 88: KUDU-2636). This makes me raise my eyebrows a bit. It sounds like a good thing. If it's a good thing why do I need to set a config? Also it seems this flag is marked experimental, and best I can tell from looking at the git log, we defaulted it to false because we found it made some tests crashy? Given that, maybe we should just wait until our next release, make it on by default, and document it as an improvement then? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@91 PS1, Line 91: * Apache Spark was upgraded to 2.4.0. As a part of this upgrade `spark-avro` is this an incomptiable change if I'm using Kudu with an earlier version of Spark? Maybe it should be moved up to the incompatible changes section and explicitly stated whether you can use kudu-spark from this kudu release against an older version of spark? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@98 PS1, Line 98: Spark integration documentation here has been updated to reflect this yea I think in general linking the word 'here' is also bad style http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@108 PS1, Line 108: * Fixed an crash caused by a race between altering tablet schemas and deleting typo: a crash http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@167 PS1, Line 167: form typo -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@52 PS1, Line 52: * Removed private API methods from the auto-generated documentation for Kudu : C++ client. I'm not sure that's a deprecation, this is just an improvement on the docs generated. The set of methods available for end-users is the same before and after this change. Maybe, move this into the 'Improvements' or just drop it because this is very insignificant? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@57 PS1, Line 57: master(s) drop the parenthesis: masters http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@58 PS1, Line 58: configuration run-time configuration flag http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@59 PS1, Line 59: "locations." "locations". http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@60 PS1, Line 60: replicas the majority of replicas http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@90 PS1, Line 90: , drop http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@107 PS1, Line 107: Proper handling of conflicting OpenSSL initialization in Python client. To avoid glitches and undefined behavior, the Kudu Python client will now detect and report on conflicting/incorrect initialization of the OpenSSL library. -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Sat, 09 Feb 2019 00:01:49 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@81 PS1, Line 81: * Kudu’s server-side scanners are now only accessible by the user who first : initialized the scanner (see KUDU-1918). Remove. Its value as a release note is pretty low, and it is easy to construe this as a gaping security hole when it isn't. -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 07 Feb 2019 22:18:25 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@98 PS1, Line 98: here add link -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Feb 2019 23:49:55 + Gerrit-HasComments: Yes
[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12389 Change subject: WIP: add release notes for 1.9.0 .. WIP: add release notes for 1.9.0 WIP: - flesh out docker note? - add a note for KUDU-2411: relocatable binaries? - numerous tooling notes: - find row - scan - describe table - other bug fixes? - omit KUDU-1918? reword it? - where do privatization changes go? - KuduTable::ListPartitions - removed C++ private methods from docs Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc --- M docs/release_notes.adoc 1 file changed, 66 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/12389/1 -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: newchange Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
