[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-13 Thread Grant Henke (Code Review) 
Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16943 )

Change subject: [build] Add more options to the compatibility checker script
..

[build] Add more options to the compatibility checker script

This patch adjusts the argument parsing and adds more argument
options to the compatibility checker script. These options are useful
for filtering down to various report granularities and issues.

Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Reviewed-on: http://gerrit.cloudera.org:8080/16943
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M build-support/check_compatibility.py
1 file changed, 45 insertions(+), 30 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-13 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16943 )

Change subject: [build] Add more options to the compatibility checker script
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py
File build-support/check_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py@216
PS2, Line 216:   parser.add_argument("--force-download-deps", 
action='store_true',
 :   help="Download dependencies (i.e. japicmp) 
even if they are already present")
> --force-download-deps is used in the call to download_japicmp. See `downloa
Whoops, my bad: I was searching for 'force-download', but in the code it's 
'force_download_...', of course.



--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Jan 2021 19:53:00 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-13 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16943 )

Change subject: [build] Add more options to the compatibility checker script
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16943/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16943/2//COMMIT_MSG@10
PS2, Line 10: chekcer
> checker
Done


http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py
File build-support/check_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py@216
PS2, Line 216:   parser.add_argument("--force-download-deps", 
action='store_true',
 :   help="Download dependencies (i.e. japicmp) 
even if they are already present")
> I could not find the code that uses this newly introduced option in run_jap
--force-download-deps is used in the call to download_japicmp. See 
`download_japicmp(opts.force_download_deps)` below.

This option isn't new, just adjusted from --force-download to match the common 
argparse usage patterns.



--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Jan 2021 18:57:14 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-13 Thread Grant Henke (Code Review) 
Hello Alexey Serbin, Kudu Jenkins, Greg Solovyev, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16943

to look at the new patch set (#3).

Change subject: [build] Add more options to the compatibility checker script
..

[build] Add more options to the compatibility checker script

This patch adjusts the argument parsing and adds more argument
options to the compatibility checker script. These options are useful
for filtering down to various report granularities and issues.

Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
---
M build-support/check_compatibility.py
1 file changed, 45 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/16943/3
--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-13 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16943 )

Change subject: [build] Add more options to the compatibility checker script
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16943/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16943/2//COMMIT_MSG@10
PS2, Line 10: chekcer
checker


http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py
File build-support/check_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py@216
PS2, Line 216:   parser.add_argument("--force-download-deps", 
action='store_true',
 :   help="Download dependencies (i.e. japicmp) 
even if they are already present")
I could not find the code that uses this newly introduced option in 
run_japicmp(): not sure I understand how this can work.  Maybe, there is some 
Python magic around this?



--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Jan 2021 18:49:19 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-13 Thread Greg Solovyev (Code Review) 
Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16943 )

Change subject: [build] Add more options to the compatibility checker script
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Jan 2021 18:24:32 +
Gerrit-HasComments: No

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-12 Thread Grant Henke (Code Review) 
Hello Alexey Serbin, Kudu Jenkins, Greg Solovyev,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16943

to look at the new patch set (#2).

Change subject: [build] Add more options to the compatibility checker script
..

[build] Add more options to the compatibility checker script

This patch adjusts the argument parsing and adds more argument
options to the compatibility chekcer script. These options are useful
for filtering down to various report granularities and issues.

Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
---
M build-support/check_compatibility.py
1 file changed, 45 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/16943/2
--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Add more options to the compatibility checker script

2021-01-12 Thread Grant Henke (Code Review) 
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16943


Change subject: [build] Add more options to the compatibility checker script
..

[build] Add more options to the compatibility checker script

This patch adjusts the argument parsing and adds more argument options to the
compatibility chekcer script. These options are useful for filtering down to 
various
report granularities and issues.

Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
---
M build-support/check_compatibility.py
1 file changed, 45 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/16943/1
--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke