[kudu-CR] [build] Automate using GCC-8 on SLES 12
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16927 ) Change subject: [build] Automate using GCC-8 on SLES 12 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@46 PS2, Line 46: "$CC" -a ! "$CXX" > I thought about this but chose to match the existing behavior and expect th yep, this makes sense to me http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@53 PS2, Line 53: /usr/bin/gcc-8 > I was on the fence about it. We can definitely do that in a follow up and t ack -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 18:45:23 + Gerrit-HasComments: Yes
[kudu-CR] [build] Automate using GCC-8 on SLES 12
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16927 ) Change subject: [build] Automate using GCC-8 on SLES 12 .. [build] Automate using GCC-8 on SLES 12 When building Kudu on SLES 12 a newer version of GCC is required. This patch adjusts the documentation and automates the use of GCC-8 via the `enable_devtoolset.sh` script. This matches how we use newer dev toolsets on RHEL based systems. Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Reviewed-on: http://gerrit.cloudera.org:8080/16927 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- A build-support/ccache-gcc-8/c++ A build-support/ccache-gcc-8/cc M build-support/enable_devtoolset.sh M docs/installation.adoc M thirdparty/preflight.py 5 files changed, 92 insertions(+), 16 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Automate using GCC-8 on SLES 12
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16927 ) Change subject: [build] Automate using GCC-8 on SLES 12 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@46 PS2, Line 46: "$CC" -a ! "$CXX" > Just to make sure: we don't want to handle the case case if CC is set but C I thought about this but chose to match the existing behavior and expect that case to be rare. We can improve this script in follow up changes to be more flexible. http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@53 PS2, Line 53: /usr/bin/gcc-8 > nit: may it be a case when /usr/bin/gcc-8 isn't available? Should we bail I was on the fence about it. We can definitely do that in a follow up and the failure should be obvious if it is missing as is too. -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 18:07:18 + Gerrit-HasComments: Yes
[kudu-CR] [build] Automate using GCC-8 on SLES 12
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16927 ) Change subject: [build] Automate using GCC-8 on SLES 12 .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@46 PS2, Line 46: "$CC" -a ! "$CXX" Just to make sure: we don't want to handle the case case if CC is set but CXX isn't, right? I guess such environment may bring some inconsistent result down the road, but I guess this script isn't the place to handle that anyways. http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@53 PS2, Line 53: /usr/bin/gcc-8 nit: may it be a case when /usr/bin/gcc-8 isn't available? Should we bail early (i.e. right here) in such case? -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 17:55:00 + Gerrit-HasComments: Yes
[kudu-CR] [build] Automate using GCC-8 on SLES 12
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16927 to look at the new patch set (#2). Change subject: [build] Automate using GCC-8 on SLES 12 .. [build] Automate using GCC-8 on SLES 12 When building Kudu on SLES 12 a newer version of GCC is required. This patch adjusts the documentation and automates the use of GCC-8 via the `enable_devtoolset.sh` script. This matches how we use newer dev toolsets on RHEL based systems. Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b --- A build-support/ccache-gcc-8/c++ A build-support/ccache-gcc-8/cc M build-support/enable_devtoolset.sh M docs/installation.adoc M thirdparty/preflight.py 5 files changed, 92 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/16927/2 -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Automate using GCC-8 on SLES 12
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16927 Change subject: [build] Automate using GCC-8 on SLES 12 .. [build] Automate using GCC-8 on SLES 12 When building Kudu on SLES 12 a newer version of GCC is required. This patch adjusts the documentation and automates the use of GCC-8 via the `enable_devtoolset.sh` script. This matches how we use newer dev toolsets on RHEL based systems. Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b --- A build-support/ccache-gcc-8/c++ A build-support/ccache-gcc-8/cc M build-support/enable_devtoolset.sh M docs/installation.adoc M thirdparty/preflight.py 5 files changed, 92 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/16927/1 -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
