[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-15 Thread Attila Bukor (Code Review) 
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16953 )

Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@15
PS1, Line 15: the `kudu-rpc` module in API compatibility and test
> I'd lean towards kudu-proto, given it's the most accurate of the options IM
It's true that it's the most accurate for now, but isn't it possible that we 
would generate some other code in the future?



--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 Jan 2021 11:32:03 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16953 )

Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG
Commit Message:

PS1:
> I'm curious how you spotted this. Just noticed it going through build logs?
Nevermind, I see it from the code coverage test.



--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Jan 2021 23:55:05 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16953 )

Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..


Patch Set 1: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG
Commit Message:

PS1:
I'm curious how you spotted this. Just noticed it going through build logs?


http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@7
PS1, Line 7: [build] Seperate protobuf java compilation into a seperate module
nit: separate, same elsewhere


http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@15
PS1, Line 15: the `kudu-rpc` module in API compatibility and test
> A better name for this might be `kudu-proto` or `kudu-gen` given more code
I'd lean towards kudu-proto, given it's the most accurate of the options IMO



--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Jan 2021 23:50:44 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16953 )

Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Jan 2021 21:52:38 +
Gerrit-HasComments: No

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review) 
Grant Henke has removed a vote on this change.

Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16953 )

Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@15
PS1, Line 15: the `kudu-rpc` module in API compatibility and test
A better name for this might be `kudu-proto` or `kudu-gen` given more code is 
generated than just rpc code. I am open to suggestions.



--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Jan 2021 20:36:59 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Seperate protobuf java compilation into a seperate module

2021-01-14 Thread Grant Henke (Code Review) 
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16953


Change subject: [build] Seperate protobuf java compilation into a seperate 
module
..

[build] Seperate protobuf java compilation into a seperate module

Currently we compile the RPC Protobufs in both the kudu-client
and the kudu-subprocess. Doing this also combines them onto
the same classpath as the module itself.

This patch breaks those classes into a seperate `kudu-rpc`
module so that we can avoid duplicate work and ignore
the `kudu-rpc` module in API compatibility and test
coverage checks.

This module is not published, so there is no net change to the final
artifacts.

Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
---
M build-support/check_compatibility.py
M java/kudu-client/build.gradle
A java/kudu-rpc/build.gradle
M java/kudu-subprocess/build.gradle
M java/settings.gradle
5 files changed, 46 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/16953/1
--
To view, visit http://gerrit.cloudera.org:8080/16953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d
Gerrit-Change-Number: 16953
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke