Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16953 )
Change subject: [build] Seperate protobuf java compilation into a seperate module ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG Commit Message: PS1: I'm curious how you spotted this. Just noticed it going through build logs? http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@7 PS1, Line 7: [build] Seperate protobuf java compilation into a seperate module nit: separate, same elsewhere http://gerrit.cloudera.org:8080/#/c/16953/1//COMMIT_MSG@15 PS1, Line 15: the `kudu-rpc` module in API compatibility and test > A better name for this might be `kudu-proto` or `kudu-gen` given more code I'd lean towards kudu-proto, given it's the most accurate of the options IMO -- To view, visit http://gerrit.cloudera.org:8080/16953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib83db74c4a09cdd597bee90f5124ed804adac42d Gerrit-Change-Number: 16953 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Jan 2021 23:50:44 +0000 Gerrit-HasComments: Yes
