[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Dan Burkert (Code Review) 
Dan Burkert has submitted this change and it was merged.

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..


[doc] KUDU-1627 Potentially Missing words in the quick start doc

Asciidoc was considering * as special markup for formatted
text and highlighting text in between.

Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Reviewed-on: http://gerrit.cloudera.org:8080/4480
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..


Patch Set 3: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Ninad Shringarpure (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4480

to look at the new patch set (#3).

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..

[doc] KUDU-1627 Potentially Missing words in the quick start doc

Asciidoc was considering * as special markup for formatted
text and highlighting text in between.

Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-22 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4480/2//COMMIT_MSG
Commit Message:

Line 19: Added formatting as `{asterisk}` as suggested.
Please consolidate the commit message so that it reads just as a summary of the 
total change (rather than containing the history of revisions of the patch).

The idea here is that, during code review, it's easy for us to just look at the 
different revisions to see what changed. But, the commit message becomes a 
permanent part of the source history, and if we look at the log in a year we 
won't really care that there was an earlier version of this patch that did 
something differently.

Hope that makes sense, sorry for the pedantry.


-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-20 Thread Ninad Shringarpure (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4480

to look at the new patch set (#2).

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..

[doc] KUDU-1627 Potentially Missing words in the quick start doc

Asciidoc was considering  as special markup for formatted
text and highlighting text in between.

Removed the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change
--
Added formatting as `{asterisk}` as suggested.

Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-20 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4480/1//COMMIT_MSG
Commit Message:

PS1, Line 9:   a
did you miss a letter in your commit message? ironic :)


http://gerrit.cloudera.org:8080/#/c/4480/1/docs/quickstart.adoc
File docs/quickstart.adoc:

PS1, Line 168:  *
would the asciidoc syntax: `{asterisk}` work? See 
http://asciidoctor.org/docs/user-manual/#charref-attributes


-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [doc] KUDU-1627 Potentially Missing words in the quick start doc

2016-09-20 Thread Ninad Shringarpure (Code Review) 
Ninad Shringarpure has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4480

Change subject: [doc] KUDU-1627 Potentially Missing words in the quick start doc
..

[doc] KUDU-1627 Potentially Missing words in the quick start doc

Asciidoc was considering  as special markup for formatted
text and highlighting text in between.

Removed the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
---
M docs/quickstart.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/4480/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ab8f1a143b112ef4c43b1299ef67023cd74f98c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure