[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-08 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..

[hybrid_clock-test] adapt the test for OS X

Fixed linkage breakage on OS X: adapted the hybrid_clock-test for OS X.

Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Reviewed-on: http://gerrit.cloudera.org:8080/8488
Tested-by: Alexey Serbin 
Reviewed-by: Todd Lipcon 
Reviewed-by: Dan Burkert 
---
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/system_ntp.cc
M src/kudu/clock/system_unsync_time.cc
3 files changed, 20 insertions(+), 11 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Todd Lipcon: Looks good to me, but someone else must approve
  Dan Burkert: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-08 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 08 Nov 2017 17:41:10 +
Gerrit-HasComments: No

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-07 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8488/2/src/kudu/clock/hybrid_clock-test.cc
File src/kudu/clock/hybrid_clock-test.cc:

http://gerrit.cloudera.org:8080/#/c/8488/2/src/kudu/clock/hybrid_clock-test.cc@45
PS2, Line 45: DECLARE_bool(inject_unsync_time_errors);
I think it'd be cleaner to rename the existing 'inject_adjtimex_errors' to 
'inject_unsync_time_errors', and then use it from both TimeService 
implementations.  The only issue is where to define it - the obvious place is 
time_service.cc, but that doesn't exist yet.  It could, though.



--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 07 Nov 2017 21:25:15 +
Gerrit-HasComments: Yes

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-07 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Patch Set 3: Verified+1

unrelated flake in Shards/FlexPartitioningITest.TestFlexPartitioning/31


--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 08 Nov 2017 05:44:46 +
Gerrit-HasComments: No

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-07 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-07 Thread Alexey Serbin (Code Review) 
Hello Dan Burkert, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8488

to look at the new patch set (#3).

Change subject: [hybrid_clock-test] adapt the test for OS X
..

[hybrid_clock-test] adapt the test for OS X

Fixed linkage breakage on OS X: adapted the hybrid_clock-test for OS X.

Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
---
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/system_ntp.cc
M src/kudu/clock/system_unsync_time.cc
3 files changed, 20 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8488/3
--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-07 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8488/2/src/kudu/clock/hybrid_clock-test.cc
File src/kudu/clock/hybrid_clock-test.cc:

http://gerrit.cloudera.org:8080/#/c/8488/2/src/kudu/clock/hybrid_clock-test.cc@45
PS2, Line 45: DECLARE_bool(inject_unsync_time_errors);
> I think it'd be cleaner to rename the existing 'inject_adjtimex_errors' to
It's a good idea.  I put the definition of the flag into system_unsync_time.cc 
file, since it's compiled regardless of the platform/OS.



--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 08 Nov 2017 04:41:50 +
Gerrit-HasComments: Yes

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Patch Set 2: Verified+1

unrelated flakes in:
  * MultiThreadedTabletTest/2.DeleteAndReinsert
  * AdminCliTest.TestMoveTablet


--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 07 Nov 2017 06:52:22 +
Gerrit-HasComments: No

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/8488 )

Change subject: [hybrid_clock-test] adapt the test for OS X
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review) 
Hello Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8488

to look at the new patch set (#2).

Change subject: [hybrid_clock-test] adapt the test for OS X
..

[hybrid_clock-test] adapt the test for OS X

Fixed linkage breakage on OS X: adapted the hybrid_clock-test for OS X.

Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
---
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/system_unsync_time.cc
2 files changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8488/2
--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8488


Change subject: [hybrid_clock-test] adapt the test for OS X
..

[hybrid_clock-test] adapt the test for OS X

Fixed linkage breakage on OS X: adapted the hybrid_clock-test for OS X.

Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
---
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/system_unsync_time.cc
2 files changed, 21 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8488/1
--
To view, visit http://gerrit.cloudera.org:8080/8488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c
Gerrit-Change-Number: 8488
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin