[kudu-CR] [java] Remove private method usage in kudu-mapreduce
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10424 ) Change subject: [java] Remove private method usage in kudu-mapreduce .. [java] Remove private method usage in kudu-mapreduce kudu-mapreduce uses private APIs from KuduPredicate. This is an issue because the API returns a protobuf generated class and uses shaded APIs. This isn’t strictly an issue in the gradle build itself because calling the shaded methods is ok, but it is an issue in IDEs like Intellij. Regardless a shaded dependency is not part of the public API and should not be exposed/used because it can cause problems like this. A follow on patch will work on enforcing that protobuf is not exposed in the client API so this doesn’t happen again. Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a Reviewed-on: http://gerrit.cloudera.org:8080/10424 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java 3 files changed, 38 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a Gerrit-Change-Number: 10424 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [java] Remove private method usage in kudu-mapreduce
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/10424 )
Change subject: [java] Remove private method usage in kudu-mapreduce
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java:
http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java@1106
PS1, Line 1106: public String toString() {
> I wonder if we'd be better served building a serializer/deserializer around
I agree. The same may be true for scan token serialization.
--
To view, visit http://gerrit.cloudera.org:8080/10424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Gerrit-Change-Number: 10424
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Wed, 16 May 2018 17:40:23 +
Gerrit-HasComments: Yes
[kudu-CR] [java] Remove private method usage in kudu-mapreduce
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/10424 )
Change subject: [java] Remove private method usage in kudu-mapreduce
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java:
http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java@1106
PS1, Line 1106: public String toString() {
I wonder if we'd be better served building a serializer/deserializer around the
string representation of KuduPredicate.
A project for another time.
--
To view, visit http://gerrit.cloudera.org:8080/10424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a
Gerrit-Change-Number: 10424
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Wed, 16 May 2018 17:38:35 +
Gerrit-HasComments: Yes
[kudu-CR] [java] Remove private method usage in kudu-mapreduce
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10424 Change subject: [java] Remove private method usage in kudu-mapreduce .. [java] Remove private method usage in kudu-mapreduce kudu-mapreduce uses private APIs from KuduPredicate. This is an issue because the API returns a protobuf generated class and uses shaded APIs. This isn’t strictly an issue in the gradle build itself because calling the shaded methods is ok, but it is an issue in IDEs like Intellij. Regardless a shaded dependency is not part of the public API and should not be exposed/used because it can cause problems like this. A follow on patch will work on enforcing that protobuf is not exposed in the client API so this doesn’t happen again. Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java 3 files changed, 38 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/10424/1 -- To view, visit http://gerrit.cloudera.org:8080/10424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a Gerrit-Change-Number: 10424 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
