[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. [thirdparty] Force Boost to use /dev/random for uuid This patch adjusts the Boost thirdparty build to force it to use /dev/random instead of getrandom(2) which is used by deafult when compiled on Linux 3.17 or later. In the latest Kudu 1.14.0 binary jar we saw crashes in Hive pre-commit tests because that jar was compiled on CentOS 7 and therefore used a getrandom(2) call which was not available in the Hive precommit container. Below is an example failure log: INFO [cluster stderr printer] cluster.MiniKuduCluster: terminate called after throwing an instance of 'boost::wrapexcept' INFO [cluster stderr printer] cluster.MiniKuduCluster: what(): getrandom INFO [cluster stderr printer] cluster.MiniKuduCluster: *** Aborted at 1616564512 (unix time) try "date -d @1616564512" if you are using GNU date *** INFO [cluster stderr printer] cluster.MiniKuduCluster: PC: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: *** SIGABRT (@0x9c451e8) received by PID 20968 (TID 0x7f67d0c23a00) from PID 20968; stack trace: *** INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d442f201 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d65e1630 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f97ac8 __GI_abort INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a79d5 __gnu_cxx::__verbose_terminate_handler() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5946 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5973 std::terminate() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5b93 __cxa_throw INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d478c138 boost::throw_exception<>() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d47c2d9d kudu::ObjectIdGenerator::Next() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9906c kudu::FsManager::CreateInstanceMetadata() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9f4df kudu::FsManager::CreateInitialFileSystemLayout() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8e6dc46 kudu::server::ServerBase::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9f9e8ba kudu::kserver::KuduServer::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9ed36af kudu::master::Master::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9eecaa6 kudu::master::RunMasterServer() ... Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Reviewed-on: http://gerrit.cloudera.org:8080/17354 Tested-by: Grant Henke Reviewed-by: Alexey Serbin --- M thirdparty/build-definitions.sh 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Grant Henke: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 29 Apr 2021 15:04:47 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 13:10:52 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Grant Henke has removed a vote on this change. Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17354/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17354/2//COMMIT_MSG@13 PS2, Line 13: In the latest Kudu 1.14.0 binary jar we saw crashes in Hive : pre-commit tests because that jar was compiled on CentOS 7 : and therefore used a getrandom(2) call which was not available : in the Hive precommit container. > Just verified that on one server machine with CentOS 7.3 the kernel version This should fix the Hive pre-commit tests once a new version of the binary jar with this fix is consumed. Unless I am missing something. Regardless I was planning to test the change. We could ensure we compile with a specific Linux version at release time, however the build pipeline where this issue was observed is a more automated thirdparty build. I didn't see much of a downside for this change and I figured a change that made for more transportable binary was good regardless. -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 13:01:46 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17354/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17354/2//COMMIT_MSG@13 PS2, Line 13: In the latest Kudu 1.14.0 binary jar we saw crashes in Hive : pre-commit tests because that jar was compiled on CentOS 7 : and therefore used a getrandom(2) call which was not available : in the Hive precommit container. > A couple of questions here: Just verified that on one server machine with CentOS 7.3 the kernel version is 3.10.x (probably, the kernel even was updated, actually): va1022:java[tls-1.3-java-mc]$ lsb_release -a LSB Version: :core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch Distributor ID: CentOS Description:CentOS Linux release 7.3.1611 (Core) Release:7.3.1611 Codename: Core va1022:java[tls-1.3-java-mc]$ uname -r 3.10.0-514.10.2.el7.x86_64 -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 04:20:55 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17354/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17354/2//COMMIT_MSG@13 PS2, Line 13: In the latest Kudu 1.14.0 binary jar we saw crashes in Hive : pre-commit tests because that jar was compiled on CentOS 7 : and therefore used a getrandom(2) call which was not available : in the Hive precommit container. A couple of questions here: * Is this patch going to fix the issue with crashes in Hive pre-commit tests? I guess no, right? * What if we instead recompile the binary jar at CentOS7 with original kernel version (it's 3.10.x or something)? -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 04:12:41 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17354 to look at the new patch set (#3). Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. [thirdparty] Force Boost to use /dev/random for uuid This patch adjusts the Boost thirdparty build to force it to use /dev/random instead of getrandom(2) which is used by deafult when compiled on Linux 3.17 or later. In the latest Kudu 1.14.0 binary jar we saw crashes in Hive pre-commit tests because that jar was compiled on CentOS 7 and therefore used a getrandom(2) call which was not available in the Hive precommit container. Below is an example failure log: INFO [cluster stderr printer] cluster.MiniKuduCluster: terminate called after throwing an instance of 'boost::wrapexcept' INFO [cluster stderr printer] cluster.MiniKuduCluster: what(): getrandom INFO [cluster stderr printer] cluster.MiniKuduCluster: *** Aborted at 1616564512 (unix time) try "date -d @1616564512" if you are using GNU date *** INFO [cluster stderr printer] cluster.MiniKuduCluster: PC: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: *** SIGABRT (@0x9c451e8) received by PID 20968 (TID 0x7f67d0c23a00) from PID 20968; stack trace: *** INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d442f201 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d65e1630 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f97ac8 __GI_abort INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a79d5 __gnu_cxx::__verbose_terminate_handler() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5946 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5973 std::terminate() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5b93 __cxa_throw INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d478c138 boost::throw_exception<>() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d47c2d9d kudu::ObjectIdGenerator::Next() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9906c kudu::FsManager::CreateInstanceMetadata() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9f4df kudu::FsManager::CreateInitialFileSystemLayout() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8e6dc46 kudu::server::ServerBase::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9f9e8ba kudu::kserver::KuduServer::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9ed36af kudu::master::Master::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9eecaa6 kudu::master::RunMasterServer() ... Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c --- M thirdparty/build-definitions.sh 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17354/3 -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@842 PS2, Line 842: EXTRA_CFLAGS > Should this be BOOST_CFLAGS instead to not override the flags set a couple Done http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@842 PS2, Line 842: -fPIC > This is already added at line 835, no? Done http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@843 PS2, Line 843: -fPIC > Drop this since -fPIC is already added at line 836? Done http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@843 PS2, Line 843: EXTRA_CXXFLAGS > ditto Done http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@847 PS2, Line 847: # BOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX > nit: remove this extra commented line? Done -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 04:01:48 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@842 PS2, Line 842: -fPIC This is already added at line 835, no? http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@842 PS2, Line 842: EXTRA_CFLAGS Should this be BOOST_CFLAGS instead to not override the flags set a couple of lines above? http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@843 PS2, Line 843: EXTRA_CXXFLAGS ditto http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@843 PS2, Line 843: -fPIC Drop this since -fPIC is already added at line 836? http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@847 PS2, Line 847: # BOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX nit: remove this extra commented line? -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 03:54:27 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17354 to look at the new patch set (#2). Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. [thirdparty] Force Boost to use /dev/random for uuid This patch adjusts the Boost thirdparty build to force it to use /dev/random instead of getrandom(2) which is used by deafult when compiled on Linux 3.17 or later. In the latest Kudu 1.14.0 binary jar we saw crashes in Hive pre-commit tests because that jar was compiled on CentOS 7 and therefore used a getrandom(2) call which was not available in the Hive precommit container. Below is an example failure log: INFO [cluster stderr printer] cluster.MiniKuduCluster: terminate called after throwing an instance of 'boost::wrapexcept' INFO [cluster stderr printer] cluster.MiniKuduCluster: what(): getrandom INFO [cluster stderr printer] cluster.MiniKuduCluster: *** Aborted at 1616564512 (unix time) try "date -d @1616564512" if you are using GNU date *** INFO [cluster stderr printer] cluster.MiniKuduCluster: PC: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: *** SIGABRT (@0x9c451e8) received by PID 20968 (TID 0x7f67d0c23a00) from PID 20968; stack trace: *** INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d442f201 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d65e1630 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f97ac8 __GI_abort INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a79d5 __gnu_cxx::__verbose_terminate_handler() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5946 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5973 std::terminate() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5b93 __cxa_throw INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d478c138 boost::throw_exception<>() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d47c2d9d kudu::ObjectIdGenerator::Next() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9906c kudu::FsManager::CreateInstanceMetadata() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9f4df kudu::FsManager::CreateInitialFileSystemLayout() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8e6dc46 kudu::server::ServerBase::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9f9e8ba kudu::kserver::KuduServer::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9ed36af kudu::master::Master::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9eecaa6 kudu::master::RunMasterServer() ... Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c --- M thirdparty/build-definitions.sh 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17354/2 -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17354 Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. [thirdparty] Force Boost to use /dev/random for uuid This patch adjusts the Boost thirdparty build to force it to use /dev/random instead of getrandom(2) which is used by deafult when compiled on Linux 3.17 or later. In the latest Kudu 1.14.0 binary jar we saw crashes in Hive pre-commit tests because that jar was compiled on CentOS 7 and therefore used a getrandom(2) call which was not available in the Hive precommit container. Below is an example failure log: INFO [cluster stderr printer] cluster.MiniKuduCluster: terminate called after throwing an instance of 'boost::wrapexcept' INFO [cluster stderr printer] cluster.MiniKuduCluster: what(): getrandom INFO [cluster stderr printer] cluster.MiniKuduCluster: *** Aborted at 1616564512 (unix time) try "date -d @1616564512" if you are using GNU date *** INFO [cluster stderr printer] cluster.MiniKuduCluster: PC: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: *** SIGABRT (@0x9c451e8) received by PID 20968 (TID 0x7f67d0c23a00) from PID 20968; stack trace: *** INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d442f201 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d65e1630 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f963d7 __GI_raise INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d1f97ac8 __GI_abort INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a79d5 __gnu_cxx::__verbose_terminate_handler() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5946 (unknown) INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5973 std::terminate() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d28a5b93 __cxa_throw INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d478c138 boost::throw_exception<>() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d47c2d9d kudu::ObjectIdGenerator::Next() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9906c kudu::FsManager::CreateInstanceMetadata() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8d9f4df kudu::FsManager::CreateInitialFileSystemLayout() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d8e6dc46 kudu::server::ServerBase::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9f9e8ba kudu::kserver::KuduServer::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9ed36af kudu::master::Master::Init() INFO [cluster stderr printer] cluster.MiniKuduCluster: @ 0x7f67d9eecaa6 kudu::master::RunMasterServer() ... Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c --- M thirdparty/build-definitions.sh 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/17354/1 -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
