[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8396 )

Change subject: [tools] limit per-session error buffer space
..

[tools] limit per-session error buffer space

Introduced --error-buffer-size-bytes flag to control the size of the
per-session error buffer.  By default, the limit is set to 16MB per
session (i.e. per worker thread).

Prior to this patch, the per-session error buffer had no size limit
and could grow very large because of huge number of errors during the
run (e.g., because of duplicate value errors).

I also updated the in-line documentation to add an example of using
the tool for subsequent runs against the same table using the
--seq-start flag.

Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Reviewed-on: http://gerrit.cloudera.org:8080/8396
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 41 insertions(+), 11 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8396 )

Change subject: [tools] limit per-session error buffer space
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Oct 2017 18:30:31 +
Gerrit-HasComments: No

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Alexey Serbin (Code Review) 
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8396

to look at the new patch set (#4).

Change subject: [tools] limit per-session error buffer space
..

[tools] limit per-session error buffer space

Introduced --error-buffer-size-bytes flag to control the size of the
per-session error buffer.  By default, the limit is set to 16MB per
session (i.e. per worker thread).

Prior to this patch, the per-session error buffer had no size limit
and could grow very large because of huge number of errors during the
run (e.g., because of duplicate value errors).

I also updated the in-line documentation to add an example of using
the tool for subsequent runs against the same table using the
--seq-start flag.

Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 41 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/8396/4
--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8396 )

Change subject: [tools] limit per-session error buffer space
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc
File src/kudu/tools/tool_action_perf.cc:

http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@88
PS3, Line 88: consider using the
> Nit: simplify to "use the"
Done


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@89
PS3, Line 89: Here is an example
> Nit: "For example" (simpler)
Done


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@185
PS3, Line 185: might
> Nit: may
Done


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@219
PS3, Line 219:  "buffer space might impose an additional upper 
limit for the "
> Nit: may
Done



--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Oct 2017 18:09:32 +
Gerrit-HasComments: Yes

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8396 )

Change subject: [tools] limit per-session error buffer space
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc
File src/kudu/tools/tool_action_perf.cc:

http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@88
PS3, Line 88: consider using the
Nit: simplify to "use the"


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@89
PS3, Line 89: Here is an example
Nit: "For example" (simpler)


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@185
PS3, Line 185: might
Nit: may


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@219
PS3, Line 219:  "buffer space might impose an additional upper 
limit for the "
Nit: may



--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Oct 2017 17:47:08 +
Gerrit-HasComments: Yes

[kudu-CR] [tools] limit per-session error buffer space

2017-10-25 Thread Alexey Serbin (Code Review) 
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8396

to look at the new patch set (#3).

Change subject: [tools] limit per-session error buffer space
..

[tools] limit per-session error buffer space

Introduced --error-buffer-size-bytes flag to control the size of the
per-session error buffer.  By default, the limit is set to 16MB per
session (i.e. per worker thread).

Prior to this patch, the per-session error buffer had no size limit
and could grow very large because of huge number of errors during the
run (e.g., because of duplicate value errors).

I also updated the in-line documentation to add an example of using
the tool for subsequent runs against the same table using the
--seq-start flag.

Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 41 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/8396/3
--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tools] limit per-session error buffer space

2017-10-25 Thread Alexey Serbin (Code Review) 
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8396

to look at the new patch set (#2).

Change subject: [tools] limit per-session error buffer space
..

[tools] limit per-session error buffer space

Introduced --error-buffer-size-bytes flag to control the size of the
per-session error buffer.  By default, the limit is set to 16MB per
session (i.e. per worker thread).

Prior to this patch, the per-session error buffer had no size limit
and could grow very large because of huge number of errors during the
run (e.g., because of duplicate value errors).

Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 37 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/8396/2
--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tools] limit per-session error buffer space

2017-10-25 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8396


Change subject: [tools] limit per-session error buffer space
..

[tools] limit per-session error buffer space

Introduced --error-buffer-size-bytes flag to control the size of the
per-session error buffer.  By default, the limit is set to 16MB per
session (i.e. per worker thread).

Prior to this patch, the per-session error buffer had no size limit
and could grow very large because of huge number of errors during the
run (e.g., because of duplicate value errors).

Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
---
M src/kudu/tools/tool_action_perf.cc
1 file changed, 37 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/8396/1
--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin