[kudu-CR] Add a workaround for LSAN bug #757

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged.

Change subject: Add a workaround for LSAN bug #757
..


Add a workaround for LSAN bug #757

This adds a workaround for an LSAN bug[1] which causes some tests to
report false positive leaks when shutting down minicluster daemons.
The workaround simply retries the checks a few times to see if they go
away.

Hopefully this will reduce flakiness of exactly_once_writes-itest.

https://github.com/google/sanitizers/issues/757

Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Reviewed-on: http://gerrit.cloudera.org:8080/7052
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
Reviewed-by: David Ribeiro Alves 
---
M src/kudu/server/generic_service.cc
1 file changed, 15 insertions(+), 1 deletion(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Add a workaround for LSAN bug #757

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add a workaround for LSAN bug #757
..


Patch Set 1: Code-Review+2

agreed

-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a workaround for LSAN bug #757

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: Add a workaround for LSAN bug #757
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc
File src/kudu/server/generic_service.cc:

PS1, Line 136: has_leaks = __lsan_do_recoverable_leak_check();
> lsan_do_recoverable_leak_check already does print the leak to stderr. I sup
I would agree w/ David if __lsan_do_recoverable_leak_check() didn't already log 
(I didn't know that either) but since it does then I think it would add 
unnecessary spam to the log. This seems fine.


-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add a workaround for LSAN bug #757

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: Add a workaround for LSAN bug #757
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a workaround for LSAN bug #757

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Add a workaround for LSAN bug #757
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc
File src/kudu/server/generic_service.cc:

PS1, Line 136: has_leaks = __lsan_do_recoverable_leak_check();
> LOG(WARN) when a leak is found but we're retrying? could we print the leak 
lsan_do_recoverable_leak_check already does print the leak to stderr. I suppose 
we could log the retries but is that useful on top of also logging the leaks?


-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add a workaround for LSAN bug #757

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add a workaround for LSAN bug #757
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc
File src/kudu/server/generic_service.cc:

PS1, Line 136: has_leaks = __lsan_do_recoverable_leak_check();
LOG(WARN) when a leak is found but we're retrying? could we print the leak 
itself?


-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Add a workaround for LSAN bug #757

[Todd Lipcon (Code Review)]

Hello Mike Percy,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/7052

to review the following change.

Change subject: Add a workaround for LSAN bug #757
..

Add a workaround for LSAN bug #757

This adds a workaround for an LSAN bug[1] which causes some tests to
report false positive leaks when shutting down minicluster daemons.
The workaround simply retries the checks a few times to see if they go
away.

Hopefully this will reduce flakiness of exactly_once_writes-itest.

https://github.com/google/sanitizers/issues/757

Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
---
M src/kudu/server/generic_service.cc
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/7052/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Mike Percy