[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. Patch Set 4: Verified+1 No need to wait for precommit; there's nothing to build here. -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Dec 2018 20:25:12 + Gerrit-HasComments: No
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. KUDU-1375: [docs] Remove "binaries" in the Build from Source section - make install does not install the Kudu binaries Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Reviewed-on: http://gerrit.cloudera.org:8080/12060 Reviewed-by: Adar Dembo Tested-by: Adar Dembo --- M docs/installation.adoc 1 file changed, 33 insertions(+), 4 deletions(-) Approvals: Adar Dembo: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12060/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12060/3//COMMIT_MSG@9 PS3, Line 9: make > Nit: 'install' would be more appropriate here. Done -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Dec 2018 20:16:17 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Dec 2018 20:16:24 + Gerrit-HasComments: No
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12060 to look at the new patch set (#4). Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. KUDU-1375: [docs] Remove "binaries" in the Build from Source section - make install does not install the Kudu binaries Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 --- M docs/installation.adoc 1 file changed, 33 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/12060/4 -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12060/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12060/3//COMMIT_MSG@9 PS3, Line 9: make Nit: 'install' would be more appropriate here. -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Dec 2018 05:49:38 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@420 PS2, Line 420: NOTE: 'make install' does not copy Kudu binaries. You need to manually copy them > This text block should be replicated into the other _from_source sections ( Done http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@424 PS2, Line 424: the your > Nit: drop one of these. Done http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@426 PS2, Line 426: if you use the default installation directory > I would tie this more directly to DESTDIR from L413-414. Done -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Dec 2018 00:46:29 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12060 to look at the new patch set (#3). Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. KUDU-1375: [docs] Remove "binaries" in the Build from Source section - make install does not make the Kudu binaries Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 --- M docs/installation.adoc 1 file changed, 33 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/12060/3 -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12060 ) Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@420 PS2, Line 420: NOTE: 'make install' does not copy Kudu binaries. You need to manually copy them This text block should be replicated into the other _from_source sections (except for osx, where we don't doc `make install` at all). http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@424 PS2, Line 424: the your Nit: drop one of these. http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@426 PS2, Line 426: if you use the default installation directory I would tie this more directly to DESTDIR from L413-414. -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Dec 2018 23:07:12 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12060 to look at the new patch set (#2). Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. KUDU-1375: [docs] Remove "binaries" in the Build from Source section - make install does not make the Kudu binaries Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 --- M docs/installation.adoc 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/12060/2 -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1375: [docs] Remove "binaries" in the Build from Source section
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12060 Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source section .. KUDU-1375: [docs] Remove "binaries" in the Build from Source section - make install does not make the Kudu binaries Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 --- M docs/installation.adoc 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/12060/1 -- To view, visit http://gerrit.cloudera.org:8080/12060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121 Gerrit-Change-Number: 12060 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
