[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 20:39:09 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Todd Lipcon (Code Review)]

Todd Lipcon has removed a vote on this change.

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..

KUDU-2385: Fix typo in KinitContext::DoRenewal()

On platforms without krb5_get_init_creds_opt_set_out_ccache(),
krb5_cc_store_cred() is called to insert the newly acquired
credential into the ccache. However, there was a typo in the code
which resulted in inserting the old credential into ccache.
This change fixes the typo to make sure the new credential is
inserted into ccache.

Testing done: confirmed on SLES11 that the new credential
is being inserted by checking the 'auth time' of the ticket
in ccache. Impala uses a slightly different #ifdef which
explicitly checks if krb5_get_init_creds_opt_set_out_ccache()
is defined on the platform so this code path is actually
used when running Impala on SLES11.

Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Reviewed-on: http://gerrit.cloudera.org:8080/9840
Reviewed-by: Todd Lipcon 
Tested-by: Todd Lipcon 
---
M src/kudu/security/init.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 2:

Many tests failed with:

Runtime error: Failed to start a single Master: 
/tmp/dist-test-task3oJsII/build/asan/bin/kudu-master: process exited on signal 6

Seems to be the same flakiness with the clock source:

F0328 19:19:56.575935  9523 master_main.cc:74] Check failed: _s.ok() Bad 
status: Service unavailable: Cannot initialize clock: Error reading clock. 
Clock considered unsynchronized
*** Check failure stack trace: ***
@ 0x7ffb3f59062d  google::LogMessage::Fail() at ??:0
@ 0x7ffb3f59264c  google::LogMessage::SendToLog() at ??:0
@ 0x7ffb3f590189  google::LogMessage::Flush() at ??:0
@ 0x7ffb3f592fdf  google::LogMessageFatal::~LogMessageFatal() at ??:0
@   0x51eb6f  kudu::master::MasterMain() at 
/home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/asan/asan_stack.h:48
@   0x51e135  main at 
/home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/asan/asan_interceptors.cc:42
@ 0x7ffb3c997f45  __libc_start_main at ??:0
@   0x420cba  (unknown) at ??:0
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/integration-tests/ts_itest-base.cc:146:
 Failure
Failed
Bad status: Runtime error: Failed to start a single Master: 
/tmp/dist-test-task3oJsII/build/asan/bin/kudu-master: process exited on signal 6


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 20:13:09 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:55:01 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 2:

(1 comment)

Hi Todd, good suggestion. It'd be better if this is done in another patch as we 
have multiple of them and I don't want to complicate this patch.

http://gerrit.cloudera.org:8080/#/c/9840/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9840/1//COMMIT_MSG@16
PS1, Line 16: confirmed on SLES11 that the new credential
: is being inserted by checking the 'auth time' of the ticket
: in ccache.
> nit: Could you also add that this was found on SLES11 because Impala has a
Done



--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:15:59 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Michael Ho (Code Review)]

Hello Kudu Jenkins, Sailesh Mukil, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9840

to look at the new patch set (#2).

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..

KUDU-2385: Fix typo in KinitContext::DoRenewal()

On platforms without krb5_get_init_creds_opt_set_out_ccache(),
krb5_cc_store_cred() is called to insert the newly acquired
credential into the ccache. However, there was a typo in the code
which resulted in inserting the old credential into ccache.
This change fixes the typo to make sure the new credential is
inserted into ccache.

Testing done: confirmed on SLES11 that the new credential
is being inserted by checking the 'auth time' of the ticket
in ccache. Impala uses a slightly different #ifdef which
explicitly checks if krb5_get_init_creds_opt_set_out_ccache()
is defined on the platform so this code path is actually
used when running Impala on SLES11.

Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
---
M src/kudu/security/init.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/9840/2
--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 1:

> Patch Set 1:
>
> Todd, we use this macro here: 
> https://github.com/apache/impala/blob/master/be/CMakeLists.txt#L349-L350
>
> CHECK_LIBRARY_EXISTS("krb5" krb5_get_init_creds_opt_set_out_ccache
>   ${KERBEROS_LIBRARY} HAVE_KRB5_GET_INIT_CREDS_OPT_SET_OUT_CCACHE)

Perhaps we can port that over into the security/CMakeLists.txt ? It desn't have 
to be in this same patch, just a suggestion to reduce divergence between code


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:08:12 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 1:

Todd, we use this macro here: 
https://github.com/apache/impala/blob/master/be/CMakeLists.txt#L349-L350

CHECK_LIBRARY_EXISTS("krb5" krb5_get_init_creds_opt_set_out_ccache
  ${KERBEROS_LIBRARY} HAVE_KRB5_GET_INIT_CREDS_OPT_SET_OUT_CCACHE)


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:03:36 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 1: Code-Review+2

lgtm. Wonder if there is a better #ifdef we could be checking for so you don't 
have to maintain the different ifdef to support sles11.


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 28 Mar 2018 19:01:03 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 1:

Build failure doesn't look relevant: RaftConsensusQuorumTest.TestRequestVote

Failing for the past 1 build (Since Failed#12725 )
Took 0 ms.
Error Message
thread_collision_warner.cc:23] Thread Collision! Previous thread id: 425, 
current thread id: 770
Stacktrace

thread_collision_warner.cc:23] Thread Collision! Previous thread id: 425, 
current thread id: 770
@   0x45838e __tsan::CallUserSignalHandler() at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1819
@   0x45930b rtl_sigaction() at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1907
@ 0x7f1af83dcc37 gsignal at ??:0
@ 0x7f1af83e0028 abort at ??:0
@   0x47f098 __interceptor_abort at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1675
@ 0x7f1afaeae2b5 base::DCheckAsserter::warn() at ??:0
@ 0x7f1afaeae32e base::ThreadCollisionWarner::EnterSelf() at ??:0
@ 0x7f1b032d98e9 
base::ThreadCollisionWarner::ScopedRecursiveCheck::ScopedRecursiveCheck() at 
??:0
@ 0x7f1b032d75c2 kudu::consensus::ConsensusMetadata::current_term() at 
??:0
@ 0x7f1b0332038c kudu::consensus::RaftConsensus::CurrentTermUnlocked() 
at ??:0
@ 0x7f1b0332be31 
kudu::consensus::RaftConsensus::HandleLeaderRequestTermUnlocked() at ??:0
@ 0x7f1b0332c8f0 
kudu::consensus::RaftConsensus::CheckLeaderRequestUnlocked() at ??:0
@ 0x7f1b03328f95 kudu::consensus::RaftConsensus::UpdateReplica() at ??:0
@ 0x7f1b03328a81 kudu::consensus::RaftConsensus::Update() at ??:0
@   0x510a7c 
kudu::consensus::LocalTestPeerProxy::SendUpdateRequest() at 
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/consensus/consensus-test-util.h:?
@   0x511bb8 boost::_mfi::mf2<>::operator()() at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/mem_fn_template.hpp:280
 (discriminator 3)
@   0x511aed boost::_bi::list3<>::operator()<>() at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/bind.hpp:399
@   0x511a14 boost::_bi::bind_t<>::operator()() at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/bind/bind.hpp:1223
@   0x5117a2 
boost::detail::function::void_function_obj_invoker0<>::invoke() at 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/boost/function/function_template.hpp:160
@ 0x7f1afdd12c02 boost::function0<>::operator()() at ??:0
@ 0x7f1afb29c66e kudu::FunctionRunnable::Run() at ??:0
@ 0x7f1afb2980d9 kudu::ThreadPool::DispatchThread() at ??:0
@ 0x7f1afb2a2ea7 boost::_mfi::mf0<>::operator()() at ??:0
@ 0x7f1afb2a2dfb boost::_bi::list1<>::operator()<>() at ??:0
@ 0x7f1afb2a2d84 boost::_bi::bind_t<>::operator()() at ??:0
@ 0x7f1afb2a2b8a 
boost::detail::function::void_function_obj_invoker0<>::invoke() at ??:0
@ 0x7f1afdd12c02 boost::function0<>::operator()() at ??:0


 Help us localize this page Page generated: Mar 28, 2018 11:52:11 AM PDTREST 
APIJenkins ver. 2.46.3


--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Wed, 28 Mar 2018 18:52:39 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9840/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9840/1//COMMIT_MSG@16
PS1, Line 16: confirmed on SLES11 that the new credential
: is being inserted by checking the 'auth time' of the ticket
: in ccache.
nit: Could you also add that this was found on SLES11 because Impala has a 
slightly different ifdef which exercised that path on SLES11?
https://github.com/apache/impala/blob/6f2ebadf8d119b1486f54b911ba3c7ecc1921d55/be/src/kudu/security/init.cc#L344-L352



--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Wed, 28 Mar 2018 18:13:44 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

[Michael Ho (Code Review)]

Michael Ho has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9840


Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
..

KUDU-2385: Fix typo in KinitContext::DoRenewal()

On platforms without krb5_get_init_creds_opt_set_out_ccache(),
krb5_cc_store_cred() is called to insert the newly acquired
credential into the ccache. However, there was a typo in the code
which resulted in inserting the old credential into ccache.
This change fixes the typo to make sure the new credential is
inserted into ccache.

Testing done: confirmed on SLES11 that the new credential
is being inserted by checking the 'auth time' of the ticket
in ccache.

Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
---
M src/kudu/security/init.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/9840/1
--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho